Re: [PATCH 0/3] Add initial DT support for Qualcomm SPMI PMIC devices
On Tue, 2015-03-03 at 00:19 -0800, Stephen Boyd wrote: > On 02/26, Ivan T. Ivanov wrote: > > Hi Stephen, > > > > Sorry for delayed answer. > > > > On Thu, 2015-02-19 at 16:49 -0800, Stephen Boyd wrote: > > > On 02/03/15 04:17, Ivan T. Ivanov wrote: > > > > Following set of patches add initial DT support for PMIC devices > > > > found on recent Quqalcomm chipsets. Details for SPMI bus and PMIC > > > > arbiter > > > > could be found here [1]. > > > > > > Can you please put the specific compatible strings for the pmic model > > > into the nodes in addition to the generic "qcom,spmi-pmic"? We may want > > > to have regmap config tables in the future that describe the > > > cache/read/write abilities of the regsiters. If all we have is the > > > generic binding then we don't have a way to populate these tables. > > > Unless the plan there is to use the revid registers? > > > > > > > I would really like that we can use "revid" registers, but I don't know... > > > > From what I can see usually in one physical PMIC chip they > > are 2 USID devices. > > > > I can successfully discover following USID's on APQ8074 boards: > > > > pmic-spmi 0-00: qcom,pm8941-v1.0 detected > > pmic-spmi 0-01: qcom,pm8941-v1.0 detected > > pmic-spmi 0-04: qcom,pm8841-v0.0 detected > > pmic-spmi 0-05: qcom,pm8841-v0.0 detected > > > > Unfortunately on PM8916 only one device is detected, with USID 0. > > But they should be two, judging by downstream DTS files, right? > > > > pmic-spmi 0-00: qcom,pm8916-v0.0 detected > > pmic-spmi 0-01: unknown device > > > > For communication with PM8916 I am using recent patches from Gilad [1]. > > Maybe there are still some issues with these patches, which can cause > > this behavior or PM8916 just didn't have these registers for USID 1? > > > > Regards, > > Ivan > > Hmm... do you have 4 total rev-id nodes on apq8074? I only see > one rev-id node per pmic (2 total), so I'm a little lost how the > correct pmic version is detected on the 0-01 and 0-05 devices in > your example above. Same confusion here. I am using this[1] patch to read revision info. Address at offset 0x105 for USID 0,1 on PM8914 and USID 4,5 on PM8841 contains 0x51, which denotes them as PMIC's, so patch assumes that rest of the registers have to contain valid version values. Regards, Ivan [1] http://permalink.gmane.org/gmane.linux.kernel/1900135 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] Add initial DT support for Qualcomm SPMI PMIC devices
On 02/26, Ivan T. Ivanov wrote: > > Hi Stephan, > > Sorry for delayed answer. > > On Thu, 2015-02-19 at 16:49 -0800, Stephen Boyd wrote: > > On 02/03/15 04:17, Ivan T. Ivanov wrote: > > > Following set of patches add initial DT support for PMIC devices > > > found on recent Quqalcomm chipsets. Details for SPMI bus and PMIC arbiter > > > could be found here [1]. > > > > Can you please put the specific compatible strings for the pmic model > > into the nodes in addition to the generic "qcom,spmi-pmic"? We may want > > to have regmap config tables in the future that describe the > > cache/read/write abilities of the regsiters. If all we have is the > > generic binding then we don't have a way to populate these tables. > > Unless the plan there is to use the revid registers? > > > > I would really like that we can use "revid" registers, but I don't know... > > From what I can see usually in one physical PMIC chip they > are 2 USID devices. > > I can successfully discover following USID's on APQ8074 boards: > > pmic-spmi 0-00: qcom,pm8941-v1.0 detected > pmic-spmi 0-01: qcom,pm8941-v1.0 detected > pmic-spmi 0-04: qcom,pm8841-v0.0 detected > pmic-spmi 0-05: qcom,pm8841-v0.0 detected > > Unfortunately on PM8916 only one device is detected, with USID 0. > But they should be two, judging by downstream DTS files, right? > > pmic-spmi 0-00: qcom,pm8916-v0.0 detected > pmic-spmi 0-01: unknown device > > For communication with PM8916 I am using recent patches from Gilad [1]. > Maybe there are still some issues with these patches, which can cause > this behavior or PM8916 just didn't have these registers for USID 1? > > Regards, > Ivan Hmm... do you have 4 total rev-id nodes on apq8074? I only see one rev-id node per pmic (2 total), so I'm a little lost how the correct pmic version is detected on the 0-01 and 0-05 devices in your example above. Maybe I've missed something though, I'll have to check in a few hours when I'm in the office. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] Add initial DT support for Qualcomm SPMI PMIC devices
Hi Stephan, Sorry for delayed answer. On Thu, 2015-02-19 at 16:49 -0800, Stephen Boyd wrote: > On 02/03/15 04:17, Ivan T. Ivanov wrote: > > Following set of patches add initial DT support for PMIC devices > > found on recent Quqalcomm chipsets. Details for SPMI bus and PMIC arbiter > > could be found here [1]. > > Can you please put the specific compatible strings for the pmic model > into the nodes in addition to the generic "qcom,spmi-pmic"? We may want > to have regmap config tables in the future that describe the > cache/read/write abilities of the regsiters. If all we have is the > generic binding then we don't have a way to populate these tables. > Unless the plan there is to use the revid registers? > I would really like that we can use "revid" registers, but I don't know... >From what I can see usually in one physical PMIC chip they are 2 USID devices. I can successfully discover following USID's on APQ8074 boards: pmic-spmi 0-00: qcom,pm8941-v1.0 detected pmic-spmi 0-01: qcom,pm8941-v1.0 detected pmic-spmi 0-04: qcom,pm8841-v0.0 detected pmic-spmi 0-05: qcom,pm8841-v0.0 detected Unfortunately on PM8916 only one device is detected, with USID 0. But they should be two, judging by downstream DTS files, right? pmic-spmi 0-00: qcom,pm8916-v0.0 detected pmic-spmi 0-01: unknown device For communication with PM8916 I am using recent patches from Gilad [1]. Maybe there are still some issues with these patches, which can cause this behavior or PM8916 just didn't have these registers for USID 1? Regards, Ivan [1] https://lkml.org/lkml/2015/2/19/453 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] Add initial DT support for Qualcomm SPMI PMIC devices
On 02/03/15 04:17, Ivan T. Ivanov wrote: > Following set of patches add initial DT support for PMIC devices > found on recent Quqalcomm chipsets. Details for SPMI bus and PMIC arbiter > could be found here [1]. Can you please put the specific compatible strings for the pmic model into the nodes in addition to the generic "qcom,spmi-pmic"? We may want to have regmap config tables in the future that describe the cache/read/write abilities of the regsiters. If all we have is the generic binding then we don't have a way to populate these tables. Unless the plan there is to use the revid registers? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] Add initial DT support for Qualcomm SPMI PMIC devices
On Tue, Feb 03, 2015 at 02:17:57PM +0200, Ivan T. Ivanov wrote: > Following set of patches add initial DT support for PMIC devices > found on recent Quqalcomm chipsets. Details for SPMI bus and PMIC arbiter > could be found here [1]. > Looks fine. Reviewed-by: Andy Gross -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] Add initial DT support for Qualcomm SPMI PMIC devices
On Tue, 2015-02-03 at 12:38 -0800, Bjorn Andersson wrote: > On Tue, Feb 3, 2015 at 4:17 AM, Ivan T. Ivanov wrote: > > Following set of patches add initial DT support for PMIC devices > > found on recent Quqalcomm chipsets. Details for SPMI bus and PMIC arbiter > > could be found here [1]. > > > > Regards, > > Ivan > > > > [1] http://lwn.net/Articles/564637/ > > > > Ivan T. Ivanov (3): > > ARM: dts: qcom: Add SPMI PMIC Arbiter nodes for APQ8084 and MSM8974 > > ARM: dts: qcom: Add 8x74 chipset SPMI PMIC's nodes > > ARM: dts: qcom: Add APQ8084 chipset SPMI PMIC's nodes > > > > Looks good. > > Reviewed-by: Bjorn Andersson anders...@sonymobile.com> > Thank you. Any other comments? Kumar? Regards, Ivan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] Add initial DT support for Qualcomm SPMI PMIC devices
On Tue, Feb 3, 2015 at 4:17 AM, Ivan T. Ivanov wrote: > Following set of patches add initial DT support for PMIC devices > found on recent Quqalcomm chipsets. Details for SPMI bus and PMIC arbiter > could be found here [1]. > > Regards, > Ivan > > [1] http://lwn.net/Articles/564637/ > > Ivan T. Ivanov (3): > ARM: dts: qcom: Add SPMI PMIC Arbiter nodes for APQ8084 and MSM8974 > ARM: dts: qcom: Add 8x74 chipset SPMI PMIC's nodes > ARM: dts: qcom: Add APQ8084 chipset SPMI PMIC's nodes > Looks good. Reviewed-by: Bjorn Andersson Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/3] Add initial DT support for Qualcomm SPMI PMIC devices
Following set of patches add initial DT support for PMIC devices found on recent Quqalcomm chipsets. Details for SPMI bus and PMIC arbiter could be found here [1]. Regards, Ivan [1] http://lwn.net/Articles/564637/ Ivan T. Ivanov (3): ARM: dts: qcom: Add SPMI PMIC Arbiter nodes for APQ8084 and MSM8974 ARM: dts: qcom: Add 8x74 chipset SPMI PMIC's nodes ARM: dts: qcom: Add APQ8084 chipset SPMI PMIC's nodes arch/arm/boot/dts/qcom-apq8074-dragonboard.dts| 2 ++ arch/arm/boot/dts/qcom-apq8084-ifc6540.dts| 1 + arch/arm/boot/dts/qcom-apq8084-mtp.dts| 1 + arch/arm/boot/dts/qcom-apq8084.dtsi | 16 arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dts | 2 ++ arch/arm/boot/dts/qcom-msm8974.dtsi | 16 arch/arm/boot/dts/qcom-pm8841.dtsi| 18 ++ arch/arm/boot/dts/qcom-pm8941.dtsi| 18 ++ arch/arm/boot/dts/qcom-pma8084.dtsi | 18 ++ 9 files changed, 92 insertions(+) create mode 100644 arch/arm/boot/dts/qcom-pm8841.dtsi create mode 100644 arch/arm/boot/dts/qcom-pm8941.dtsi create mode 100644 arch/arm/boot/dts/qcom-pma8084.dtsi -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
