Re: [PATCH 1/4][v4] ARM: imx: imx7d-pinfunc: add gpio pad iomuxc settings
On Fri, Jul 17, 2015 at 5:51 AM, Shawn Guo wrote: > On Thu, Jul 16, 2015 at 03:34:44PM -0500, Adrian Alonso wrote: >> * Add iMX7D SoC imx7d-pinfunc gpio pad settings >> >> * iMX7D GPIO1_IO7 to GPIO1_IO0 encode the pad group id in the most >> significant bits of input_val to avoid group id overlap bweeten >> iomuxc and iomuxc-lpsr. >> >> Signed-off-by: Adrian Alonso > > Unless you can convince me that this approach which hacks select input > value is better than two instances one, it's an NACK for me on the whole > patch series. I'm dropping this patch series until this is resolved. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/4][v4] ARM: imx: imx7d-pinfunc: add gpio pad iomuxc settings
On Thu, Jul 16, 2015 at 03:34:44PM -0500, Adrian Alonso wrote: > * Add iMX7D SoC imx7d-pinfunc gpio pad settings > > * iMX7D GPIO1_IO7 to GPIO1_IO0 encode the pad group id in the most > significant bits of input_val to avoid group id overlap bweeten > iomuxc and iomuxc-lpsr. > > Signed-off-by: Adrian Alonso Unless you can convince me that this approach which hacks select input value is better than two instances one, it's an NACK for me on the whole patch series. Shawn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/4][v4] ARM: imx: imx7d-pinfunc: add gpio pad iomuxc settings
* Add iMX7D SoC imx7d-pinfunc gpio pad settings * iMX7D GPIO1_IO7 to GPIO1_IO0 encode the pad group id in the most significant bits of input_val to avoid group id overlap bweeten iomuxc and iomuxc-lpsr. Signed-off-by: Adrian Alonso --- - Version 2: Use input_val upper 16 bits to represent pad group id - Version 3: Resend - Version 4: Resend arch/arm/boot/dts/imx7d-pinfunc.h | 116 ++ 1 file changed, 116 insertions(+) diff --git a/arch/arm/boot/dts/imx7d-pinfunc.h b/arch/arm/boot/dts/imx7d-pinfunc.h index a8d8149..9460d5c 100644 --- a/arch/arm/boot/dts/imx7d-pinfunc.h +++ b/arch/arm/boot/dts/imx7d-pinfunc.h @@ -15,6 +15,122 @@ * */ +#define MX7D_PAD_GPIO1_IO00__GPIO1_IO0 0x 0x0030 0x 0x0 0x009B +#define MX7D_PAD_GPIO1_IO00__PWM4_OUT0x 0x0030 0x 0x1 0x009B +#define MX7D_PAD_GPIO1_IO00__WDOD1_WDOG_ANY 0x 0x0030 0x 0x2 0x009B +#define MX7D_PAD_GPIO1_IO00__WDOD1_WDOG_B0x 0x0030 0x 0x3 0x009B +#define MX7D_PAD_GPIO1_IO00__WDOD1_WDOG__RST_B_DEB 0x 0x0030 0x 0x4 0x009B +#define MX7D_PAD_GPIO1_IO01__GPIO1_IO1 0x0004 0x0034 0x 0x0 0x009C +#define MX7D_PAD_GPIO1_IO01__PWM1_OUT0x0004 0x0034 0x 0x1 0x009C +#define MX7D_PAD_GPIO1_IO01__CCM_ENET_REF_CLK3 0x0004 0x0034 0x 0x2 0x009C +#define MX7D_PAD_GPIO1_IO01__SAI1_MCLK 0x0004 0x0034 0x 0x3 0x009C +#define MX7D_PAD_GPIO1_IO01__ANATOP_24M_OUT 0x0004 0x0034 0x 0x4 0x009C +#define MX7D_PAD_GPIO1_IO01__OBSERVE0_OUT0x0004 0x0034 0x 0x6 0x009C +#define MX7D_PAD_GPIO1_IO02__GPIO1_IO2 0x0008 0x0038 0x 0x0 0x009D +#define MX7D_PAD_GPIO1_IO02__PWM2_OUT0x0008 0x0038 0x 0x1 0x009D +#define MX7D_PAD_GPIO1_IO02__CCM_ENET_REF_CLK1 0x0008 0x0038 0x0564 0x2 0x009D0003 +#define MX7D_PAD_GPIO1_IO02__SAI2_MCLK 0x0008 0x0038 0x 0x3 0x009D +#define MX7D_PAD_GPIO1_IO02__CCM_CLKO1 0x0008 0x0038 0x 0x5 0x009D +#define MX7D_PAD_GPIO1_IO02__OBSERVE1_OUT0x0008 0x0038 0x 0x6 0x009D +#define MX7D_PAD_GPIO1_IO02__USB_OTG1_ID 0x0008 0x0038 0x0734 0x7 0x009D0003 +#define MX7D_PAD_GPIO1_IO03__GPIO1_IO3 0x000C 0x003C 0x 0x0 0x009E +#define MX7D_PAD_GPIO1_IO03__PWM3_OUT0x000C 0x003C 0x 0x1 0x009E +#define MX7D_PAD_GPIO1_IO03__CCM_ENET_REF_CLK2 0x000C 0x003C 0x0570 0x2 0x009E0003 +#define MX7D_PAD_GPIO1_IO03__SAI3_MCLK 0x000C 0x003C 0x 0x3 0x009E +#define MX7D_PAD_GPIO1_IO03__CCM_CLKO2 0x000C 0x003C 0x 0x5 0x009E +#define MX7D_PAD_GPIO1_IO03__OBSERVE2_OUT0x000C 0x003C 0x 0x6 0x009E +#define MX7D_PAD_GPIO1_IO03__USB_OTG2_ID 0x000C 0x003C 0x0730 0x7 0x009E0003 +#define MX7D_PAD_GPIO1_IO04__GPIO1_IO4 0x0010 0x0040 0x 0x0 0x009F +#define MX7D_PAD_GPIO1_IO04__USB_OTG1_OC 0x0010 0x0040 0x072C 0x1 0x009F0001 +#define MX7D_PAD_GPIO1_IO04__FLEXTIMER1_CH4 0x0010 0x0040 0x0594 0x2 0x009F0001 +#define MX7D_PAD_GPIO1_IO04__UART5_CTS_B 0x0010 0x0040 0x0710 0x3 0x009F0004 +#define MX7D_PAD_GPIO1_IO04__I2C1_SCL0x0010 0x0040 0x05D4 0x4 0x009F0002 +#define MX7D_PAD_GPIO1_IO04__OBSERVE3_OUT0x0010 0x0040 0x 0x6 0x009F +#define MX7D_PAD_GPIO1_IO05__GPIO1_IO5 0x0014 0x0044 0x 0x0 0x00A0 +#define MX7D_PAD_GPIO1_IO05__USB_OTG1_PWR0x0014 0x0044 0x 0x1 0x00A0 +#define MX7D_PAD_GPIO1_IO05__FLEXTIMER1_CH5 0x0014 0x0044 0x0598 0x2 0x00A1 +#define MX7D_PAD_GPIO1_IO05__UART5_RTS_B 0x0014 0x0044 0x0710 0x3 0x00A5 +#define MX7D_PAD_GPIO1_IO05__I2C1_SDA0x0014 0x0044 0x05D8 0x4 0x00A2 +#define MX7D_PAD_GPIO1_IO05__OBSERVE4_OUT0x0014 0x0044 0x 0x6 0x00A0 +#define MX7D_PAD_GPIO1_IO06__GPIO1_IO6 0x0018 0x0048 0x 0x0 0x00A1 +#define MX7D_PAD_GPIO1_IO06__USB_OTG2_OC 0x0018 0x0048 0x0728 0x1 0x00A10001 +#define MX7D_PAD_GPIO1_IO06__FLEXTIMER1_CH6 0x0018 0x0048 0x059C 0x2 0x00A10001 +#define MX7D_PAD_GPIO1_IO06__UART5_RX_DATA 0x0018 0x0048 0x0714 0x3 0x00A10004 +#define MX7D_PAD_GPIO1_IO06__I2C2_SCL0x0018 0x0048
