Re: [PATCH RESEND] ARM: dts: OMAP3-N900: Add microphone bias voltages
* Sebastian Reichel s...@kernel.org [150331 05:33]: Hi, On Mon, Mar 30, 2015 at 10:50:52AM -0700, Tony Lindgren wrote: * Jarkko Nikula jarkko.nik...@bitmer.com [150330 10:46]: Well, there has been regression but finding exactly how far should the fix go didn't look instantly straightforward due all DT, codec driver mic bias etc changes and I ended up not cc'ing stable. But well, I guess first kernel where this commit makes sense is 3.16+ due commit f7d0f2a08567 (ARM: dts: omap3-n900: Add sound support). Although it applies on top of commit 14e3e295b2b9 (ARM: dts: omap3-n900: Add TLV320AIC3X support) too (3.12+) but not before that. OK I think debian is using v3.16 kernel Yes. It will be used for Debian jessie (not yet released) and the N900 related drivers are enabled in the armmp flavour. Unfortunately it does not work together with thumb using userland because the errata 430973 workaround is not enabled. See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=768890 Hmm I believe many ARMv8 boards will be randomly oopsing with armhf without that. I sort of recall random oopses just with running apt-get update on ARMv8 omaps on armhf without that: http://www.spinics.net/lists/linux-omap/msg108511.html See also 5c86c5339c56 (ARM: omap2plus_defconfig: Enable ARM erratum 430973 for omap3). I wonder if the ARMv8 revision range might be wrong 430973 in kernel or errata? Also I recall that 430973 change to the arch/arm/mm/proc-v7-2level.S fixed the issue, this should be verified though. I guess it should be tried to change the workaround, so that it does only change the behaviour of affected platforms. Otherwise its a hard decision for distributions to enable the workaround. Well we should figure out first why flush BTAC/BTB is needed in cpu_v7_switch_mm.. And if what I'm describing above is still reproducable. and that's pretty much the first kernel that is usable with dts on many omap3 devices so might make sense for that. DT support for N900's soundcard has been added in 3.16, so before that the audio stuff didn't work at all. I can add it if you think it makes sense. I guess backporting this makes sense because of fewer broken DTB files in the wild. Anyways yeah adding $subject patch into omap-for-v4.0/fixes with cc stable v3.16+. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RESEND] ARM: dts: OMAP3-N900: Add microphone bias voltages
Hi, On Mon, Mar 30, 2015 at 10:50:52AM -0700, Tony Lindgren wrote: * Jarkko Nikula jarkko.nik...@bitmer.com [150330 10:46]: Well, there has been regression but finding exactly how far should the fix go didn't look instantly straightforward due all DT, codec driver mic bias etc changes and I ended up not cc'ing stable. But well, I guess first kernel where this commit makes sense is 3.16+ due commit f7d0f2a08567 (ARM: dts: omap3-n900: Add sound support). Although it applies on top of commit 14e3e295b2b9 (ARM: dts: omap3-n900: Add TLV320AIC3X support) too (3.12+) but not before that. OK I think debian is using v3.16 kernel Yes. It will be used for Debian jessie (not yet released) and the N900 related drivers are enabled in the armmp flavour. Unfortunately it does not work together with thumb using userland because the errata 430973 workaround is not enabled. See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=768890 I guess it should be tried to change the workaround, so that it does only change the behaviour of affected platforms. Otherwise its a hard decision for distributions to enable the workaround. and that's pretty much the first kernel that is usable with dts on many omap3 devices so might make sense for that. DT support for N900's soundcard has been added in 3.16, so before that the audio stuff didn't work at all. I can add it if you think it makes sense. I guess backporting this makes sense because of fewer broken DTB files in the wild. -- Sebastian signature.asc Description: Digital signature
Re: [PATCH RESEND] ARM: dts: OMAP3-N900: Add microphone bias voltages
On 03/30/2015 07:42 PM, Tony Lindgren wrote: * Jarkko Nikula jarkko.nik...@bitmer.com [150330 09:31]: On 03/01/2015 09:07 PM, Jarkko Nikula wrote: From: Pavel Machek pa...@ucw.cz N900 audio recording needs that codec provides bias voltage for integrated digital microphone and headset microphone depending which one is used. Digital microphone uses 2 V bias and it comes from the codec A part. Codec B part drives the headset microphone bias and that is set to 2.5 V. Signed-off-by: Pavel Machek pa...@ucw.cz [Jarkko: Headset mic bias changed to 2 (2.5 V) as it was before commit e2e8bfdf6157 (ASoC: tlv320aic3x: Convert mic bias to a supply widget)] Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- arch/arm/boot/dts/omap3-n900.dts | 4 1 file changed, 4 insertions(+) Ping? Oops sorry I have missed this one. This looks like a regression fix for the v4.0-rc series? Should it be cc stable v3.16+ or something? Well, there has been regression but finding exactly how far should the fix go didn't look instantly straightforward due all DT, codec driver mic bias etc changes and I ended up not cc'ing stable. But well, I guess first kernel where this commit makes sense is 3.16+ due commit f7d0f2a08567 (ARM: dts: omap3-n900: Add sound support). Although it applies on top of commit 14e3e295b2b9 (ARM: dts: omap3-n900: Add TLV320AIC3X support) too (3.12+) but not before that. -- Jarkko -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RESEND] ARM: dts: OMAP3-N900: Add microphone bias voltages
* Jarkko Nikula jarkko.nik...@bitmer.com [150330 10:46]: On 03/30/2015 07:42 PM, Tony Lindgren wrote: * Jarkko Nikula jarkko.nik...@bitmer.com [150330 09:31]: On 03/01/2015 09:07 PM, Jarkko Nikula wrote: From: Pavel Machek pa...@ucw.cz N900 audio recording needs that codec provides bias voltage for integrated digital microphone and headset microphone depending which one is used. Digital microphone uses 2 V bias and it comes from the codec A part. Codec B part drives the headset microphone bias and that is set to 2.5 V. Signed-off-by: Pavel Machek pa...@ucw.cz [Jarkko: Headset mic bias changed to 2 (2.5 V) as it was before commit e2e8bfdf6157 (ASoC: tlv320aic3x: Convert mic bias to a supply widget)] Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- arch/arm/boot/dts/omap3-n900.dts | 4 1 file changed, 4 insertions(+) Ping? Oops sorry I have missed this one. This looks like a regression fix for the v4.0-rc series? Should it be cc stable v3.16+ or something? Well, there has been regression but finding exactly how far should the fix go didn't look instantly straightforward due all DT, codec driver mic bias etc changes and I ended up not cc'ing stable. But well, I guess first kernel where this commit makes sense is 3.16+ due commit f7d0f2a08567 (ARM: dts: omap3-n900: Add sound support). Although it applies on top of commit 14e3e295b2b9 (ARM: dts: omap3-n900: Add TLV320AIC3X support) too (3.12+) but not before that. OK I think debian is using v3.16 kernel and that's pretty much the first kernel that is usable with dts on many omap3 devices so might make sense for that. I can add it if you think it makes sense. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RESEND] ARM: dts: OMAP3-N900: Add microphone bias voltages
* Jarkko Nikula jarkko.nik...@bitmer.com [150330 09:31]: On 03/01/2015 09:07 PM, Jarkko Nikula wrote: From: Pavel Machek pa...@ucw.cz N900 audio recording needs that codec provides bias voltage for integrated digital microphone and headset microphone depending which one is used. Digital microphone uses 2 V bias and it comes from the codec A part. Codec B part drives the headset microphone bias and that is set to 2.5 V. Signed-off-by: Pavel Machek pa...@ucw.cz [Jarkko: Headset mic bias changed to 2 (2.5 V) as it was before commit e2e8bfdf6157 (ASoC: tlv320aic3x: Convert mic bias to a supply widget)] Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- arch/arm/boot/dts/omap3-n900.dts | 4 1 file changed, 4 insertions(+) Ping? Oops sorry I have missed this one. This looks like a regression fix for the v4.0-rc series? Should it be cc stable v3.16+ or something? Regards, Tony -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RESEND] ARM: dts: OMAP3-N900: Add microphone bias voltages
On 03/01/2015 09:07 PM, Jarkko Nikula wrote: From: Pavel Machek pa...@ucw.cz N900 audio recording needs that codec provides bias voltage for integrated digital microphone and headset microphone depending which one is used. Digital microphone uses 2 V bias and it comes from the codec A part. Codec B part drives the headset microphone bias and that is set to 2.5 V. Signed-off-by: Pavel Machek pa...@ucw.cz [Jarkko: Headset mic bias changed to 2 (2.5 V) as it was before commit e2e8bfdf6157 (ASoC: tlv320aic3x: Convert mic bias to a supply widget)] Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- arch/arm/boot/dts/omap3-n900.dts | 4 1 file changed, 4 insertions(+) Ping? -- Jarkko -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH RESEND] ARM: dts: OMAP3-N900: Add microphone bias voltages
From: Pavel Machek pa...@ucw.cz
N900 audio recording needs that codec provides bias voltage for integrated
digital microphone and headset microphone depending which one is used.
Digital microphone uses 2 V bias and it comes from the codec A part. Codec
B part drives the headset microphone bias and that is set to 2.5 V.
Signed-off-by: Pavel Machek pa...@ucw.cz
[Jarkko: Headset mic bias changed to 2 (2.5 V) as it was before commit
e2e8bfdf6157 (ASoC: tlv320aic3x: Convert mic bias to a supply widget)]
Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com
---
arch/arm/boot/dts/omap3-n900.dts | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index db80f9d376fa..9c8bdf2c93a1 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -484,6 +484,8 @@
DRVDD-supply = vmmc2;
IOVDD-supply = vio;
DVDD-supply = vio;
+
+ ai3x-micbias-vg = 1;
};
tlv320aic3x_aux: tlv320aic3x@19 {
@@ -495,6 +497,8 @@
DRVDD-supply = vmmc2;
IOVDD-supply = vio;
DVDD-supply = vio;
+
+ ai3x-micbias-vg = 2;
};
tsl2563: tsl2563@29 {
--
2.1.4
--
To unsubscribe from this list: send the line unsubscribe devicetree in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
