Re: [PATCH linux-next v9 0/3] mfd: flexcom: add a driver for Flexcom
On Wed, 23 Sep 2015, Nicolas Ferre wrote: > Le 20/09/2015 06:19, Lee Jones a écrit : > > Patch set description? > > Cyrille actually placed it as the v1 changelog below... I see it now, but that's not a very intuitive way of representing the set description. Please use the normal format with the description at the top. Normally all I care about is the description and the latest changes (although please keep in the previous changelogs, as they can also prove useful). > > Once Rob is satisfied, please re-submit this set with Nicolas' Acks > > I think that Rob was okay with the DT binding: "A few comments, but in > general looks fine." and it may not be important to tack Rob for > addition of his formal tag... > > Or maybe this message can act as a "ping" for Rob... I'm not asking for that, although it's never UNwanted. I'm asking for the discussion between the submitter and other interested parties to play out, then adapt and re-submit accordingly. I receive far too many submissions to keep track of all of the discussions. > > and I will re-review. > > We wait one or two days before Cyrille re-send the series. We are > looking forward to using this driver in Linux-next soon. > > >> ChangeLog > >> > >> v9: > >> - go back to v5 (use the new "atmel,flexcom-mode" DT property). > >> - fix the name of the spi node in the DT example: from spi@f8034400 to > >> spi@400 > >> - align the fields of the struct platform_driver atmel_flexcom_driver as > >> suggested by Lee Jones. > >> > >> v8: > >> - fix the name of the spi node in the DT example: from spi@f8034400 to > >> spi@2,0 > >> - use the return code of op_property_read_u32_index() instead of -EINVAL > >> to report error. > >> - add Acked-by from Nicolas Ferre > >> > >> v7: > >> - read the operating mode from the very first u32 of the reg property from > >> the first available child node (should be unique). > >> - update the DT bindings documentation accordingly. > >> > >> v6: > >> - select the operating mode according to the "compatible" DT property of > >> the first available child node (should be unique). > >> - remove the "atmel,flexcom-mode" DT property so the need of a header file > >> defining macros for the possible values of this deprecated property. > >> > >> v5: > >> - create a header file containing macros used by DT bindings > >> - use numeric constants instead of strings to select the Flexcom mode > >> - change the license to "GPL v2" > >> - update the DT binding documentation to make it more readable and add > >> references to USART, SPI and I2C DT binding documentations. remove the > >> useless label in the Example section. > >> - change the register prefix from FX_ to FLEX_ to match the Flexcom > >> programmer datasheet. > >> - rename some variables to make them more understandable. > >> > >> v4: > >> - check clk_prepare_enable() return code in atmel_flexcom_probe() > >> - add a commit message to the DT binding patch > >> > >> v3: > >> - remove MODULE_ALIAS() > >> - add Acked-by from Boris Brezillon and Alexandre Belloni > >> > >> v2: > >> - enhance the documentation of DT bindings and change the way the "ranges" > >> property is used. > >> - replace __raw_readl() and __raw_writel() by readl() and writel(). > >> - change the module license to "GPL" for v2 or later > >> - print the selected flexcom mode after the hardware version > >> > >> v1: > >> This series of patches a support to the Atmel Flexcom, a wrapper which > >> integrates an USART, a SPI controller and a TWI controller. Only one > >> peripheral can be used at a time. The active function is selected though > >> the Flexcom Mode Register. > >> > >> Cyrille Pitchen (3): > >> mfd: atmel-flexcom: create include file with macros used by DT > >> bindings > >> mfd: devicetree: add bindings for Atmel Flexcom > >> mfd: atmel-flexcom: add a driver for Atmel Flexible Serial > >> Communication Unit > >> > >> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 + > >> drivers/mfd/Kconfig| 11 +++ > >> drivers/mfd/Makefile | 1 + > >> drivers/mfd/atmel-flexcom.c| 104 > >> + > >> include/dt-bindings/mfd/atmel-flexcom.h| 16 > >> 5 files changed, 199 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt > >> create mode 100644 drivers/mfd/atmel-flexcom.c > >> create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h > >> > > > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH linux-next v9 0/3] mfd: flexcom: add a driver for Flexcom
Le 20/09/2015 06:19, Lee Jones a écrit : > Patch set description? Cyrille actually placed it as the v1 changelog below... > Once Rob is satisfied, please re-submit this set with Nicolas' Acks I think that Rob was okay with the DT binding: "A few comments, but in general looks fine." and it may not be important to tack Rob for addition of his formal tag... Or maybe this message can act as a "ping" for Rob... > and I will re-review. We wait one or two days before Cyrille re-send the series. We are looking forward to using this driver in Linux-next soon. Bye, >> ChangeLog >> >> v9: >> - go back to v5 (use the new "atmel,flexcom-mode" DT property). >> - fix the name of the spi node in the DT example: from spi@f8034400 to >> spi@400 >> - align the fields of the struct platform_driver atmel_flexcom_driver as >> suggested by Lee Jones. >> >> v8: >> - fix the name of the spi node in the DT example: from spi@f8034400 to >> spi@2,0 >> - use the return code of op_property_read_u32_index() instead of -EINVAL >> to report error. >> - add Acked-by from Nicolas Ferre >> >> v7: >> - read the operating mode from the very first u32 of the reg property from >> the first available child node (should be unique). >> - update the DT bindings documentation accordingly. >> >> v6: >> - select the operating mode according to the "compatible" DT property of >> the first available child node (should be unique). >> - remove the "atmel,flexcom-mode" DT property so the need of a header file >> defining macros for the possible values of this deprecated property. >> >> v5: >> - create a header file containing macros used by DT bindings >> - use numeric constants instead of strings to select the Flexcom mode >> - change the license to "GPL v2" >> - update the DT binding documentation to make it more readable and add >> references to USART, SPI and I2C DT binding documentations. remove the >> useless label in the Example section. >> - change the register prefix from FX_ to FLEX_ to match the Flexcom >> programmer datasheet. >> - rename some variables to make them more understandable. >> >> v4: >> - check clk_prepare_enable() return code in atmel_flexcom_probe() >> - add a commit message to the DT binding patch >> >> v3: >> - remove MODULE_ALIAS() >> - add Acked-by from Boris Brezillon and Alexandre Belloni >> >> v2: >> - enhance the documentation of DT bindings and change the way the "ranges" >> property is used. >> - replace __raw_readl() and __raw_writel() by readl() and writel(). >> - change the module license to "GPL" for v2 or later >> - print the selected flexcom mode after the hardware version >> >> v1: >> This series of patches a support to the Atmel Flexcom, a wrapper which >> integrates an USART, a SPI controller and a TWI controller. Only one >> peripheral can be used at a time. The active function is selected though >> the Flexcom Mode Register. >> >> Cyrille Pitchen (3): >> mfd: atmel-flexcom: create include file with macros used by DT >> bindings >> mfd: devicetree: add bindings for Atmel Flexcom >> mfd: atmel-flexcom: add a driver for Atmel Flexible Serial >> Communication Unit >> >> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 + >> drivers/mfd/Kconfig| 11 +++ >> drivers/mfd/Makefile | 1 + >> drivers/mfd/atmel-flexcom.c| 104 >> + >> include/dt-bindings/mfd/atmel-flexcom.h| 16 >> 5 files changed, 199 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt >> create mode 100644 drivers/mfd/atmel-flexcom.c >> create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h >> > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH linux-next v9 0/3] mfd: flexcom: add a driver for Flexcom
Patch set description? Once Rob is satisfied, please re-submit this set with Nicolas' Acks and I will re-review. > ChangeLog > > v9: > - go back to v5 (use the new "atmel,flexcom-mode" DT property). > - fix the name of the spi node in the DT example: from spi@f8034400 to > spi@400 > - align the fields of the struct platform_driver atmel_flexcom_driver as > suggested by Lee Jones. > > v8: > - fix the name of the spi node in the DT example: from spi@f8034400 to > spi@2,0 > - use the return code of op_property_read_u32_index() instead of -EINVAL > to report error. > - add Acked-by from Nicolas Ferre > > v7: > - read the operating mode from the very first u32 of the reg property from > the first available child node (should be unique). > - update the DT bindings documentation accordingly. > > v6: > - select the operating mode according to the "compatible" DT property of > the first available child node (should be unique). > - remove the "atmel,flexcom-mode" DT property so the need of a header file > defining macros for the possible values of this deprecated property. > > v5: > - create a header file containing macros used by DT bindings > - use numeric constants instead of strings to select the Flexcom mode > - change the license to "GPL v2" > - update the DT binding documentation to make it more readable and add > references to USART, SPI and I2C DT binding documentations. remove the > useless label in the Example section. > - change the register prefix from FX_ to FLEX_ to match the Flexcom > programmer datasheet. > - rename some variables to make them more understandable. > > v4: > - check clk_prepare_enable() return code in atmel_flexcom_probe() > - add a commit message to the DT binding patch > > v3: > - remove MODULE_ALIAS() > - add Acked-by from Boris Brezillon and Alexandre Belloni > > v2: > - enhance the documentation of DT bindings and change the way the "ranges" > property is used. > - replace __raw_readl() and __raw_writel() by readl() and writel(). > - change the module license to "GPL" for v2 or later > - print the selected flexcom mode after the hardware version > > v1: > This series of patches a support to the Atmel Flexcom, a wrapper which > integrates an USART, a SPI controller and a TWI controller. Only one > peripheral can be used at a time. The active function is selected though > the Flexcom Mode Register. > > Cyrille Pitchen (3): > mfd: atmel-flexcom: create include file with macros used by DT > bindings > mfd: devicetree: add bindings for Atmel Flexcom > mfd: atmel-flexcom: add a driver for Atmel Flexible Serial > Communication Unit > > .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 + > drivers/mfd/Kconfig| 11 +++ > drivers/mfd/Makefile | 1 + > drivers/mfd/atmel-flexcom.c| 104 > + > include/dt-bindings/mfd/atmel-flexcom.h| 16 > 5 files changed, 199 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt > create mode 100644 drivers/mfd/atmel-flexcom.c > create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH linux-next v9 0/3] mfd: flexcom: add a driver for Flexcom
On Tue, 08 Sep 2015, Cyrille Pitchen wrote: > Hi all, > > Le 01/09/2015 16:46, Cyrille Pitchen a écrit : > > ChangeLog > > > > v9: > > - go back to v5 (use the new "atmel,flexcom-mode" DT property). > > - fix the name of the spi node in the DT example: from spi@f8034400 to > > spi@400 > > - align the fields of the struct platform_driver atmel_flexcom_driver as > > suggested by Lee Jones. > > > [...] > > Are there any remaining blocking points for this series ? Yes. The merge window is open, so it's Maintainer sleepy time [0]. Will get back to reviewing next week probably. [0] AKA: Breath out and catch up with real-work for a bit. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH linux-next v9 0/3] mfd: flexcom: add a driver for Flexcom
Hi all, Le 01/09/2015 16:46, Cyrille Pitchen a écrit : > ChangeLog > > v9: > - go back to v5 (use the new "atmel,flexcom-mode" DT property). > - fix the name of the spi node in the DT example: from spi@f8034400 to > spi@400 > - align the fields of the struct platform_driver atmel_flexcom_driver as > suggested by Lee Jones. > [...] Are there any remaining blocking points for this series ? Best Regards, Cyrille -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH linux-next v9 0/3] mfd: flexcom: add a driver for Flexcom
ChangeLog v9: - go back to v5 (use the new "atmel,flexcom-mode" DT property). - fix the name of the spi node in the DT example: from spi@f8034400 to spi@400 - align the fields of the struct platform_driver atmel_flexcom_driver as suggested by Lee Jones. v8: - fix the name of the spi node in the DT example: from spi@f8034400 to spi@2,0 - use the return code of op_property_read_u32_index() instead of -EINVAL to report error. - add Acked-by from Nicolas Ferre v7: - read the operating mode from the very first u32 of the reg property from the first available child node (should be unique). - update the DT bindings documentation accordingly. v6: - select the operating mode according to the "compatible" DT property of the first available child node (should be unique). - remove the "atmel,flexcom-mode" DT property so the need of a header file defining macros for the possible values of this deprecated property. v5: - create a header file containing macros used by DT bindings - use numeric constants instead of strings to select the Flexcom mode - change the license to "GPL v2" - update the DT binding documentation to make it more readable and add references to USART, SPI and I2C DT binding documentations. remove the useless label in the Example section. - change the register prefix from FX_ to FLEX_ to match the Flexcom programmer datasheet. - rename some variables to make them more understandable. v4: - check clk_prepare_enable() return code in atmel_flexcom_probe() - add a commit message to the DT binding patch v3: - remove MODULE_ALIAS() - add Acked-by from Boris Brezillon and Alexandre Belloni v2: - enhance the documentation of DT bindings and change the way the "ranges" property is used. - replace __raw_readl() and __raw_writel() by readl() and writel(). - change the module license to "GPL" for v2 or later - print the selected flexcom mode after the hardware version v1: This series of patches a support to the Atmel Flexcom, a wrapper which integrates an USART, a SPI controller and a TWI controller. Only one peripheral can be used at a time. The active function is selected though the Flexcom Mode Register. Cyrille Pitchen (3): mfd: atmel-flexcom: create include file with macros used by DT bindings mfd: devicetree: add bindings for Atmel Flexcom mfd: atmel-flexcom: add a driver for Atmel Flexible Serial Communication Unit .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 + drivers/mfd/Kconfig| 11 +++ drivers/mfd/Makefile | 1 + drivers/mfd/atmel-flexcom.c| 104 + include/dt-bindings/mfd/atmel-flexcom.h| 16 5 files changed, 199 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt create mode 100644 drivers/mfd/atmel-flexcom.c create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h -- 1.8.2.2 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
