Re: [PATCH v1 2/7] ARM: dts: ifc6410: add real regulators for sdcc nodes.

2015-07-28 Thread Srinivas Kandagatla 



On 27/07/15 21:32, Andy Gross wrote:

On Mon, Jul 27, 2015 at 02:50:12PM +0100, Srinivas Kandagatla wrote:

snip


sdcc3: sdcc@1218 {
status = okay;
+   vmmc-supply = pm8921_l6;
pinctrl-names   = default;
pinctrl-0   = card_detect;
cd-gpios= tlmm_pinmux 26 
GPIO_ACTIVE_LOW;
@@ -187,6 +200,8 @@
/* WLAN */
sdcc4: sdcc@121c {
status = okay;
+   vmmc-supply = ext_3p3v;


Where is ext_3p3v defined?
Oops,  This is missing in this patch, I think re-ordering few other 
patches introduced this. I will send a these 3 patches as we discussed.


--srini



+   vqmmc-supply = pm8921_lvs1;



--
To unsubscribe from this list: send the line unsubscribe devicetree in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v1 2/7] ARM: dts: ifc6410: add real regulators for sdcc nodes.

2015-07-27 Thread Srinivas Kandagatla 
This patch adds real regulators for all the three sdcc nodes.

Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org
---
 arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 15 +++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts 
b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
index a7c939b..cdfcf02 100644
--- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
+++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
@@ -73,6 +73,12 @@
bias-pull-down;
};
 
+   pm8921_l5: l5 {
+   regulator-min-microvolt = 275;
+   regulator-max-microvolt = 300;
+   bias-pull-down;
+   };
+
pm8921_l6: l6 {
regulator-min-microvolt = 295;
regulator-max-microvolt = 295;
@@ -84,6 +90,10 @@
regulator-max-microvolt = 190;
bias-pull-down;
};
+
+   pm8921_lvs1: lvs1 {
+   bias-pull-down;
+   };
};
};
 
@@ -175,11 +185,14 @@
/* eMMC */
sdcc1: sdcc@1240 {
status = okay;
+   vmmc-supply = pm8921_l5;
+   vqmmc-supply = pm8921_s4;
};
 
/* External micro SD card */
sdcc3: sdcc@1218 {
status = okay;
+   vmmc-supply = pm8921_l6;
pinctrl-names   = default;
pinctrl-0   = card_detect;
cd-gpios= tlmm_pinmux 26 
GPIO_ACTIVE_LOW;
@@ -187,6 +200,8 @@
/* WLAN */
sdcc4: sdcc@121c {
status = okay;
+   vmmc-supply = ext_3p3v;
+   vqmmc-supply = pm8921_lvs1;
};
};
};
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe devicetree in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v1 2/7] ARM: dts: ifc6410: add real regulators for sdcc nodes.

2015-07-27 Thread Andy Gross 
On Mon, Jul 27, 2015 at 02:50:12PM +0100, Srinivas Kandagatla wrote:

snip

   sdcc3: sdcc@1218 {
   status = okay;
 + vmmc-supply = pm8921_l6;
   pinctrl-names   = default;
   pinctrl-0   = card_detect;
   cd-gpios= tlmm_pinmux 26 
 GPIO_ACTIVE_LOW;
 @@ -187,6 +200,8 @@
   /* WLAN */
   sdcc4: sdcc@121c {
   status = okay;
 + vmmc-supply = ext_3p3v;

Where is ext_3p3v defined?

 + vqmmc-supply = pm8921_lvs1;

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line unsubscribe devicetree in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html