Re: [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
Hi Paul,
On Wed, Jan 28, 2015 at 11:33:15PM +0100, Paul Bolle wrote:
> On Thu, 2015-01-08 at 23:46 +0100, Arnd Bergmann wrote:
> > Once there are no more review comments, please submit the first three
> > patches to a...@kernel.org, and send the other patches as separate
> > series to the respective maintainers for irqchip and clocksource.
>
> I found this message while looking into CONFIG_ARCH_DIGICOLOR. That
> Kconfig macro entered linux-next in next-20150128. But there's no
> Kconfig symbol ARCH_DIGICOLOR yet in linux-next.
Just for the record: base digicolor platform support is in the for-next branch
of arm-soc.git since today. I guess it should appear in linux-next tomorrow.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}ooO--U--Ooo{=
- bar...@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
Hi Baruch, On Thu, 2015-01-29 at 00:41 +0200, Baruch Siach wrote: > On Wed, Jan 28, 2015 at 11:33:15PM +0100, Paul Bolle wrote: > > On Thu, 2015-01-08 at 23:46 +0100, Arnd Bergmann wrote: > > > Once there are no more review comments, please submit the first three > > > patches to a...@kernel.org, and send the other patches as separate > > > series to the respective maintainers for irqchip and clocksource. > > > > I found this message while looking into CONFIG_ARCH_DIGICOLOR. That > > Kconfig macro entered linux-next in next-20150128. But there's no > > Kconfig symbol ARCH_DIGICOLOR yet in linux-next. > > Just for the record: base digicolor platform support is in the for-next > branch > of arm-soc.git since today. I guess it should appear in linux-next tomorrow. So I choose a less convincing patch series to discuss this. But that doesn't alter the general issue I raised. At least, I hope it doesn't. Thanks! Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
On Thu, 2015-01-08 at 23:46 +0100, Arnd Bergmann wrote: > Once there are no more review comments, please submit the first three > patches to a...@kernel.org, and send the other patches as separate > series to the respective maintainers for irqchip and clocksource. I found this message while looking into CONFIG_ARCH_DIGICOLOR. That Kconfig macro entered linux-next in next-20150128. But there's no Kconfig symbol ARCH_DIGICOLOR yet in linux-next. As you might be aware I try to check each linux-next release for Kconfig oddities. One of the oddities I tend _not_ to report are things like this. That is, SoC's, MFD's, or whatever, were specific drivers can get merged before the core functionality. In this case the irqchip driver got merged into linux-next while the core ARCH_DIGICOLOR code is still pending. And you happen to be involved with quite a bit of code in areas like that. Pre-merges like this appear unavoidable (ie, other workflows would be more trouble for the people involved). But what would be a good moment to still raise an issue like this? Just to make sure things don't fall through the cracks. As in: "this driver got merged into mainline but do you know you can't yet build it?". Perhaps with each -rc1? Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
On Sunday 11 January 2015 13:33:27 Baruch Siach wrote: > > Once there are no more review comments, please submit the first three > > patches to a...@kernel.org, and send the other patches as separate > > series to the respective maintainers for irqchip and clocksource. > > What about the last patch in this series (ARM: devicetree: document supported > Conexant Digicolor SoC)? What tree should it go through. That can go along with the first three patches for the platform. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
Hi Arnd,
On Thu, Jan 08, 2015 at 11:46:46PM +0100, Arnd Bergmann wrote:
> On Thursday 08 January 2015 21:39:56 Baruch Siach wrote:
> > This series adds initial support for the Conexant CX92755 SoC. The CX92755
> > is
> > one of the Digicolor series of SoCs, all sharing many of the same
> > peripherals.
> > The code was tested on the CX92755 evaluation kit, AKA Equinox.
> >
> > Uses attempting to try this code will most likely also want the UART/console
> > driver available from https://patchwork.kernel.org/patch/5515861/.
>
> Looks great overall now.
>
> I have just two more comments in one patch, and one general request:
>
> Please add a patch description for every patch. The text above would
> be a good start for the first patch, but it would be lost in the git
> history if it's only in the cover letter.
>
> other than that, feel free to add my
>
> Acked-by: Arnd Bergmann
Thanks.
> Once there are no more review comments, please submit the first three
> patches to a...@kernel.org, and send the other patches as separate
> series to the respective maintainers for irqchip and clocksource.
What about the last patch in this series (ARM: devicetree: document supported
Conexant Digicolor SoC)? What tree should it go through.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}ooO--U--Ooo{=
- bar...@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
On Thursday 08 January 2015 21:39:56 Baruch Siach wrote: > This series adds initial support for the Conexant CX92755 SoC. The CX92755 is > one of the Digicolor series of SoCs, all sharing many of the same peripherals. > The code was tested on the CX92755 evaluation kit, AKA Equinox. > > Uses attempting to try this code will most likely also want the UART/console > driver available from https://patchwork.kernel.org/patch/5515861/. Looks great overall now. I have just two more comments in one patch, and one general request: Please add a patch description for every patch. The text above would be a good start for the first patch, but it would be lost in the git history if it's only in the cover letter. other than that, feel free to add my Acked-by: Arnd Bergmann Once there are no more review comments, please submit the first three patches to a...@kernel.org, and send the other patches as separate series to the respective maintainers for irqchip and clocksource. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
This series adds initial support for the Conexant CX92755 SoC. The CX92755 is one of the Digicolor series of SoCs, all sharing many of the same peripherals. The code was tested on the CX92755 evaluation kit, AKA Equinox. Uses attempting to try this code will most likely also want the UART/console driver available from https://patchwork.kernel.org/patch/5515861/. v2: * Remove .map_io assignment, debug_ll is enabled by default (Arnd Bergmann) * Migrate the irq driver to generic irq chip, simplifying the code somewhat (Arnd Bergmann) * Change the timer dt binding, so that the 'reg' property points to the first "Agent Communication" register. This should improve the chance of reusing this binding for other SoCs in this series. * Add the CONTROL() and COUNT() macros to the timer driver to make the code clearer. * Move arch/arm Kconfig changes from the clocksource driver patch to the base arch support patch to reduce dependency between them v1: http://thread.gmane.org/gmane.linux.kernel/1855027 Baruch Siach (8): ARM: initial support for Conexant Digicolor CX92755 SoC ARM: digicolor: add low level debug support ARM: digicolor: add minimal device tree description irqchip: devicetree: document Conexant Digicolor irq binding irqchip: Conexant CX92755 interrupts controller driver clocksource: devicetree: document Conexant Digicolor timer binding clocksource: driver for Conexant Digicolor SoC timer ARM: devicetree: document supported Conexant Digicolor SoC .../devicetree/bindings/arm/digicolor.txt | 6 + .../bindings/interrupt-controller/digicolor-ic.txt | 20 +++ .../devicetree/bindings/timer/digicolor-timer.txt | 18 +++ arch/arm/Kconfig | 2 + arch/arm/Kconfig.debug | 12 +- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/conexant_equinox.dts | 67 + arch/arm/boot/dts/cx92755.dtsi | 103 + arch/arm/include/debug/digicolor.S | 35 + arch/arm/mach-digicolor/Kconfig| 5 + arch/arm/mach-digicolor/Makefile | 1 + arch/arm/mach-digicolor/digicolor.c| 18 +++ drivers/clocksource/Makefile | 1 + drivers/clocksource/timer-digicolor.c | 164 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-digicolor.c| 112 ++ 16 files changed, 564 insertions(+), 2 deletions(-) create mode 100644 Documentation/devicetree/bindings/arm/digicolor.txt create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt create mode 100644 Documentation/devicetree/bindings/timer/digicolor-timer.txt create mode 100644 arch/arm/boot/dts/conexant_equinox.dts create mode 100644 arch/arm/boot/dts/cx92755.dtsi create mode 100644 arch/arm/include/debug/digicolor.S create mode 100644 arch/arm/mach-digicolor/Kconfig create mode 100644 arch/arm/mach-digicolor/Makefile create mode 100644 arch/arm/mach-digicolor/digicolor.c create mode 100644 drivers/clocksource/timer-digicolor.c create mode 100644 drivers/irqchip/irq-digicolor.c -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
