Re: [PATCH v2 5/5] [media] c8sectpfe: Update DT binding doc with some minor fixes

2015-08-28 Thread Peter Griffin 
Hi Lee,

On Fri, 28 Aug 2015, Lee Jones wrote:

> On Thu, 27 Aug 2015, Peter Griffin wrote:
> 
> > Signed-off-by: Peter Griffin 
> > ---
> >  .../devicetree/bindings/media/stih407-c8sectpfe.txt  | 16 
> > +++-
> >  1 file changed, 7 insertions(+), 9 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt 
> > b/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
> > index e70d840..5d6438c 100644
> > --- a/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
> > +++ b/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
> > @@ -55,21 +55,20 @@ Example:
> > status = "okay";
> > reg = <0x08a2 0x1>, <0x08a0 0x4000>;
> > reg-names = "stfe", "stfe-ram";
> > -   interrupts = <0 34 0>, <0 35 0>;
> > +   interrupts = ,  > IRQ_TYPE_NONE>;
> > interrupt-names = "stfe-error-irq", "stfe-idle-irq";
> > -
> > -   pinctrl-names   = "tsin0-serial", "tsin0-parallel", 
> > "tsin3-serial",
> > -   "tsin4-serial", "tsin5-serial";
> > -
> > +   pinctrl-names   = "tsin0-serial",
> > + "tsin0-parallel",
> > + "tsin3-serial",
> > + "tsin4-serial",
> > + "tsin5-serial";
> > pinctrl-0   = <&pinctrl_tsin0_serial>;
> > pinctrl-1   = <&pinctrl_tsin0_parallel>;
> > pinctrl-2   = <&pinctrl_tsin3_serial>;
> > pinctrl-3   = <&pinctrl_tsin4_serial_alt3>;
> > pinctrl-4   = <&pinctrl_tsin5_serial_alt1>;
> > -
> > clocks = <&clk_s_c0_flexgen CLK_PROC_STFE>;
> > -   clock-names = "stfe";
> > -
> > +   clock-names = "c8sectpfe";
> 
> Are you sure you even need this property?  I'm thinking that *-names
> properties are *usually* only required if there are more than one in a
> single property.

Yes that is true, but for tsout and merged input stream
functionality the driver will require additional clocks. As I
mentioned in a previous email I hope to add support for this in the
near future.

> 
> > /* tsin0 is TSA on NIMA */
> > tsin0: port@0 {
> > tsin-num= <0>;
> > @@ -78,7 +77,6 @@ Example:
> > reset-gpios = <&pio15 4 GPIO_ACTIVE_HIGH>;
> > dvb-card= ;
> > };
> > -
> 
> My personal preference is to have a '\n' between nodes.

Yes mine as well, I removed it due to your earlier comment about "superflous 
\n".
I will add it back in again in v3.

> 
> > tsin3: port@3 {
> > tsin-num= <3>;
> > serial-not-parallel;
> 
> But these comments are pretty trivial, so agree or not, or fix-up or
> not, it's that big of a deal.

I agree all trivial, but will fixup in v3.
> 
> Either way,
>   Acked-by: Lee Jones 

Thanks & regards,

Peter.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 5/5] [media] c8sectpfe: Update DT binding doc with some minor fixes

2015-08-27 Thread Lee Jones 
On Thu, 27 Aug 2015, Peter Griffin wrote:

> Signed-off-by: Peter Griffin 
> ---
>  .../devicetree/bindings/media/stih407-c8sectpfe.txt  | 16 
> +++-
>  1 file changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt 
> b/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
> index e70d840..5d6438c 100644
> --- a/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
> +++ b/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
> @@ -55,21 +55,20 @@ Example:
>   status = "okay";
>   reg = <0x08a2 0x1>, <0x08a0 0x4000>;
>   reg-names = "stfe", "stfe-ram";
> - interrupts = <0 34 0>, <0 35 0>;
> + interrupts = ,  IRQ_TYPE_NONE>;
>   interrupt-names = "stfe-error-irq", "stfe-idle-irq";
> -
> - pinctrl-names   = "tsin0-serial", "tsin0-parallel", 
> "tsin3-serial",
> - "tsin4-serial", "tsin5-serial";
> -
> + pinctrl-names   = "tsin0-serial",
> +   "tsin0-parallel",
> +   "tsin3-serial",
> +   "tsin4-serial",
> +   "tsin5-serial";
>   pinctrl-0   = <&pinctrl_tsin0_serial>;
>   pinctrl-1   = <&pinctrl_tsin0_parallel>;
>   pinctrl-2   = <&pinctrl_tsin3_serial>;
>   pinctrl-3   = <&pinctrl_tsin4_serial_alt3>;
>   pinctrl-4   = <&pinctrl_tsin5_serial_alt1>;
> -
>   clocks = <&clk_s_c0_flexgen CLK_PROC_STFE>;
> - clock-names = "stfe";
> -
> + clock-names = "c8sectpfe";

Are you sure you even need this property?  I'm thinking that *-names
properties are *usually* only required if there are more than one in a
single property.

>   /* tsin0 is TSA on NIMA */
>   tsin0: port@0 {
>   tsin-num= <0>;
> @@ -78,7 +77,6 @@ Example:
>   reset-gpios = <&pio15 4 GPIO_ACTIVE_HIGH>;
>   dvb-card= ;
>   };
> -

My personal preference is to have a '\n' between nodes.

>   tsin3: port@3 {
>   tsin-num= <3>;
>   serial-not-parallel;

But these comments are pretty trivial, so agree or not, or fix-up or
not, it's that big of a deal.

Either way,
  Acked-by: Lee Jones 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 5/5] [media] c8sectpfe: Update DT binding doc with some minor fixes

2015-08-27 Thread Peter Griffin 
Signed-off-by: Peter Griffin 
---
 .../devicetree/bindings/media/stih407-c8sectpfe.txt  | 16 +++-
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt 
b/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
index e70d840..5d6438c 100644
--- a/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
+++ b/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
@@ -55,21 +55,20 @@ Example:
status = "okay";
reg = <0x08a2 0x1>, <0x08a0 0x4000>;
reg-names = "stfe", "stfe-ram";
-   interrupts = <0 34 0>, <0 35 0>;
+   interrupts = , ;
interrupt-names = "stfe-error-irq", "stfe-idle-irq";
-
-   pinctrl-names   = "tsin0-serial", "tsin0-parallel", 
"tsin3-serial",
-   "tsin4-serial", "tsin5-serial";
-
+   pinctrl-names   = "tsin0-serial",
+ "tsin0-parallel",
+ "tsin3-serial",
+ "tsin4-serial",
+ "tsin5-serial";
pinctrl-0   = <&pinctrl_tsin0_serial>;
pinctrl-1   = <&pinctrl_tsin0_parallel>;
pinctrl-2   = <&pinctrl_tsin3_serial>;
pinctrl-3   = <&pinctrl_tsin4_serial_alt3>;
pinctrl-4   = <&pinctrl_tsin5_serial_alt1>;
-
clocks = <&clk_s_c0_flexgen CLK_PROC_STFE>;
-   clock-names = "stfe";
-
+   clock-names = "c8sectpfe";
/* tsin0 is TSA on NIMA */
tsin0: port@0 {
tsin-num= <0>;
@@ -78,7 +77,6 @@ Example:
reset-gpios = <&pio15 4 GPIO_ACTIVE_HIGH>;
dvb-card= ;
};
-
tsin3: port@3 {
tsin-num= <3>;
serial-not-parallel;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html