Re: [PATCH v3 1/3] ARM: dts: qcom: Add binding for the qcom coincell charger
On Wed, Jul 29, 2015 at 11:12:30AM -0700, Tim Bird wrote: > Greg, > > At this point I've got Reviewed-by from Rob on the binding and dts bits, > and Reviewed-by from Andy Gross on the complete patch series (v3). > > I believe I've addressed all issues raised. Can you please add this > (v3) to drivers/misc? > > Let me know if you want me to re-send anything. Nope, I can take it from here, thanks. greg k-h -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 1/3] ARM: dts: qcom: Add binding for the qcom coincell charger
Greg,
At this point I've got Reviewed-by from Rob on the binding and dts bits,
and Reviewed-by from Andy Gross on the complete patch series (v3).
I believe I've addressed all issues raised. Can you please add this
(v3) to drivers/misc?
Let me know if you want me to re-send anything.
Thanks very much.
-- Tim
On 07/17/2015 08:42 AM, Rob Herring wrote:
> On Thu, Jul 16, 2015 at 6:55 PM, Tim Bird wrote:
>> This binding is used to configure the driver for the coincell charger
>> found in Qualcomm PMICs.
>>
>> Signed-off-by: Tim Bird
>
> Reviewed-by: Rob Herring
>
>> ---
>>
>> Changes in v3:
>> - change charge-enable property to charger-disable
>> Changes in v2:
>> - remove 'qcom,' from example node name
>> - Added reference to parent node pm8941@0 and binding doc for it
>>
>> .../bindings/power/qcom,coincell-charger.txt | 48
>> ++
>> 1 file changed, 48 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/power/qcom,coincell-charger.txt
>>
>> diff --git
>> a/Documentation/devicetree/bindings/power/qcom,coincell-charger.txt
>> b/Documentation/devicetree/bindings/power/qcom,coincell-charger.txt
>> new file mode 100644
>> index 000..0e6d875
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/power/qcom,coincell-charger.txt
>> @@ -0,0 +1,48 @@
>> +Qualcomm Coincell Charger:
>> +
>> +The hardware block controls charging for a coincell or capacitor that is
>> +used to provide power backup for certain features of the power management
>> +IC (PMIC)
>> +
>> +- compatible:
>> + Usage: required
>> + Value type:
>> + Definition: must be: "qcom,pm8941-coincell"
>> +
>> +- reg:
>> + Usage: required
>> + Value type:
>> + Definition: base address of the coincell charger registers
>> +
>> +- qcom,rset-ohms:
>> + Usage: required
>> + Value type:
>> + Definition: resistance (in ohms) for current-limiting resistor
>> + must be one of: 800, 1200, 1700, 2100
>> +
>> +- qcom,vset-millivolts:
>> + Usage: required
>> + Value type:
>> + Definition: voltage (in millivolts) to apply for charging
>> + must be one of: 2500, 3000, 3100, 3200
>> +
>> +- qcom,charger-disable:
>> + Usage: optional
>> + Value type:
>> + Definition: definining this property disables charging
>> +
>> +This charger is a sub-node of one of the 8941 PMIC blocks, and is specified
>> +as a child node in DTS of that node. See ../mfd/qcom,spmi-pmic.txt and
>> +../mfd/qcom-pm8xxx.txt
>> +
>> +Example:
>> +
>> + pm8941@0 {
>> + coincell@2800 {
>> + compatible = "qcom,pm8941-coincell";
>> + reg = <0x2800>;
>> +
>> + qcom,rset-ohms = <2100>;
>> + qcom,vset-millivolts = <3000>;
>> + };
>> + };
>> --
>> 1.8.2.2
>>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 1/3] ARM: dts: qcom: Add binding for the qcom coincell charger
On Thu, Jul 16, 2015 at 04:55:31PM -0700, Tim Bird wrote: > This binding is used to configure the driver for the coincell charger > found in Qualcomm PMICs. > > Signed-off-by: Tim Bird > --- Looks reasonable. Reviewed-by: Andy Gross -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 1/3] ARM: dts: qcom: Add binding for the qcom coincell charger
On Thu, Jul 16, 2015 at 6:55 PM, Tim Bird wrote:
> This binding is used to configure the driver for the coincell charger
> found in Qualcomm PMICs.
>
> Signed-off-by: Tim Bird
Reviewed-by: Rob Herring
> ---
>
> Changes in v3:
> - change charge-enable property to charger-disable
> Changes in v2:
> - remove 'qcom,' from example node name
> - Added reference to parent node pm8941@0 and binding doc for it
>
> .../bindings/power/qcom,coincell-charger.txt | 48
> ++
> 1 file changed, 48 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/power/qcom,coincell-charger.txt
>
> diff --git
> a/Documentation/devicetree/bindings/power/qcom,coincell-charger.txt
> b/Documentation/devicetree/bindings/power/qcom,coincell-charger.txt
> new file mode 100644
> index 000..0e6d875
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/qcom,coincell-charger.txt
> @@ -0,0 +1,48 @@
> +Qualcomm Coincell Charger:
> +
> +The hardware block controls charging for a coincell or capacitor that is
> +used to provide power backup for certain features of the power management
> +IC (PMIC)
> +
> +- compatible:
> + Usage: required
> + Value type:
> + Definition: must be: "qcom,pm8941-coincell"
> +
> +- reg:
> + Usage: required
> + Value type:
> + Definition: base address of the coincell charger registers
> +
> +- qcom,rset-ohms:
> + Usage: required
> + Value type:
> + Definition: resistance (in ohms) for current-limiting resistor
> + must be one of: 800, 1200, 1700, 2100
> +
> +- qcom,vset-millivolts:
> + Usage: required
> + Value type:
> + Definition: voltage (in millivolts) to apply for charging
> + must be one of: 2500, 3000, 3100, 3200
> +
> +- qcom,charger-disable:
> + Usage: optional
> + Value type:
> + Definition: definining this property disables charging
> +
> +This charger is a sub-node of one of the 8941 PMIC blocks, and is specified
> +as a child node in DTS of that node. See ../mfd/qcom,spmi-pmic.txt and
> +../mfd/qcom-pm8xxx.txt
> +
> +Example:
> +
> + pm8941@0 {
> + coincell@2800 {
> + compatible = "qcom,pm8941-coincell";
> + reg = <0x2800>;
> +
> + qcom,rset-ohms = <2100>;
> + qcom,vset-millivolts = <3000>;
> + };
> + };
> --
> 1.8.2.2
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v3 1/3] ARM: dts: qcom: Add binding for the qcom coincell charger
This binding is used to configure the driver for the coincell charger
found in Qualcomm PMICs.
Signed-off-by: Tim Bird
---
Changes in v3:
- change charge-enable property to charger-disable
Changes in v2:
- remove 'qcom,' from example node name
- Added reference to parent node pm8941@0 and binding doc for it
.../bindings/power/qcom,coincell-charger.txt | 48 ++
1 file changed, 48 insertions(+)
create mode 100644
Documentation/devicetree/bindings/power/qcom,coincell-charger.txt
diff --git a/Documentation/devicetree/bindings/power/qcom,coincell-charger.txt
b/Documentation/devicetree/bindings/power/qcom,coincell-charger.txt
new file mode 100644
index 000..0e6d875
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/qcom,coincell-charger.txt
@@ -0,0 +1,48 @@
+Qualcomm Coincell Charger:
+
+The hardware block controls charging for a coincell or capacitor that is
+used to provide power backup for certain features of the power management
+IC (PMIC)
+
+- compatible:
+ Usage: required
+ Value type:
+ Definition: must be: "qcom,pm8941-coincell"
+
+- reg:
+ Usage: required
+ Value type:
+ Definition: base address of the coincell charger registers
+
+- qcom,rset-ohms:
+ Usage: required
+ Value type:
+ Definition: resistance (in ohms) for current-limiting resistor
+ must be one of: 800, 1200, 1700, 2100
+
+- qcom,vset-millivolts:
+ Usage: required
+ Value type:
+ Definition: voltage (in millivolts) to apply for charging
+ must be one of: 2500, 3000, 3100, 3200
+
+- qcom,charger-disable:
+ Usage: optional
+ Value type:
+ Definition: definining this property disables charging
+
+This charger is a sub-node of one of the 8941 PMIC blocks, and is specified
+as a child node in DTS of that node. See ../mfd/qcom,spmi-pmic.txt and
+../mfd/qcom-pm8xxx.txt
+
+Example:
+
+ pm8941@0 {
+ coincell@2800 {
+ compatible = "qcom,pm8941-coincell";
+ reg = <0x2800>;
+
+ qcom,rset-ohms = <2100>;
+ qcom,vset-millivolts = <3000>;
+ };
+ };
--
1.8.2.2
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
