Re: [PATCH v3 3/3] mtd: add SMEM parser for QCOM platforms

2015-08-18 Thread Bjorn Andersson
On Mon 17 Aug 16:47 PDT 2015, Mathieu Olivari wrote:

> On QCOM platforms using MTD devices storage (such as IPQ806x), SMEM is
> used to store partition layout. This new parser can now be used to read
> SMEM and use it to register an MTD layout according to its content.

Looks good, but the license string should be "GPL v2" (lower case v).
Just as a hint...I made checkpatch warn you about that a while back ;)

The rest is

Acked-by: Bjorn Andersson 

[..]

> +
> +MODULE_LICENSE("GPL V2");

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v3 3/3] mtd: add SMEM parser for QCOM platforms

2015-08-17 Thread Mathieu Olivari
On QCOM platforms using MTD devices storage (such as IPQ806x), SMEM is
used to store partition layout. This new parser can now be used to read
SMEM and use it to register an MTD layout according to its content.

Signed-off-by: Mathieu Olivari 
---

Notes:
v2:
*Release the SPI device reference after looking it up (put_device())
*Represent SMEM data as __le32 rather than u32
*Move new DT nodes in their proper respective location
*Address readability concerns in MTD parser

v3:
*Redefine SMEM functions prototypes for better readability
*Duplicate MTD name instead of pointing to SMEM string location in case
 mtd layer tries to free it
*Rework some of the comments

 drivers/mtd/Kconfig  |   7 ++
 drivers/mtd/Makefile |   1 +
 drivers/mtd/qcom_smem_part.c | 246 +++
 3 files changed, 254 insertions(+)
 create mode 100644 drivers/mtd/qcom_smem_part.c

diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
index a03ad29..debc887 100644
--- a/drivers/mtd/Kconfig
+++ b/drivers/mtd/Kconfig
@@ -155,6 +155,13 @@ config MTD_BCM47XX_PARTS
  This provides partitions parser for devices based on BCM47xx
  boards.
 
+config MTD_QCOM_SMEM_PARTS
+   tristate "QCOM SMEM partitioning support"
+   depends on QCOM_SMEM
+   help
+ This provides partitions parser for QCOM devices using SMEM
+ such as IPQ806x.
+
 comment "User Modules And Translation Layers"
 
 #
diff --git a/drivers/mtd/Makefile b/drivers/mtd/Makefile
index 99bb9a1..b3c7de4 100644
--- a/drivers/mtd/Makefile
+++ b/drivers/mtd/Makefile
@@ -13,6 +13,7 @@ obj-$(CONFIG_MTD_AFS_PARTS)   += afs.o
 obj-$(CONFIG_MTD_AR7_PARTS)+= ar7part.o
 obj-$(CONFIG_MTD_BCM63XX_PARTS)+= bcm63xxpart.o
 obj-$(CONFIG_MTD_BCM47XX_PARTS)+= bcm47xxpart.o
+obj-$(CONFIG_MTD_QCOM_SMEM_PARTS) += qcom_smem_part.o
 
 # 'Users' - code which presents functionality to userspace.
 obj-$(CONFIG_MTD_BLKDEVS)  += mtd_blkdevs.o
diff --git a/drivers/mtd/qcom_smem_part.c b/drivers/mtd/qcom_smem_part.c
new file mode 100644
index 000..cb7ea9a
--- /dev/null
+++ b/drivers/mtd/qcom_smem_part.c
@@ -0,0 +1,246 @@
+/*
+ * Copyright (c) 2015, The Linux Foundation. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 and
+ * only version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+
+/* Processor/host identifier for the application processor */
+#define QCOM_SMEM_GLOBAL   0
+
+/* SMEM items index */
+#define SMEM_AARM_PARTITION_TABLE  9
+#define SMEM_BOOT_FLASH_TYPE   421
+#define SMEM_BOOT_FLASH_BLOCK_SIZE 424
+
+/* SMEM Flash types */
+#define SMEM_FLASH_NAND2
+#define SMEM_FLASH_SPI 6
+
+#define SMEM_PART_NAME_SZ  16
+#define SMEM_PARTS_MAX 32
+
+struct smem_partition {
+   char name[SMEM_PART_NAME_SZ];
+   __le32 start;
+   __le32 size;
+   __le32 attr;
+};
+
+struct smem_partition_table {
+   u8 magic[8];
+   __le32 version;
+   __le32 len;
+   struct smem_partition parts[SMEM_PARTS_MAX];
+};
+
+/* SMEM Magic values in partition table */
+static const u8 SMEM_PTABLE_MAGIC[] = {
+   0xaa, 0x73, 0xee, 0x55,
+   0xdb, 0xbd, 0x5e, 0xe3,
+};
+
+static int qcom_smem_get_flash_blksz(void)
+{
+   int ret;
+   size_t size;
+   u64 *smem_blksz;
+
+   ret = qcom_smem_get(QCOM_SMEM_GLOBAL, SMEM_BOOT_FLASH_BLOCK_SIZE,
+   (void **) &smem_blksz, &size);
+
+   if (ret < 0) {
+   pr_err("Unable to read flash blksz from SMEM\n");
+   return -ENOENT;
+   }
+
+   if (size != sizeof(*smem_blksz)) {
+   pr_err("Invalid flash blksz size in SMEM\n");
+   return -EINVAL;
+   }
+
+   /* Sanity check block size value before casting it */
+   if (*smem_blksz > INT_MAX) {
+   pr_err("Invalid flash block size in SMEM\n");
+   return -EINVAL;
+   }
+
+   return (int) *smem_blksz;
+}
+
+static int qcom_smem_get_flash_type(void)
+{
+   int ret;
+   size_t size;
+   u64 *smem_flash_type;
+
+   ret = qcom_smem_get(QCOM_SMEM_GLOBAL, SMEM_BOOT_FLASH_TYPE,
+   (void **) &smem_flash_type, &size);
+
+   if (ret < 0) {
+   pr_err("Unable to read flash type from SMEM\n");
+   return -ENOENT;
+   }
+
+   if (size != sizeof(*smem_flash_type)) {
+   pr_err("Invalid flas