Re: [PATCH v5 3/5] iio: common: ssp_sensors: Add sensorhub iio commons

2015-01-29 Thread Jonathan Cameron
On 28/01/15 14:05, Karol Wrona wrote:
> This patch adds common library for sensorhub iio drivers.
> 
> Signed-off-by: Karol Wrona 
> Acked-by: Kyungmin Park 
Applied with the make file line brought forward from patch 1.
Pushed out as testing for the autobuilders to play.

> ---
>  drivers/iio/common/ssp_sensors/ssp_iio.c|  107 
> +++
>  drivers/iio/common/ssp_sensors/ssp_iio_sensor.h |   70 +++
>  2 files changed, 177 insertions(+)
>  create mode 100644 drivers/iio/common/ssp_sensors/ssp_iio.c
>  create mode 100644 drivers/iio/common/ssp_sensors/ssp_iio_sensor.h
> 
> diff --git a/drivers/iio/common/ssp_sensors/ssp_iio.c 
> b/drivers/iio/common/ssp_sensors/ssp_iio.c
> new file mode 100644
> index 000..a3ae165
> --- /dev/null
> +++ b/drivers/iio/common/ssp_sensors/ssp_iio.c
> @@ -0,0 +1,107 @@
> +/*
> + *  Copyright (C) 2014, Samsung Electronics Co. Ltd. All Rights Reserved.
> + *
> + *  This program is free software; you can redistribute it and/or modify
> + *  it under the terms of the GNU General Public License as published by
> + *  the Free Software Foundation; either version 2 of the License, or
> + *  (at your option) any later version.
> + *
> + *  This program is distributed in the hope that it will be useful,
> + *  but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *  GNU General Public License for more details.
> + *
> + */
> +
> +#include 
> +#include 
> +#include 
> +#include 
> +#include "ssp_iio_sensor.h"
> +
> +/**
> + * ssp_common_buffer_postenable() - generic postenable callback for ssp 
> buffer
> + *
> + * @indio_dev:   iio device
> + *
> + * Returns 0 or negative value in case of error
> + */
> +int ssp_common_buffer_postenable(struct iio_dev *indio_dev)
> +{
> + struct ssp_sensor_data *spd = iio_priv(indio_dev);
> + struct ssp_data *data = dev_get_drvdata(indio_dev->dev.parent->parent);
> +
> + /* the allocation is made in post because scan size is known in this
> +  * moment
> +  * */
> + spd->buffer = kmalloc(indio_dev->scan_bytes, GFP_KERNEL | GFP_DMA);
> + if (!spd->buffer)
> + return -ENOMEM;
> +
> + return ssp_enable_sensor(data, spd->type,
> +  ssp_get_sensor_delay(data, spd->type));
> +}
> +EXPORT_SYMBOL(ssp_common_buffer_postenable);
> +
> +/**
> + * ssp_common_buffer_postdisable() - generic postdisable callback for ssp 
> buffer
> + *
> + * @indio_dev:   iio device
> + *
> + * Returns 0 or negative value in case of error
> + */
> +int ssp_common_buffer_postdisable(struct iio_dev *indio_dev)
> +{
> + int ret;
> + struct ssp_sensor_data *spd = iio_priv(indio_dev);
> + struct ssp_data *data = dev_get_drvdata(indio_dev->dev.parent->parent);
> +
> + ret = ssp_disable_sensor(data, spd->type);
> + if (ret < 0)
> + return ret;
> +
> + kfree(spd->buffer);
> +
> + return ret;
> +}
> +EXPORT_SYMBOL(ssp_common_buffer_postdisable);
> +
> +/**
> + * ssp_common_process_data() - Common process data callback for ssp sensors
> + *
> + * @indio_dev:   iio device
> + * @buf: source buffer
> + * @len: sensor data length
> + * @timestamp:   system timestamp
> + *
> + * Returns 0 or negative value in case of error
> + */
> +int ssp_common_process_data(struct iio_dev *indio_dev, void *buf,
> + unsigned int len, int64_t timestamp)
> +{
> + __le32 time;
> + int64_t calculated_time;
> + struct ssp_sensor_data *spd = iio_priv(indio_dev);
> +
> + if (indio_dev->scan_bytes == 0)
> + return 0;
> +
> + /*
> +  * it always sends full set of samples, remember about available masks
> +  */
> + memcpy(spd->buffer, buf, len);
> +
> + if (indio_dev->scan_timestamp) {
> + memcpy(&time, &((char *)buf)[len], SSP_TIME_SIZE);
> + calculated_time =
> + timestamp + (int64_t)le32_to_cpu(time) * 100;
> + }
> +
> + return iio_push_to_buffers_with_timestamp(indio_dev, spd->buffer,
> +   calculated_time);
> +}
> +EXPORT_SYMBOL(ssp_common_process_data);
> +
> +MODULE_AUTHOR("Karol Wrona ");
> +MODULE_DESCRIPTION("Samsung sensorhub commons");
> +MODULE_LICENSE("GPL");
> diff --git a/drivers/iio/common/ssp_sensors/ssp_iio_sensor.h 
> b/drivers/iio/common/ssp_sensors/ssp_iio_sensor.h
> new file mode 100644
> index 000..dda267c
> --- /dev/null
> +++ b/drivers/iio/common/ssp_sensors/ssp_iio_sensor.h
> @@ -0,0 +1,70 @@
> +#ifndef __SSP_IIO_SENSOR_H__
> +#define __SSP_IIO_SENSOR_H__
> +
> +#define SSP_CHANNEL_AG(_type, _mod, _index) \
> +{ \
> + .type = _type,\
> + .modified = 1,\
> + .channel2 = _mod,\
> + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SAMP_FREQ),\
> + .scan_index = _index,\
> 

[PATCH v5 3/5] iio: common: ssp_sensors: Add sensorhub iio commons

2015-01-28 Thread Karol Wrona
This patch adds common library for sensorhub iio drivers.

Signed-off-by: Karol Wrona 
Acked-by: Kyungmin Park 
---
 drivers/iio/common/ssp_sensors/ssp_iio.c|  107 +++
 drivers/iio/common/ssp_sensors/ssp_iio_sensor.h |   70 +++
 2 files changed, 177 insertions(+)
 create mode 100644 drivers/iio/common/ssp_sensors/ssp_iio.c
 create mode 100644 drivers/iio/common/ssp_sensors/ssp_iio_sensor.h

diff --git a/drivers/iio/common/ssp_sensors/ssp_iio.c 
b/drivers/iio/common/ssp_sensors/ssp_iio.c
new file mode 100644
index 000..a3ae165
--- /dev/null
+++ b/drivers/iio/common/ssp_sensors/ssp_iio.c
@@ -0,0 +1,107 @@
+/*
+ *  Copyright (C) 2014, Samsung Electronics Co. Ltd. All Rights Reserved.
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation; either version 2 of the License, or
+ *  (at your option) any later version.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include "ssp_iio_sensor.h"
+
+/**
+ * ssp_common_buffer_postenable() - generic postenable callback for ssp buffer
+ *
+ * @indio_dev: iio device
+ *
+ * Returns 0 or negative value in case of error
+ */
+int ssp_common_buffer_postenable(struct iio_dev *indio_dev)
+{
+   struct ssp_sensor_data *spd = iio_priv(indio_dev);
+   struct ssp_data *data = dev_get_drvdata(indio_dev->dev.parent->parent);
+
+   /* the allocation is made in post because scan size is known in this
+* moment
+* */
+   spd->buffer = kmalloc(indio_dev->scan_bytes, GFP_KERNEL | GFP_DMA);
+   if (!spd->buffer)
+   return -ENOMEM;
+
+   return ssp_enable_sensor(data, spd->type,
+ssp_get_sensor_delay(data, spd->type));
+}
+EXPORT_SYMBOL(ssp_common_buffer_postenable);
+
+/**
+ * ssp_common_buffer_postdisable() - generic postdisable callback for ssp 
buffer
+ *
+ * @indio_dev: iio device
+ *
+ * Returns 0 or negative value in case of error
+ */
+int ssp_common_buffer_postdisable(struct iio_dev *indio_dev)
+{
+   int ret;
+   struct ssp_sensor_data *spd = iio_priv(indio_dev);
+   struct ssp_data *data = dev_get_drvdata(indio_dev->dev.parent->parent);
+
+   ret = ssp_disable_sensor(data, spd->type);
+   if (ret < 0)
+   return ret;
+
+   kfree(spd->buffer);
+
+   return ret;
+}
+EXPORT_SYMBOL(ssp_common_buffer_postdisable);
+
+/**
+ * ssp_common_process_data() - Common process data callback for ssp sensors
+ *
+ * @indio_dev: iio device
+ * @buf:   source buffer
+ * @len:   sensor data length
+ * @timestamp: system timestamp
+ *
+ * Returns 0 or negative value in case of error
+ */
+int ssp_common_process_data(struct iio_dev *indio_dev, void *buf,
+   unsigned int len, int64_t timestamp)
+{
+   __le32 time;
+   int64_t calculated_time;
+   struct ssp_sensor_data *spd = iio_priv(indio_dev);
+
+   if (indio_dev->scan_bytes == 0)
+   return 0;
+
+   /*
+* it always sends full set of samples, remember about available masks
+*/
+   memcpy(spd->buffer, buf, len);
+
+   if (indio_dev->scan_timestamp) {
+   memcpy(&time, &((char *)buf)[len], SSP_TIME_SIZE);
+   calculated_time =
+   timestamp + (int64_t)le32_to_cpu(time) * 100;
+   }
+
+   return iio_push_to_buffers_with_timestamp(indio_dev, spd->buffer,
+ calculated_time);
+}
+EXPORT_SYMBOL(ssp_common_process_data);
+
+MODULE_AUTHOR("Karol Wrona ");
+MODULE_DESCRIPTION("Samsung sensorhub commons");
+MODULE_LICENSE("GPL");
diff --git a/drivers/iio/common/ssp_sensors/ssp_iio_sensor.h 
b/drivers/iio/common/ssp_sensors/ssp_iio_sensor.h
new file mode 100644
index 000..dda267c
--- /dev/null
+++ b/drivers/iio/common/ssp_sensors/ssp_iio_sensor.h
@@ -0,0 +1,70 @@
+#ifndef __SSP_IIO_SENSOR_H__
+#define __SSP_IIO_SENSOR_H__
+
+#define SSP_CHANNEL_AG(_type, _mod, _index) \
+{ \
+   .type = _type,\
+   .modified = 1,\
+   .channel2 = _mod,\
+   .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SAMP_FREQ),\
+   .scan_index = _index,\
+   .scan_type = {\
+   .sign = 's',\
+   .realbits = 16,\
+   .storagebits = 16,\
+   .shift = 0,\
+   .endianness = IIO_LE,\
+   },\
+}
+
+/* It is defined here as it is a mixed timestamp */
+#define SSP_CHAN_TIMESTAMP(_si) {