Re: [RFT 0/3] usb: usb3503: Fix probing on Arndale board (missing phy)
W dniu 10.10.2015 o 04:18, Kevin Hilman pisze: > Hi Krzystof, > > Krzysztof Kozlowskiwrites: > >> Introduction >> >> This patchset tries to fix probing of usb3503 on Arndale board >> if the Samsung PHY driver is probed later (or built as a module). >> >> *The patchset was not tested on Arndale board.* >> I don't have that board. Please test it and say if the usb3503 deferred probe >> works fine and the issue is solved. > > FYI... I built this series on top of next-20151009 and using > exynos_defconfig. I booted it on my arndale, and I still don't see the > networking come up. Full boot log attached. +cc Tyler Kevin, Thanks for testing but I am not sure if this boot failure is related to the patch. I mean if the patch should fix this particular boot failure. The board stopped to boot after enabling DWC2 and network USB gadget: http://www.spinics.net/lists/linux-samsung-soc/msg47009.html The boot log shows that usb3503 was probed but asix network adapter was not. I wonder how these things are related to each other... Nevertheless it would be difficult to debug the issue without the Arndale board. :) Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFT 0/3] usb: usb3503: Fix probing on Arndale board (missing phy)
Hi Krzystof, Krzysztof Kozlowskiwrites: > Introduction > > This patchset tries to fix probing of usb3503 on Arndale board > if the Samsung PHY driver is probed later (or built as a module). > > *The patchset was not tested on Arndale board.* > I don't have that board. Please test it and say if the usb3503 deferred probe > works fine and the issue is solved. FYI... I built this series on top of next-20151009 and using exynos_defconfig. I booted it on my arndale, and I still don't see the networking come up. Full boot log attached. Kevin Connected to arndale console [channel connected] (~$quit to exit) (user:khilman) is already connected # PYBOOT: console: connected. ~$hardreset Command(arndale console)> hardreset (user:khilman) Reboot arndale U-Boot 2013.01.-rc1-dirty (Jun 28 2013 - 07:14:48) for ARNDALE5250 CPU:Exynos5250@1000MHz Board: for ARNDALE5250 I2C: ready DRAM: 2 GiB WARNING: Caches not enabled Checking Boot Mode ... SDMMC MMC: EXYNOS DWMMC: 0, EXYNOS DWMMC: 1, EXYNOS DWMMC: 2 In:serial Out: serial Err: serial Net: No ethernet found. (Re)start USB... USB0: USB EHCI 1.00 scanning bus 0 for devices... 4 USB Device(s) found scanning usb for storage devices... 0 Storage Device(s) found scanning usb for ethernet devices... 1 Ethernet Device(s) found Hit any key to stop autoboot: # PYBOOT: u-boot: taking control. 3 0 ARNDALE5250 # ARNDALE5250 # version version U-Boot 2013.01.-rc1-dirty (Jun 28 2013 - 07:14:48) for ARNDALE5250 arm-linux-gnueabi-gcc (Ubuntu/Linaro 4.7.2-1ubuntu1) 4.7.2 GNU ld (GNU Binutils for Ubuntu) 2.22.90.20120919 ARNDALE5250 # setenv bootargs console=tty0 console=ttySAC2,115200n8 rw root=/dev/mmcblk1p3 rootwait rootfstype=ext4 setenv bootargs console=tty0 console=ttySAC2,115200n8 rw root=/dev/mmcblk1p3 rootwait rootfstype=ext4 ARNDALE5250 # setenv netargs 'setenv bootargs ${bootargs} "ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}:::none:192.168.1.3"' setenv netargs 'setenv bootargs ${bootargs} "ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}:::none:192.168.1.3"' ARNDALE5250 # if test -n ${initenv}; then run initenv; fi if test -n ${initenv}; then run initenv; fi ARNDALE5250 # if test -n ${preboot}; then run preboot; fi if test -n ${preboot}; then run preboot; fi (Re)start USB... USB0: USB EHCI 1.00 scanning bus 0 for devices... 4 USB Device(s) found scanning usb for storage devices... 0 Storage Device(s) found scanning usb for ethernet devices... 1 Ethernet Device(s) found ARNDALE5250 # setenv autoload no; setenv autoboot no setenv autoload no; setenv autoboot no ARNDALE5250 #dhcp dhcp Waiting for Ethernet connection... done. BOOTP broadcast 1 DHCP client bound to address 192.168.1.167 ARNDALE5250 #setenv serverip 192.168.1.2 setenv serverip 192.168.1.2 ARNDALE5250 # if test -n ${netargs}; then run netargs; fi if test -n ${netargs}; then run netargs; fi ARNDALE5250 # tftp 0x4100 192.168.1.2:tmp/arndale-o13inu/zImage tftp 0x4100 192.168.1.2:tmp/arndale-o13inu/zImage Waiting for Ethernet connection... done. Using asx0 device TFTP from server 192.168.1.2; our IP address is 192.168.1.167 Filename 'tmp/arndale-o13inu/zImage'. Load address: 0x4100 Loading: *# # # # ### done Bytes transferred = 4209056 (4039a0 hex) ARNDALE5250 # tftp 0x4200 192.168.1.2:tmp/arndale-o13inu/initrd-vFFjKf.cpio.gz tftp 0x4200 192.168.1.2:tmp/arndale-o13inu/initrd-vFFjKf.cpio.gz Waiting for Ethernet connection... done. Using asx0 device TFTP from server 192.168.1.2; our IP address is 192.168.1.167 Filename 'tmp/arndale-o13inu/initrd-vFFjKf.cpio.gz'. Load address: 0x4200 Loading: *# # # # # done Bytes transferred = 5001043 (4c4f53 hex) ARNDALE5250 #tftp 0x41f0 192.168.1.2:tmp/arndale-o13inu/tmp_2g_yE.dtb tftp 0x41f0 192.168.1.2:tmp/arndale-o13inu/tmp_2g_yE.dtb Waiting for Ethernet connection... done. Using asx0 device TFTP from server 192.168.1.2; our IP address is 192.168.1.167 Filename 'tmp/arndale-o13inu/tmp_2g_yE.dtb'. Load address: 0x41f0 Loading: *### done Bytes transferred = 42207 (a4df hex) ARNDALE5250 # printenv bootargs printenv bootargs bootargs=console=tty0 console=ttySAC2,115200n8 rw root=/dev/mmcblk1p3 rootwait rootfstype=ext4 ip=192.168.1.167:192.168.1.2:192.168.1.254:255.255.255.0:::none:192.168.1.3 ARNDALE5250 #bootz
Re: [RFT 0/3] usb: usb3503: Fix probing on Arndale board (missing phy)
Hello, On 10/08/2015 08:23 AM, Marek Szyprowski wrote: > Hello, > > On 2015-10-08 08:02, Krzysztof Kozlowski wrote: >> On 07.10.2015 23:26, Marek Szyprowski wrote: >>> Hello, >>> >>> On 2015-10-07 02:30, Krzysztof Kozlowski wrote: Introduction This patchset tries to fix probing of usb3503 on Arndale board if the Samsung PHY driver is probed later (or built as a module). *The patchset was not tested on Arndale board.* I don't have that board. Please test it and say if the usb3503 deferred probe works fine and the issue is solved. The patchset was tested on Odroid U3 board (which is different!) in a simulated environment. It is not sufficient testing. Difference == The usb3503 device driver can be used as a I2C device (on Odroid U3) or as a platform device connected through phy (on Arndale). In the second case the necessary phy reference has to be obtained and enabled. For some details please look also at thread [0][1]. [0] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-June/348524.html [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-June/348875.html >>> I'm not sure that this is the correct approach. usb3503 chip is simply >>> connected >>> to Exynos USB2 phy, so it visible on the USB bus. The real driver that >>> controls USB2 >>> PHY is Exynos EHCI driver and USB3503 should not mess around it. >> The ehci node (usb@1211) has one port configured and it takes one >> PHY reference (phy of id 1 - USB host). I can't see driver taking >> reference to HSIC0 or HSIC1 phys... Since I cannot diagnose the error I >> don't know what is really expected here. > > It looks that EHCI in Exynos 5250 and 5420 still use old phy bindings. For > the reference, see Exynos4 dts and exynos4412-odroidu3.dts to check how to > enable > more than one USB port (Odroid U3 has both HSIC ports enabled). > >> >>> In my opinion all that is needed in case of Arndale board is forcing >>> reset of >>> usb3503 chip after successful EHCI and USB2 PHY initialization (for some >>> reason >>> initialization of usb3503 chip must be done after usb host initialization). >>> However I have no idea which driver should trigger this reset. Right now >>> I didn't >>> find any good solution for additional control for devices which are on >>> autoprobed >>> bus like usb. >> The reset is done at the end of usb3503's probe. The question "why >> usb3503 has to be initialized after EHCI and USB PHY" is still valid... > > I remember that I saw some code to reset HSIC device after phy power on in > case > of HSIC-connected modem chip, so maybe this is somehow common for HSIC chips > (which are some special case of 'embedded usb'). > I also don't have an Arndale board and haven't followed the thread to closely but I just wanted to mention that the ChromiumOS 3.8 tree has a workaround to reset the HSIC phys: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/81685c447954a29d1098268776582457258dd98f%5E%21/ and later a "supports-hsicphy-reset" DT property was added to force the reset per board instead of unconditionally: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/a4d1c1a223ffa1ed38a4257d0378ca70c6667be0%5E%21/ Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFT 0/3] usb: usb3503: Fix probing on Arndale board (missing phy)
Hello, On 2015-10-08 11:35, Javier Martinez Canillas wrote: Hello, On 10/08/2015 08:23 AM, Marek Szyprowski wrote: Hello, On 2015-10-08 08:02, Krzysztof Kozlowski wrote: On 07.10.2015 23:26, Marek Szyprowski wrote: Hello, On 2015-10-07 02:30, Krzysztof Kozlowski wrote: Introduction This patchset tries to fix probing of usb3503 on Arndale board if the Samsung PHY driver is probed later (or built as a module). *The patchset was not tested on Arndale board.* I don't have that board. Please test it and say if the usb3503 deferred probe works fine and the issue is solved. The patchset was tested on Odroid U3 board (which is different!) in a simulated environment. It is not sufficient testing. Difference == The usb3503 device driver can be used as a I2C device (on Odroid U3) or as a platform device connected through phy (on Arndale). In the second case the necessary phy reference has to be obtained and enabled. For some details please look also at thread [0][1]. [0] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-June/348524.html [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-June/348875.html I'm not sure that this is the correct approach. usb3503 chip is simply connected to Exynos USB2 phy, so it visible on the USB bus. The real driver that controls USB2 PHY is Exynos EHCI driver and USB3503 should not mess around it. The ehci node (usb@1211) has one port configured and it takes one PHY reference (phy of id 1 - USB host). I can't see driver taking reference to HSIC0 or HSIC1 phys... Since I cannot diagnose the error I don't know what is really expected here. It looks that EHCI in Exynos 5250 and 5420 still use old phy bindings. For the reference, see Exynos4 dts and exynos4412-odroidu3.dts to check how to enable more than one USB port (Odroid U3 has both HSIC ports enabled). In my opinion all that is needed in case of Arndale board is forcing reset of usb3503 chip after successful EHCI and USB2 PHY initialization (for some reason initialization of usb3503 chip must be done after usb host initialization). However I have no idea which driver should trigger this reset. Right now I didn't find any good solution for additional control for devices which are on autoprobed bus like usb. The reset is done at the end of usb3503's probe. The question "why usb3503 has to be initialized after EHCI and USB PHY" is still valid... I remember that I saw some code to reset HSIC device after phy power on in case of HSIC-connected modem chip, so maybe this is somehow common for HSIC chips (which are some special case of 'embedded usb'). I also don't have an Arndale board and haven't followed the thread to closely but I just wanted to mention that the ChromiumOS 3.8 tree has a workaround to reset the HSIC phys: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/81685c447954a29d1098268776582457258dd98f%5E%21/ and later a "supports-hsicphy-reset" DT property was added to force the reset per board instead of unconditionally: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/a4d1c1a223ffa1ed38a4257d0378ca70c6667be0%5E%21/ I didn't check this approach, but for me it looks that the problem is caused by the lack of resetting the chip connected to hsic phy not the lack of resetting the phy itself. However this is pure speculation and one should check it with the real hardware. Best regards -- Marek Szyprowski, PhD Samsung R Institute Poland -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFT 0/3] usb: usb3503: Fix probing on Arndale board (missing phy)
Hello, On 2015-10-07 02:30, Krzysztof Kozlowski wrote: Introduction This patchset tries to fix probing of usb3503 on Arndale board if the Samsung PHY driver is probed later (or built as a module). *The patchset was not tested on Arndale board.* I don't have that board. Please test it and say if the usb3503 deferred probe works fine and the issue is solved. The patchset was tested on Odroid U3 board (which is different!) in a simulated environment. It is not sufficient testing. Difference == The usb3503 device driver can be used as a I2C device (on Odroid U3) or as a platform device connected through phy (on Arndale). In the second case the necessary phy reference has to be obtained and enabled. For some details please look also at thread [0][1]. [0] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-June/348524.html [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-June/348875.html I'm not sure that this is the correct approach. usb3503 chip is simply connected to Exynos USB2 phy, so it visible on the USB bus. The real driver that controls USB2 PHY is Exynos EHCI driver and USB3503 should not mess around it. In my opinion all that is needed in case of Arndale board is forcing reset of usb3503 chip after successful EHCI and USB2 PHY initialization (for some reason initialization of usb3503 chip must be done after usb host initialization). However I have no idea which driver should trigger this reset. Right now I didn't find any good solution for additional control for devices which are on autoprobed bus like usb. Best regards -- Marek Szyprowski, PhD Samsung R Institute Poland -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[RFT 0/3] usb: usb3503: Fix probing on Arndale board (missing phy)
Hi, Introduction This patchset tries to fix probing of usb3503 on Arndale board if the Samsung PHY driver is probed later (or built as a module). *The patchset was not tested on Arndale board.* I don't have that board. Please test it and say if the usb3503 deferred probe works fine and the issue is solved. The patchset was tested on Odroid U3 board (which is different!) in a simulated environment. It is not sufficient testing. Difference == The usb3503 device driver can be used as a I2C device (on Odroid U3) or as a platform device connected through phy (on Arndale). In the second case the necessary phy reference has to be obtained and enabled. For some details please look also at thread [0][1]. [0] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-June/348524.html [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-June/348875.html Best regards, Krzysztof Krzysztof Kozlowski (3): dt-bindings: usb: usb5303: Document new 'phys' property usb: misc: usb3503: Allow usage of device through phy interface ARM: dts: Fix usb3503 probe by enabling phy on exynos5250-arndale Documentation/devicetree/bindings/usb/usb3503.txt | 4 ++ arch/arm/boot/dts/exynos5250-arndale.dts | 2 + drivers/usb/misc/usb3503.c| 65 +++ 3 files changed, 71 insertions(+) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html