Re: [resend PATCH v3 4/4] usb: phy: add phy-hi6220-usb

2015-02-23 Thread Felipe Balbi 
On Wed, Feb 11, 2015 at 11:10:31AM +0200, Baruch Siach wrote:
> Hi Peter, Felipe,
> 
> > > new drivers only on drivers/phy/, sorry.
> > 
> > This driver has many USB dependencies, like otg, gadget. I don't know it
> > can use generic phy currently.
> 
> I would like to remind you the thread at 
> http://thread.gmane.org/gmane.linux.kernel/1858137. I have a USB PHY driver 
> here that depends on notify_connect/notify_disconnect, which are not 
> currently 
> provided by the generic phy infrastructure (drivers/phy/). What would be 
> acceptable solution for this case?

work with Kishon (generic phy maintainer) to add missing pieces you
need.

-- 
balbi


signature.asc
Description: Digital signature

Re: [resend PATCH v3 4/4] usb: phy: add phy-hi6220-usb

2015-02-23 Thread Felipe Balbi 
On Tue, Feb 10, 2015 at 10:53:23PM +0800, zhangfei wrote:
> 
> 
> On 02/10/2015 10:48 PM, Felipe Balbi wrote:
> >On Tue, Feb 10, 2015 at 05:10:04PM +0800, Zhangfei Gao wrote:
> >>Add usb phy controller for hi6220 platform
> >>
> >>Signed-off-by: Zhangfei Gao 
> >>---
> >>  drivers/usb/phy/Kconfig  |   9 ++
> >>  drivers/usb/phy/Makefile |   1 +
> >>  drivers/usb/phy/phy-hi6220-usb.c | 306 
> >> +++
> >>  3 files changed, 316 insertions(+)
> >>  create mode 100644 drivers/usb/phy/phy-hi6220-usb.c
> >>
> >>diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
> >>index c6d0c8e..405a3d0 100644
> >>--- a/drivers/usb/phy/Kconfig
> >>+++ b/drivers/usb/phy/Kconfig
> >>@@ -173,6 +173,15 @@ config USB_MXS_PHY
> >>
> >>  MXS Phy is used by some of the i.MX SoCs, for example imx23/28/6x.
> >>
> >>+config USB_HI6220_PHY
> >>+   tristate "hi6220 USB PHY support"
> >>+   select USB_PHY
> >>+   select MFD_SYSCON
> >>+   help
> >>+ Enable this to support the HISILICON HI6220 USB PHY.
> >>+
> >>+ To compile this driver as a module, choose M here.
> >>+
> >>  config USB_RCAR_PHY
> >>tristate "Renesas R-Car USB PHY support"
> >>depends on USB || USB_GADGET
> >>diff --git a/drivers/usb/phy/Makefile b/drivers/usb/phy/Makefile
> >>index 75f2bba..00172d3 100644
> >>--- a/drivers/usb/phy/Makefile
> >>+++ b/drivers/usb/phy/Makefile
> >>@@ -18,6 +18,7 @@ obj-$(CONFIG_SAMSUNG_USBPHY)  += 
> >>phy-samsung-usb.o
> >>  obj-$(CONFIG_TWL6030_USB) += phy-twl6030-usb.o
> >>  obj-$(CONFIG_USB_EHCI_TEGRA)  += phy-tegra-usb.o
> >>  obj-$(CONFIG_USB_GPIO_VBUS)   += phy-gpio-vbus-usb.o
> >>+obj-$(CONFIG_USB_HI6220_PHY)   += phy-hi6220-usb.o
> >
> >new drivers only on drivers/phy/, sorry.
> >
> OK, thanks for the info, I don't know this at all.
> So even usb phy should be put under drivers/phy/.
> 
> Will change that.

yes, thank you

-- 
balbi


signature.asc
Description: Digital signature

Re: [resend PATCH v3 4/4] usb: phy: add phy-hi6220-usb

2015-02-23 Thread Felipe Balbi 
On Wed, Feb 11, 2015 at 01:30:53AM +, Peter Chen wrote:
>  
> > > Signed-off-by: Zhangfei Gao 
> > > ---
> > >  drivers/usb/phy/Kconfig  |   9 ++
> > >  drivers/usb/phy/Makefile |   1 +
> > >  drivers/usb/phy/phy-hi6220-usb.c | 306
> > > +++
> > >  3 files changed, 316 insertions(+)
> > >  create mode 100644 drivers/usb/phy/phy-hi6220-usb.c
> > >
> > > diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig index
> > > c6d0c8e..405a3d0 100644
> > > --- a/drivers/usb/phy/Kconfig
> > > +++ b/drivers/usb/phy/Kconfig
> > > @@ -173,6 +173,15 @@ config USB_MXS_PHY
> > >
> > > MXS Phy is used by some of the i.MX SoCs, for example imx23/28/6x.
> > >
> > > +config USB_HI6220_PHY
> > > + tristate "hi6220 USB PHY support"
> > > + select USB_PHY
> > > + select MFD_SYSCON
> > > + help
> > > +   Enable this to support the HISILICON HI6220 USB PHY.
> > > +
> > > +   To compile this driver as a module, choose M here.
> > > +
> > >  config USB_RCAR_PHY
> > >   tristate "Renesas R-Car USB PHY support"
> > >   depends on USB || USB_GADGET
> > > diff --git a/drivers/usb/phy/Makefile b/drivers/usb/phy/Makefile index
> > > 75f2bba..00172d3 100644
> > > --- a/drivers/usb/phy/Makefile
> > > +++ b/drivers/usb/phy/Makefile
> > > @@ -18,6 +18,7 @@ obj-$(CONFIG_SAMSUNG_USBPHY)+= phy-
> > samsung-usb.o
> > >  obj-$(CONFIG_TWL6030_USB)+= phy-twl6030-usb.o
> > >  obj-$(CONFIG_USB_EHCI_TEGRA) += phy-tegra-usb.o
> > >  obj-$(CONFIG_USB_GPIO_VBUS)  += phy-gpio-vbus-usb.o
> > > +obj-$(CONFIG_USB_HI6220_PHY) += phy-hi6220-usb.o
> > 
> > new drivers only on drivers/phy/, sorry.
> > 
> 
> This driver has many USB dependencies, like otg, gadget. I don't know it
> can use generic phy currently.

then we improve generic phy framework. It's about time we moved
everything to that anyway.

-- 
balbi


signature.asc
Description: Digital signature

Re: [resend PATCH v3 4/4] usb: phy: add phy-hi6220-usb

2015-02-11 Thread zhangfei 



On 02/10/2015 10:48 PM, Felipe Balbi wrote:


diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
index c6d0c8e..405a3d0 100644
--- a/drivers/usb/phy/Kconfig
+++ b/drivers/usb/phy/Kconfig
@@ -173,6 +173,15 @@ config USB_MXS_PHY

  MXS Phy is used by some of the i.MX SoCs, for example imx23/28/6x.

+config USB_HI6220_PHY
+   tristate "hi6220 USB PHY support"
+   select USB_PHY
+   select MFD_SYSCON
+   help
+ Enable this to support the HISILICON HI6220 USB PHY.
+
+ To compile this driver as a module, choose M here.
+
  config USB_RCAR_PHY
tristate "Renesas R-Car USB PHY support"
depends on USB || USB_GADGET
diff --git a/drivers/usb/phy/Makefile b/drivers/usb/phy/Makefile
index 75f2bba..00172d3 100644
--- a/drivers/usb/phy/Makefile
+++ b/drivers/usb/phy/Makefile
@@ -18,6 +18,7 @@ obj-$(CONFIG_SAMSUNG_USBPHY)  += phy-samsung-usb.o
  obj-$(CONFIG_TWL6030_USB) += phy-twl6030-usb.o
  obj-$(CONFIG_USB_EHCI_TEGRA)  += phy-tegra-usb.o
  obj-$(CONFIG_USB_GPIO_VBUS)   += phy-gpio-vbus-usb.o
+obj-$(CONFIG_USB_HI6220_PHY)   += phy-hi6220-usb.o


new drivers only on drivers/phy/, sorry.


One more quesiton.
Should I also move Documentation/devicetree/bindings/usb/hi6220-usb.txt 
to Documentation/devicetree/bindings/phy/?


I describing both usb controller and phy here, is it still should be put 
under Documentation/devicetree/bindings/usb/?


Hisilicon hi6220 SoC USB controller
-

usb controller is inherited from dwc2, refer dwc2.txt
-

Required properties:
- compatible: "hisilicon,hi6220-usb"
Refer to dwc2.txt for dwc2 usb properties


PHY:
-

Required properties:
- compatible: "hisilicon,hi6220-usb-phy"
- vcc-supply: phandle to the regulator that provides power to the PHY.
- clocks: phandle and clock specifier of the PHY clock.
- hisilicon,peripheral-syscon: phandle of syscon used to control peripheral.
- hisilicon,vbus-gpios: gpio of detecting vbus.
- hisilicon,id-gpios: gpio of detecting id.

Example:

sys_ctrl: syscon@f703 {
compatible = "hisilicon,sysctrl", "syscon";
reg = <0x0 0xf703 0x0 0x1000>;
};

usb_phy: usb-phy {
compatible = "hisilicon,hi6220-usb-phy";
vcc-supply = <&fixed_5v_hub>;
hisilicon,vbus-gpios = <&gpio2 6 0>;
hisilicon,id-gpios = <&gpio2 5 0>;
hisilicon,peripheral-syscon = <&sys_ctrl>;
clocks = <&clock_sys HI6220_USBOTG_HCLK>;
};

usb: usb@f72c {
compatible = "hisilicon,hi6220-usb";
reg = <0x0 0xf72c 0x0 0x4>;
phys = <&usb_phy>;
dr_mode = "otg";
g-use-dma;
g-rx-fifo-size = <512>;
g-np-tx-fifo-size = <128>;
g-tx-fifo-size = <128>;
interrupts = <0 77 0x4>;
};




--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [resend PATCH v3 4/4] usb: phy: add phy-hi6220-usb

2015-02-11 Thread Baruch Siach 
Hi Peter, Felipe,

> > new drivers only on drivers/phy/, sorry.
> 
> This driver has many USB dependencies, like otg, gadget. I don't know it
> can use generic phy currently.

I would like to remind you the thread at 
http://thread.gmane.org/gmane.linux.kernel/1858137. I have a USB PHY driver 
here that depends on notify_connect/notify_disconnect, which are not currently 
provided by the generic phy infrastructure (drivers/phy/). What would be 
acceptable solution for this case?

baruch

-- 
 http://baruch.siach.name/blog/  ~. .~   Tk Open Systems
=}ooO--U--Ooo{=
   - bar...@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [resend PATCH v3 4/4] usb: phy: add phy-hi6220-usb

2015-02-10 Thread Peter Chen 
 
> > Signed-off-by: Zhangfei Gao 
> > ---
> >  drivers/usb/phy/Kconfig  |   9 ++
> >  drivers/usb/phy/Makefile |   1 +
> >  drivers/usb/phy/phy-hi6220-usb.c | 306
> > +++
> >  3 files changed, 316 insertions(+)
> >  create mode 100644 drivers/usb/phy/phy-hi6220-usb.c
> >
> > diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig index
> > c6d0c8e..405a3d0 100644
> > --- a/drivers/usb/phy/Kconfig
> > +++ b/drivers/usb/phy/Kconfig
> > @@ -173,6 +173,15 @@ config USB_MXS_PHY
> >
> >   MXS Phy is used by some of the i.MX SoCs, for example imx23/28/6x.
> >
> > +config USB_HI6220_PHY
> > +   tristate "hi6220 USB PHY support"
> > +   select USB_PHY
> > +   select MFD_SYSCON
> > +   help
> > + Enable this to support the HISILICON HI6220 USB PHY.
> > +
> > + To compile this driver as a module, choose M here.
> > +
> >  config USB_RCAR_PHY
> > tristate "Renesas R-Car USB PHY support"
> > depends on USB || USB_GADGET
> > diff --git a/drivers/usb/phy/Makefile b/drivers/usb/phy/Makefile index
> > 75f2bba..00172d3 100644
> > --- a/drivers/usb/phy/Makefile
> > +++ b/drivers/usb/phy/Makefile
> > @@ -18,6 +18,7 @@ obj-$(CONFIG_SAMSUNG_USBPHY)  += phy-
> samsung-usb.o
> >  obj-$(CONFIG_TWL6030_USB)  += phy-twl6030-usb.o
> >  obj-$(CONFIG_USB_EHCI_TEGRA)   += phy-tegra-usb.o
> >  obj-$(CONFIG_USB_GPIO_VBUS)+= phy-gpio-vbus-usb.o
> > +obj-$(CONFIG_USB_HI6220_PHY)   += phy-hi6220-usb.o
> 
> new drivers only on drivers/phy/, sorry.
> 

This driver has many USB dependencies, like otg, gadget. I don't know it
can use generic phy currently.

Peter
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [resend PATCH v3 4/4] usb: phy: add phy-hi6220-usb

2015-02-10 Thread zhangfei 



On 02/10/2015 10:48 PM, Felipe Balbi wrote:

On Tue, Feb 10, 2015 at 05:10:04PM +0800, Zhangfei Gao wrote:

Add usb phy controller for hi6220 platform

Signed-off-by: Zhangfei Gao 
---
  drivers/usb/phy/Kconfig  |   9 ++
  drivers/usb/phy/Makefile |   1 +
  drivers/usb/phy/phy-hi6220-usb.c | 306 +++
  3 files changed, 316 insertions(+)
  create mode 100644 drivers/usb/phy/phy-hi6220-usb.c

diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
index c6d0c8e..405a3d0 100644
--- a/drivers/usb/phy/Kconfig
+++ b/drivers/usb/phy/Kconfig
@@ -173,6 +173,15 @@ config USB_MXS_PHY

  MXS Phy is used by some of the i.MX SoCs, for example imx23/28/6x.

+config USB_HI6220_PHY
+   tristate "hi6220 USB PHY support"
+   select USB_PHY
+   select MFD_SYSCON
+   help
+ Enable this to support the HISILICON HI6220 USB PHY.
+
+ To compile this driver as a module, choose M here.
+
  config USB_RCAR_PHY
tristate "Renesas R-Car USB PHY support"
depends on USB || USB_GADGET
diff --git a/drivers/usb/phy/Makefile b/drivers/usb/phy/Makefile
index 75f2bba..00172d3 100644
--- a/drivers/usb/phy/Makefile
+++ b/drivers/usb/phy/Makefile
@@ -18,6 +18,7 @@ obj-$(CONFIG_SAMSUNG_USBPHY)  += phy-samsung-usb.o
  obj-$(CONFIG_TWL6030_USB) += phy-twl6030-usb.o
  obj-$(CONFIG_USB_EHCI_TEGRA)  += phy-tegra-usb.o
  obj-$(CONFIG_USB_GPIO_VBUS)   += phy-gpio-vbus-usb.o
+obj-$(CONFIG_USB_HI6220_PHY)   += phy-hi6220-usb.o


new drivers only on drivers/phy/, sorry.


OK, thanks for the info, I don't know this at all.
So even usb phy should be put under drivers/phy/.

Will change that.

Thanks Felipe
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [resend PATCH v3 4/4] usb: phy: add phy-hi6220-usb

2015-02-10 Thread Felipe Balbi 
On Tue, Feb 10, 2015 at 05:10:04PM +0800, Zhangfei Gao wrote:
> Add usb phy controller for hi6220 platform
> 
> Signed-off-by: Zhangfei Gao 
> ---
>  drivers/usb/phy/Kconfig  |   9 ++
>  drivers/usb/phy/Makefile |   1 +
>  drivers/usb/phy/phy-hi6220-usb.c | 306 
> +++
>  3 files changed, 316 insertions(+)
>  create mode 100644 drivers/usb/phy/phy-hi6220-usb.c
> 
> diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
> index c6d0c8e..405a3d0 100644
> --- a/drivers/usb/phy/Kconfig
> +++ b/drivers/usb/phy/Kconfig
> @@ -173,6 +173,15 @@ config USB_MXS_PHY
>  
> MXS Phy is used by some of the i.MX SoCs, for example imx23/28/6x.
>  
> +config USB_HI6220_PHY
> + tristate "hi6220 USB PHY support"
> + select USB_PHY
> + select MFD_SYSCON
> + help
> +   Enable this to support the HISILICON HI6220 USB PHY.
> +
> +   To compile this driver as a module, choose M here.
> +
>  config USB_RCAR_PHY
>   tristate "Renesas R-Car USB PHY support"
>   depends on USB || USB_GADGET
> diff --git a/drivers/usb/phy/Makefile b/drivers/usb/phy/Makefile
> index 75f2bba..00172d3 100644
> --- a/drivers/usb/phy/Makefile
> +++ b/drivers/usb/phy/Makefile
> @@ -18,6 +18,7 @@ obj-$(CONFIG_SAMSUNG_USBPHY)+= 
> phy-samsung-usb.o
>  obj-$(CONFIG_TWL6030_USB)+= phy-twl6030-usb.o
>  obj-$(CONFIG_USB_EHCI_TEGRA) += phy-tegra-usb.o
>  obj-$(CONFIG_USB_GPIO_VBUS)  += phy-gpio-vbus-usb.o
> +obj-$(CONFIG_USB_HI6220_PHY) += phy-hi6220-usb.o

new drivers only on drivers/phy/, sorry.

-- 
balbi


signature.asc
Description: Digital signature