Re: [PATCH 3/3] ARM: dts: omap4-sdp: add dynamic pin states for uart3/4
* Grygorii Strashko [130718 02:01]: > On 07/18/2013 11:09 AM, Tony Lindgren wrote: > > Don't think it's debug code - IO chain need to be rearmed after each > PRCM IO IRQ - otherwise IO wakeup events may be lost (at least on > OMAP4, OMAP5 requires more complex handling(( ). Nope, only after the mux register changes. I've verified it on am3730 with off-idle for both serial and wl12xx. > I didn't pick up your padconf patches yet -seems i need to be in sync :) Well you need those for proper wake-up event support.. > Below the diff I used to verify IO wake up (It follows old IO daisy > chain hanlding models in hwmod before DT): ..then these changes not needed with the pinctrl-single changes. Regards, Tony ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss
Re: [PATCH 3/3] ARM: dts: omap4-sdp: add dynamic pin states for uart3/4
* Grygorii Strashko [130717 09:48]: > Hi, > > On 07/17/2013 06:32 PM, Tony Lindgren wrote: > >* Grygorii Strashko [130717 04:49]: > >>Add dynamic "active"/"idle" pin states for uart3/4 which will be applied > >>when uart3/4 state is switched from active to idle and back by Runtime > >>PM or during system suspend. > > > >This is good for testing code, but should not be merged because > >omap4 has the iopad wake-ups available for uarts. So those can > >be always enabled. > > In this case, 2 IRQ will be received per each UART RX event - one from > PRCM and from UART - and that's not good from PM perspective (It will > affect on CPUIdle and CPUFreq at least). Oh I see, that's because I accidentally left the debug code enabled to make it easier to test the wake-up events without having to have working off-idle. The wake flags can be kept on always for sure. The patch below should sort out the issue of getting wake-up interrupts during runtime as long as you don't have DEBUG defined. Regards, Tony --- a/drivers/pinctrl/pinctrl-single-omap.c +++ b/drivers/pinctrl/pinctrl-single-omap.c @@ -140,9 +140,17 @@ static irqreturn_t pcs_omap_handle_irq(int irq, void *data) if ((val & OMAP_WAKEUP_EVENT_MASK) == OMAP_WAKEUP_EVENT_MASK) generic_handle_irq(wakeirq); } - +#ifdef DEBUG + /* +* This enables wake-up interrupts during runtime also +* causing duplicate interrupts. But it also makes debugging +* the wake-up events easy as deeper idle states often are +* not working for new devices while the drivers are being +* developed. +*/ if (pcso->reconfigure_io_chain) pcso->reconfigure_io_chain(); +#endif return IRQ_HANDLED; } ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss
Re: [PATCH 3/3] ARM: dts: omap4-sdp: add dynamic pin states for uart3/4
* Grygorii Strashko [130717 04:49]: > Add dynamic "active"/"idle" pin states for uart3/4 which will be applied > when uart3/4 state is switched from active to idle and back by Runtime > PM or during system suspend. This is good for testing code, but should not be merged because omap4 has the iopad wake-ups available for uarts. So those can be always enabled. > --- a/arch/arm/boot/dts/omap4-sdp.dts > +++ b/arch/arm/boot/dts/omap4-sdp.dts > @@ -181,18 +181,40 @@ > pinctrl-single,pins = < > 0x100 (PIN_INPUT_PULLUP | MUX_MODE0)/* > uart3_cts_rctx.uart3_cts_rctx */ > 0x102 (PIN_OUTPUT | MUX_MODE0) /* > uart3_rts_sd.uart3_rts_sd */ > - 0x104 (PIN_INPUT | MUX_MODE0) /* > uart3_rx_irrx.uart3_rx_irrx */ > 0x106 (PIN_OUTPUT | MUX_MODE0) /* > uart3_tx_irtx.uart3_tx_irtx */ > >; > }; This just need to become: pinctrl-single,pins = < ... 0x104 (WAKEUP_EN | PIN_INPUT_MUX_MODE0) /* uart3_rx_irrx.uart3_rx_irrx */ ... >; interrupts = ; }; And so on. For am33xx you need to remux things to GPIO for the wake-up events, so you should maybe test on that instead. Regards, Tony ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss
