Re: [patch] ALSA: ASoC: tas5086: signedness bug in tas5086_hw_params()

2013-03-13 Thread Daniel Mack 
On 13.03.2013 06:32, Dan Carpenter wrote:
 val has to be signed for the error handling to work.

Absolutely.

 Signed-off-by: Dan Carpenter dan.carpen...@oracle.com

Acked-by: Daniel Mack zon...@gmail.com


 
 diff --git a/sound/soc/codecs/tas5086.c b/sound/soc/codecs/tas5086.c
 index 008bea4..41d03ae 100644
 --- a/sound/soc/codecs/tas5086.c
 +++ b/sound/soc/codecs/tas5086.c
 @@ -251,7 +251,7 @@ static int tas5086_hw_params(struct snd_pcm_substream 
 *substream,
  {
   struct snd_soc_codec *codec = dai-codec;
   struct tas5086_private *priv = snd_soc_codec_get_drvdata(codec);
 - unsigned int val;
 + int val;
   int ret;
  
   priv-rate = params_rate(params);
 



___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [patch] ALSA: ASoC: tas5086: signedness bug in tas5086_hw_params()

2013-03-13 Thread Mark Brown 
On Wed, Mar 13, 2013 at 08:32:53AM +0300, Dan Carpenter wrote:
 val has to be signed for the error handling to work.

Applied, thanks.


signature.asc
Description: Digital signature
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

[patch] ALSA: ASoC: tas5086: signedness bug in tas5086_hw_params()

2013-03-12 Thread Dan Carpenter 
val has to be signed for the error handling to work.

Signed-off-by: Dan Carpenter dan.carpen...@oracle.com

diff --git a/sound/soc/codecs/tas5086.c b/sound/soc/codecs/tas5086.c
index 008bea4..41d03ae 100644
--- a/sound/soc/codecs/tas5086.c
+++ b/sound/soc/codecs/tas5086.c
@@ -251,7 +251,7 @@ static int tas5086_hw_params(struct snd_pcm_substream 
*substream,
 {
struct snd_soc_codec *codec = dai-codec;
struct tas5086_private *priv = snd_soc_codec_get_drvdata(codec);
-   unsigned int val;
+   int val;
int ret;
 
priv-rate = params_rate(params);
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss