Re: [patch -next] net: calxedaxgmac: fix condition in xgmac_set_features()

2013-04-25 Thread David Miller
From: Dan Carpenter dan.carpen...@oracle.com
Date: Thu, 25 Apr 2013 10:44:20 +0300

 The changed variable should be a 64 bit type, otherwise it can't store
 all the features.  The way the code is now the test for whether
 NETIF_F_RXCSUM changed is always false and we return immediately.
 
 Signed-off-by: Dan Carpenter dan.carpen...@oracle.com

Applied, thanks Dan.
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss


[patch -next] net: calxedaxgmac: fix condition in xgmac_set_features()

2013-04-25 Thread Dan Carpenter
The changed variable should be a 64 bit type, otherwise it can't store
all the features.  The way the code is now the test for whether
NETIF_F_RXCSUM changed is always false and we return immediately.

Signed-off-by: Dan Carpenter dan.carpen...@oracle.com

diff --git a/drivers/net/ethernet/calxeda/xgmac.c 
b/drivers/net/ethernet/calxeda/xgmac.c
index 791e5ff..4a1f2fa 100644
--- a/drivers/net/ethernet/calxeda/xgmac.c
+++ b/drivers/net/ethernet/calxeda/xgmac.c
@@ -1482,7 +1482,7 @@ static int xgmac_set_features(struct net_device *dev, 
netdev_features_t features
u32 ctrl;
struct xgmac_priv *priv = netdev_priv(dev);
void __iomem *ioaddr = priv-base;
-   u32 changed = dev-features ^ features;
+   netdev_features_t changed = dev-features ^ features;
 
if (!(changed  NETIF_F_RXCSUM))
return 0;
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss