Re: [patch -next] spi: spi-xilinx: cleanup a check in xilinx_spi_txrx_bufs()

[Mark Brown]

On Sun, Jun 09, 2013 at 04:07:28PM +0300, Dan Carpenter wrote:
 '!' has higher precedence than comparisons so the original condition
 is equivalent to if (xspi-remaining_bytes == 0).  This makes the
 static checkers complain.

Applied, thanks.


signature.asc
Description: Digital signature
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

[patch -next] spi: spi-xilinx: cleanup a check in xilinx_spi_txrx_bufs()

[Dan Carpenter]

'!' has higher precedence than comparisons so the original condition
is equivalent to if (xspi-remaining_bytes == 0).  This makes the
static checkers complain.

xspi-remaining_bytes is signed and from looking at the code
briefly, I think it might be able to go negative.  I suspect that
going negative may cause a bug, but I don't have the hardware and
can't test.

Signed-off-by: Dan Carpenter dan.carpen...@oracle.com

diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
index 0b8398c..fb56fcf 100644
--- a/drivers/spi/spi-xilinx.c
+++ b/drivers/spi/spi-xilinx.c
@@ -301,7 +301,7 @@ static int xilinx_spi_txrx_bufs(struct spi_device *spi, 
struct spi_transfer *t)
}
 
/* See if there is more data to send */
-   if (!xspi-remaining_bytes  0)
+   if (xspi-remaining_bytes = 0)
break;
}
 
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss