[patch v2] spi/xilinx: signedness issue checking platform_get_irq()

[Dan Carpenter]

In xilinx_spi_probe() we use xspi-irq to store negative error codes so
it has to be signed.  We weren't going to use the upper bit any way so
this is fine.

Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
v2:  The first version introduced an ugly cast.  Sorry for that.

diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
index fea815c..0f4a093 100644
--- a/drivers/spi/spi-xilinx.c
+++ b/drivers/spi/spi-xilinx.c
@@ -82,7 +82,7 @@ struct xilinx_spi {
struct completion done;
void __iomem*regs;  /* virt. address of the control registers */
 
-   u32 irq;
+   int irq;
 
u8 *rx_ptr; /* pointer in the Tx buffer */
const u8 *tx_ptr;   /* pointer in the Rx buffer */
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [patch v2] spi/xilinx: signedness issue checking platform_get_irq()

[Mark Brown]

On Wed, Jul 17, 2013 at 06:34:48PM +0300, Dan Carpenter wrote:
 In xilinx_spi_probe() we use xspi-irq to store negative error codes so
 it has to be signed.  We weren't going to use the upper bit any way so
 this is fine.

Applied, thanks.


signature.asc
Description: Digital signature
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss