RE: [PATCH 2/5] ARM: dts: exynos5250-arndale: Add PMIC node entry

2013-03-10 Thread Kukjin Kim 
amit daniel kachhap wrote:
> 
> The V2 of this patch is posted with comments suggested by Anil and
> some missing LDO's.
> 
OK, I see.

- Kukjin

___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH 2/5] ARM: dts: exynos5250-arndale: Add PMIC node entry

2013-02-11 Thread amit daniel kachhap 
The V2 of this patch is posted with comments suggested by Anil and
some missing LDO's.

Thanks,
Amit Daniel

On Wed, Feb 6, 2013 at 9:56 PM, Tushar Behera  wrote:
> On 02/07/2013 11:19 AM, Kumar, Anil wrote:
>> On Thu, Feb 07, 2013 at 10:45:26, Tushar Behera wrote:
>>> From: Amit Daniel Kachhap 
>>>
>>> Added S5M8767 PMIC DT nodes to Arndale board.
>>>
>>> Signed-off-by: Amit Daniel Kachhap 
>>> Signed-off-by: Sachin Kamat 
>>> Signed-off-by: Tushar Behera 
>>> ---
>>>  arch/arm/boot/dts/exynos5250-arndale.dts |  213 
>>> +-
>>>  1 files changed, 212 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts 
>>> b/arch/arm/boot/dts/exynos5250-arndale.dts
>>> index 9ce40df..b40a02f 100644
>>> --- a/arch/arm/boot/dts/exynos5250-arndale.dts
>>> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
>>> @@ -25,7 +25,218 @@
>>>  };
>>>
>>>  i2c@12C6 {
>>> -status = "disabled";
>>> +status = "okay";
>>
>> Is there any need to change status "okay" here as in dtsi file it is
>> by default okay ?
>>
>
> Right, there is no need for setting it as "okay" explicitly.
>
> --
> Tushar Behera
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" 
> in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH 2/5] ARM: dts: exynos5250-arndale: Add PMIC node entry

2013-02-06 Thread Tushar Behera 
On 02/07/2013 11:19 AM, Kumar, Anil wrote:
> On Thu, Feb 07, 2013 at 10:45:26, Tushar Behera wrote:
>> From: Amit Daniel Kachhap 
>>
>> Added S5M8767 PMIC DT nodes to Arndale board.
>>
>> Signed-off-by: Amit Daniel Kachhap 
>> Signed-off-by: Sachin Kamat 
>> Signed-off-by: Tushar Behera 
>> ---
>>  arch/arm/boot/dts/exynos5250-arndale.dts |  213 
>> +-
>>  1 files changed, 212 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts 
>> b/arch/arm/boot/dts/exynos5250-arndale.dts
>> index 9ce40df..b40a02f 100644
>> --- a/arch/arm/boot/dts/exynos5250-arndale.dts
>> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
>> @@ -25,7 +25,218 @@
>>  };
>>  
>>  i2c@12C6 {
>> -status = "disabled";
>> +status = "okay";
> 
> Is there any need to change status "okay" here as in dtsi file it is
> by default okay ?   
> 

Right, there is no need for setting it as "okay" explicitly.

-- 
Tushar Behera
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

RE: [PATCH 2/5] ARM: dts: exynos5250-arndale: Add PMIC node entry

2013-02-06 Thread Kumar, Anil 
On Thu, Feb 07, 2013 at 10:45:26, Tushar Behera wrote:
> From: Amit Daniel Kachhap 
> 
> Added S5M8767 PMIC DT nodes to Arndale board.
> 
> Signed-off-by: Amit Daniel Kachhap 
> Signed-off-by: Sachin Kamat 
> Signed-off-by: Tushar Behera 
> ---
>  arch/arm/boot/dts/exynos5250-arndale.dts |  213 
> +-
>  1 files changed, 212 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts 
> b/arch/arm/boot/dts/exynos5250-arndale.dts
> index 9ce40df..b40a02f 100644
> --- a/arch/arm/boot/dts/exynos5250-arndale.dts
> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
> @@ -25,7 +25,218 @@
>   };
>  
>   i2c@12C6 {
> - status = "disabled";
> + status = "okay";

Is there any need to change status "okay" here as in dtsi file it is
by default okay ?   

> + samsung,i2c-sda-delay = <100>;
> + samsung,i2c-max-bus-freq = <2>;
> + samsung,i2c-slave-addr = <0x66>;
> + gpios = <&gpb3 0 2 3 0>,
> + <&gpb3 1 2 3 0>;
> +
> + s5m8767_pmic@66 {
> + compatible = "samsung,s5m8767-pmic";
> + reg = <0x66>;
> +
> + s5m8767,pmic-buck2-dvs-voltage = <130>;
> + s5m8767,pmic-buck3-dvs-voltage = <110>;
> + s5m8767,pmic-buck4-dvs-voltage = <120>;
> + s5m8767,pmic-buck-dvs-gpios = <&gpd1 0 1 0 0>,
> + <&gpd1 1 1 0 0>,
> + <&gpd1 2 1 0 0>;
> + s5m8767,pmic-buck-ds-gpios = <&gpx2 3 1 0 0>,
> + <&gpx2 4 1 0 0>,
> + <&gpx2 5 1 0 0>;
> + regulators {
> + ldo1_reg: LDO1 {
> + regulator-name = "VDD_ALIVE_1.0V";
> + regulator-min-microvolt = <110>;
> + regulator-max-microvolt = <110>;
> + regulator-always-on;
> + regulator-boot-on;
> + op_mode = <1>;
> + };
> +
> + ldo2_reg: LDO2 {
> + regulator-name = "VDD_28IO_DP_1.35V";
> + regulator-min-microvolt = <120>;
> + regulator-max-microvolt = <120>;
> + regulator-always-on;
> + op_mode = <1>;
> + };
> +
> + ldo3_reg: LDO3 {
> + regulator-name = "VDD_COMMON1_1.8V";
> + regulator-min-microvolt = <180>;
> + regulator-max-microvolt = <180>;
> + regulator-always-on;
> + op_mode = <1>;
> + };
> +
> + ldo4_reg: LDO4 {
> + regulator-name = "VDD_IOPERI_1.8V";
> + regulator-min-microvolt = <180>;
> + regulator-max-microvolt = <180>;
> + regulator-always-on;
> + op_mode = <1>;
> + };
> +
> + ldo5_reg: LDO5 {
> + regulator-name = "VDD_EXT_1.8V";
> + regulator-min-microvolt = <180>;
> + regulator-max-microvolt = <180>;
> + regulator-always-on;
> + op_mode = <1>;
> + };
> +
> + ldo6_reg: LDO6 {
> + regulator-name = "VDD_MPLL_1.1V";
> + regulator-min-microvolt = <110>;
> + regulator-max-microvolt = <110>;
> + regulator-always-on;
> + op_mode = <1>;
> + };
> +
> + ldo7_reg: LDO7 {
> + regulator-name = "VDD_XPLL_1.1V";
> + regulator-min-microvolt = <110>;
> + regulator-max-microvolt = <110>;
> + regulator-always-on;
> + op_mode = <1>;
> + };
> +
> +