Re: [PATCH v3 06/11] staging: drm/imx: Add LDB support
Am Freitag, den 07.06.2013, 09:40 +0200 schrieb Markus Niebel:
Am 28.03.2013 16:23, wrote Philipp Zabel:
From: Sascha Hauer s.ha...@pengutronix.de
This adds support for the LVDS Display Bridge contained
in i.MX5 and i.MX6 SoCs.
Bit mapping, data width, and video timings are configurable
via device tree. Dual-channel mode is supported for a single
high-resolution source.
Signed-off-by: Sascha Hauer s.ha...@pengutronix.de
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
Changes since v2:
- Removed commented out code
- Replaced magic constants
- Select OF_VIDEOMODE
---
.../devicetree/bindings/staging/imx-drm/ldb.txt| 99
drivers/staging/imx-drm/Kconfig| 8 +
drivers/staging/imx-drm/Makefile | 1 +
drivers/staging/imx-drm/imx-ldb.c | 609
+
4 files changed, 717 insertions(+)
create mode 100644
Documentation/devicetree/bindings/staging/imx-drm/ldb.txt
create mode 100644 drivers/staging/imx-drm/imx-ldb.c
[...]
diff --git a/drivers/staging/imx-drm/imx-ldb.c
b/drivers/staging/imx-drm/imx-ldb.c
new file mode 100644
index 000..75607b3
--- /dev/null
+++ b/drivers/staging/imx-drm/imx-ldb.c
@@ -0,0 +1,609 @@
[...]
+static void imx_ldb_set_clock(struct imx_ldb *ldb, int mux, int chno,
+ unsigned long serial_clk, unsigned long di_clk)
+{
+ int ret;
+
+ dev_dbg(ldb-dev, %s: now: %ld want: %ld\n, __func__,
+ clk_get_rate(ldb-clk_pll[chno]), serial_clk);
+ clk_set_rate(ldb-clk_pll[chno], serial_clk);
+
+ dev_dbg(ldb-dev, %s after: %ld\n, __func__,
+ clk_get_rate(ldb-clk_pll[chno]));
+
+ dev_dbg(ldb-dev, %s: now: %ld want: %ld\n, __func__,
+ clk_get_rate(ldb-clk[chno]),
+ (long int)di_clk);
+ clk_set_rate(ldb-clk[chno], di_clk);
+
+ dev_dbg(ldb-dev, %s after: %ld\n, __func__,
+ clk_get_rate(ldb-clk[chno]));
+
+ /* set display clock mux to LDB input clock */
I think this will fail on i.MX53 with split mode enable in case of
mux != chno, since ipu_din can only be muxed to ldb_din_gate.
+ ret = clk_set_parent(ldb-clk_sel[mux], ldb-clk[chno]);
That is true. We should use both ldb_din_gates in split mode on
i.MX53, with both ldb_din_sel derived from the same parent.
+ if (ret) {
+ dev_err(ldb-dev, unable to set di%d parent clock to
ldb_di%d\n, mux, chno);
+ }
+}
+
+static void imx_ldb_encoder_prepare(struct drm_encoder *encoder)
+{
+ struct imx_ldb_channel *imx_ldb_ch = enc_to_imx_ldb_ch(encoder);
+ struct imx_ldb *ldb = imx_ldb_ch-ldb;
+ struct drm_display_mode *mode = encoder-crtc-mode;
+ unsigned long serial_clk;
+ unsigned long di_clk = mode-clock * 1000;
+ int mux = imx_drm_encoder_get_mux_id(imx_ldb_ch-imx_drm_encoder,
+ encoder-crtc);
+
+ if (ldb-ldb_ctrl LDB_SPLIT_MODE_EN) {
+ /* dual channel LVDS mode */
+ serial_clk = 3500UL * mode-clock;
See comment in imx_ldb_set_clock
+ imx_ldb_set_clock(ldb, mux, 0, serial_clk, di_clk);
+ imx_ldb_set_clock(ldb, mux, 1, serial_clk, di_clk);
[...]
regards
Philipp
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
Re: [PATCH v3 06/11] staging: drm/imx: Add LDB support
On Thu, Mar 28, 2013 at 04:23:30PM +0100, Philipp Zabel wrote:
+static void imx_ldb_encoder_prepare(struct drm_encoder *encoder)
+{
+ struct imx_ldb_channel *imx_ldb_ch = enc_to_imx_ldb_ch(encoder);
+ struct imx_ldb *ldb = imx_ldb_ch-ldb;
+ struct drm_display_mode *mode = encoder-crtc-mode;
+ unsigned long serial_clk;
+ unsigned long di_clk = mode-clock * 1000;
+ int mux = imx_drm_encoder_get_mux_id(imx_ldb_ch-imx_drm_encoder,
+ encoder-crtc);
+
+ if (ldb-ldb_ctrl LDB_SPLIT_MODE_EN) {
+ /* dual channel LVDS mode */
+ serial_clk = 3500UL * mode-clock;
+ imx_ldb_set_clock(ldb, mux, 0, serial_clk, di_clk);
+ imx_ldb_set_clock(ldb, mux, 1, serial_clk, di_clk);
+ } else {
+ serial_clk = 7000UL * mode-clock;
+ imx_ldb_set_clock(ldb, mux, imx_ldb_ch-chno, serial_clk,
di_clk);
+ }
+
+ imx_drm_crtc_panel_format(encoder-crtc, DRM_MODE_ENCODER_LVDS,
+ V4L2_PIX_FMT_RGB24);
I have panel which needs it to be V4L2_PIX_FMT_BGR666. We should
probably have a device tree property for that like interface_pix_fmt in
parallel display support?
Shawn
+}
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
Re: [PATCH v3 06/11] staging: drm/imx: Add LDB support
Hi Shawn,
Am Donnerstag, den 06.06.2013, 23:16 +0800 schrieb Shawn Guo:
On Thu, Mar 28, 2013 at 04:23:30PM +0100, Philipp Zabel wrote:
+static void imx_ldb_encoder_prepare(struct drm_encoder *encoder)
+{
+ struct imx_ldb_channel *imx_ldb_ch = enc_to_imx_ldb_ch(encoder);
+ struct imx_ldb *ldb = imx_ldb_ch-ldb;
+ struct drm_display_mode *mode = encoder-crtc-mode;
+ unsigned long serial_clk;
+ unsigned long di_clk = mode-clock * 1000;
+ int mux = imx_drm_encoder_get_mux_id(imx_ldb_ch-imx_drm_encoder,
+encoder-crtc);
+
+ if (ldb-ldb_ctrl LDB_SPLIT_MODE_EN) {
+ /* dual channel LVDS mode */
+ serial_clk = 3500UL * mode-clock;
+ imx_ldb_set_clock(ldb, mux, 0, serial_clk, di_clk);
+ imx_ldb_set_clock(ldb, mux, 1, serial_clk, di_clk);
+ } else {
+ serial_clk = 7000UL * mode-clock;
+ imx_ldb_set_clock(ldb, mux, imx_ldb_ch-chno, serial_clk,
di_clk);
+ }
+
+ imx_drm_crtc_panel_format(encoder-crtc, DRM_MODE_ENCODER_LVDS,
+ V4L2_PIX_FMT_RGB24);
I have panel which needs it to be V4L2_PIX_FMT_BGR666. We should
probably have a device tree property for that like interface_pix_fmt in
parallel display support?
I'm not sure. Is this something that should be done unconditionally for
fsl,data-width = 18?
regards
Philipp
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
Re: [PATCH v3 06/11] staging: drm/imx: Add LDB support
On Thu, Jun 06, 2013 at 05:54:42PM +0200, Philipp Zabel wrote: I'm not sure. Is this something that should be done unconditionally for fsl,data-width = 18? Ah, yes, that's better. Shawn ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss
