Re: [PATCHv2 10/11] ARM: dts: omap4 clock data
On 06/19/13 06:19, Tero Kristo wrote:
diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
index 2a56428..70608db 100644
--- a/arch/arm/boot/dts/omap4.dtsi
+++ b/arch/arm/boot/dts/omap4.dtsi
@@ -106,6 +106,8 @@
ti,hwmods = counter_32k;
};
+ /include/ omap4-clocks.dtsi
+
Doesn't this cause one platform device to be allocated for each clock
node defined in omap4-clocks.dtsi? Are you concerned about wasting
memory on things that aren't really devices and that will never be probed?
omap4_pmx_core: pinmux@4a100040 {
compatible = ti,omap4-padconf, pinctrl-single;
reg = 0x4a100040 0x0196;
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
Re: [PATCHv2 10/11] ARM: dts: omap4 clock data
On 16:19-20130619, Tero Kristo wrote:
snip
diff --git a/arch/arm/boot/dts/omap4-clocks.dtsi
b/arch/arm/boot/dts/omap4-clocks.dtsi
new file mode 100644
index 000..b420d8a
--- /dev/null
+++ b/arch/arm/boot/dts/omap4-clocks.dtsi
[...]
+/* XXX Missing round_rate, set_rate in ops */
could be dropped?
+dpll_core_m3x2_div_ck: dpll_core_m3x2_div_ck@4a004134 {
+ compatible = divider-clock;
+ clocks = dpll_core_x2_ck;
+ #clock-cells = 0;
+ reg = 0x4a004134 0x4;
+ bit-mask = 0x1f;
+ index-starts-at-one;
+};
[..]
+
+/* XXX Missing round_rate, set_rate in ops */
could be dropped?
+dpll_per_m3x2_div_ck: dpll_per_m3x2_div_ck@4a008154 {
+ compatible = divider-clock;
+ clocks = dpll_per_x2_ck;
+ #clock-cells = 0;
+ reg = 0x4a008154 0x4;
+ bit-mask = 0x1f;
+ index-starts-at-one;
+};
+
[...]
+
+/*
+ * clocks specific to omap4460
+ */
+/*
+ * clocks specific to omap4430
+ */
+/*
+ * clocks common to omap44xx
+ */
could be dropped?
btw, are we differentiating 4430 and 4460?A
Example:
bandgap_fclk in 4430
Vs
div_ts_ck, bandgap_ts_fclk in 4460?
--
Regards,
Nishanth Menon
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
Re: [PATCHv2 10/11] ARM: dts: omap4 clock data
On 16:49-20130619, Tero Kristo wrote: On 06/19/2013 04:30 PM, Nishanth Menon wrote: On 16:19-20130619, Tero Kristo wrote: [...] + +/* + * clocks specific to omap4460 + */ +/* + * clocks specific to omap4430 + */ +/* + * clocks common to omap44xx + */ could be dropped? Same. btw, are we differentiating 4430 and 4460?A Example: bandgap_fclk in 4430 Vs div_ts_ck, bandgap_ts_fclk in 4460? Both nodes are available for both SoCs as of now. Driver should differentiate which clock node to use though. Added Eduardo for commenting this part, maybe we should add a couple of entries to the list in cclock44xx_data.c...? How about this: we do have 443x.dtsi and 4460.dtsi - add the corresponding clock nodes there? ideally, driver should just do devm_clk_get and should not worry about what SoC revision it is running on. -- Regards, Nishanth Menon ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss
