Re: Remaining reviews needed to release Freenet 1495

2022-12-06 Thread Steve Dougherty
Agreed! A decade ago when IPv6 stacks were liable to be buggy, it was 
understandable, but by now enabling it by default seems more than reasonable.

On Tue, Dec 6, 2022 at 9:42 AM, s7r  wrote:

> Dr. Arne Babenhauserheide wrote:
>> Hi,
>>
>>
>> We’re getting ever closer to release. I merged the already reviewed
>> pull-requests, but some important PRs remain so we can release. Please
>> help getting these reviewed!
>>
>
> Thanks for the work!
>
> I would like to propose we change something that has been bothering me
> for years, and I have extensively tested it under Debian, FreeBSD and
> Windows during the last 4 Freenet releases and it does not cause any
> problems at all if we change it the way I suggest.
>
> In the default wrapper.conf file we ship with Freenet, there is this
> over a decade config line:
>
> # Needed for some linux distros? Shouldn't prevent using IPv6, just make
> it prefer IPv4?
> wrapper.java.additional.3=-Djava.net.preferIPv4Stack=true
>
> The thing is, it actually really prevents you from using IPv6! At least
> on Debian, Windows and FreeBSD (I am confident on every OS this is the
> case, because it's a Java thing more than an OS thing).
>
> With these lines in wrapper.conf we have the following problems:
>
> - node does not bind to IPv6 interfaces, only bind to IPv4 available
> addresses for both opennet and darknet;
>
> - It also does not connect to any IPv6 peers. If you remove it, even if
> node bind to and node opennet bind to is set to the `default` 0.0.0.0,
> it properly binds to *all* interfaces (IPv6 and IPv4).
>
> - it doesn't open the localhost FProxy except on 127.0.0.1, regardless
> the freenet.ini setting is to also bind to 0:0:0:0:0:0:0:1 -- with that
> line removed, FProxy successfully finds to 127.0.0.1 and [::1].
>
> *So there are no additional settings to do to make sure all goes well
> except as remove these two lines from wrapper.conf.*
>
> We should remove it entirely or comment it out, and also make sure it
> overwrites the `wrapper.conf` on disk for users that already have
> freenet installed and are upgrading automatically.
>
> This will add better IPv6 support, more reachable nodes in the Freenet
> network (IPv6 and NAT is much rarely used together) and it makes sense
> to do it finally, after 25 years since the IPv6 RFC :)
>
> I'll do a PR to update the seednodes for better bootstrap support to new
> connecting users, hopefully the windows installer will take them on in
> time. Monitoring service is running here:
>
> https://freenet.dotbit.zone/

Re: Remaining reviews needed to release Freenet 1495

2022-12-06 Thread s7r

Dr. Arne Babenhauserheide wrote:

Hi,


We’re getting ever closer to release. I merged the already reviewed
pull-requests, but some important PRs remain so we can release. Please
help getting these reviewed!



Thanks for the work!

I would like to propose we change something that has been bothering me 
for years, and I have extensively tested it under Debian, FreeBSD and 
Windows during the last 4 Freenet releases and it does not cause any 
problems at all if we change it the way I suggest.


In the default wrapper.conf file we ship with Freenet, there is this 
over a decade config line:


# Needed for some linux distros? Shouldn't prevent using IPv6, just make 
it prefer IPv4?

wrapper.java.additional.3=-Djava.net.preferIPv4Stack=true

The thing is, it actually really prevents you from using IPv6! At least 
on Debian, Windows and FreeBSD (I am confident on every OS this is the 
case, because it's a Java thing more than an OS thing).


With these lines in wrapper.conf we have the following problems:

- node does not bind to IPv6 interfaces, only bind to IPv4 available 
addresses for both opennet and darknet;


- It also does not connect to any IPv6 peers. If you remove it, even if 
node bind to and node opennet bind to is set to the `default` 0.0.0.0, 
it properly binds to *all* interfaces (IPv6 and IPv4).


- it doesn't open the localhost FProxy except on 127.0.0.1, regardless 
the freenet.ini setting is to also bind to 0:0:0:0:0:0:0:1 -- with that 
line removed, FProxy successfully finds to 127.0.0.1 and [::1].


*So there are no additional settings to do to make sure all goes well 
except as remove these two lines from wrapper.conf.*


We should remove it entirely or comment it out, and also make sure it 
overwrites the `wrapper.conf` on disk for users that already have 
freenet installed and are upgrading automatically.


This will add better IPv6 support, more reachable nodes in the Freenet 
network (IPv6 and NAT is much rarely used together) and it makes sense 
to do it finally, after 25 years since the IPv6 RFC :)


I'll do a PR to update the seednodes for better bootstrap support to new 
connecting users, hopefully the windows installer will take them on in 
time. Monitoring service is running here:


https://freenet.dotbit.zone/



OpenPGP_signature
Description: OpenPGP digital signature