Re: Pull-requests in need of reviews
Hi, I hit a roadblock on the Windows installer — it needs someone with innosetup skills and ideally a Windows system. We need Java 10 bundled with the installer. I already added the new JRE, but it needs to be unzipped (without zip we hit the github filesize limit). It would be awesome if one of you could clone https://github.com/freenet/wininstaller-innosetup.git and get https://github.com/freenet/wininstaller-innosetup/blob/master/FreenetInstall_InnoSetup.iss working on windows64! There is a github workflow, but developing against that without a local setup is awful. https://github.com/freenet/wininstaller-innosetup/blob/master/.github/workflows/ci.yml Best wishes, Arne "Dr. Arne Babenhauserheide" writes: > DC* writes: >> Happy new year! > > Thank you! To you, too! > >> These emails summaries are a good idea to push work forward and point >> people to places where help is needed. Keep them up! :) > > I’ll try :-) > > > We got many reviewed now. The following is still open and required for > release: > >>> # Java 16 and 17 compat: >>> - add required module opens for Java 17 to wrapper.conf: >>> https://github.com/freenet/fred/pull/755 > > > This one is still open, but does not block the release: > >>> # Remove potential attack-vector in pitch black mitigation (thanks to >>> nextgens!) >>> - randomize pitch black defense times: >>> https://github.com/freenet/fred/pull/747 > > And these are *reviewed* and ready for release. Thank you! > >>> # Fix peer scaling (fast nodes needed more than their capacity from slow >>> nodes) >>> - fix peer scaling for very fast peers: >>> - https://github.com/freenet/fred/pull/749 > >>> # More robust friend-to-friend workflow: >>> - New peer via freenet uri: https://github.com/freenet/fred/pull/753 >>> - try replacing spaces by newlines in noderefs when parsing fails: >>> https://github.com/freenet/fred/pull/752 >>> >>> # Config-Optimizations: >>> - Increase default max threads to 1000: >>> https://github.com/freenet/fred/pull/757 >>> - increase default datastore size to 100GiB: >>> https://github.com/freenet/fred/pull/756 >>> >>> >>> # Add warning about voice-recognition being used for surveillance >>> - add voice recognition warning: https://github.com/freenet/fred/pull/750 >>> >>> # add support-code to make it easier for someone to take up the task to >>> fix the ogg vorbis filter >>> - add output of filtered file to the OggFilterTest: >>> https://github.com/freenet/fred/pull/748 >>> >>> # Polish: >>> - note effectively published field: https://github.com/freenet/fred/pull/754 > > Thank you very much for your reviews! > > Best wishes, > Arne -- Unpolitisch sein heißt politisch sein, ohne es zu merken. draketo.de signature.asc Description: PGP signature
Re: Pull-requests in need of reviews
DC* writes: > Happy new year! Thank you! To you, too! > These emails summaries are a good idea to push work forward and point > people to places where help is needed. Keep them up! :) I’ll try :-) We got many reviewed now. The following is still open and required for release: >> # Java 16 and 17 compat: >> - add required module opens for Java 17 to wrapper.conf: >> https://github.com/freenet/fred/pull/755 This one is still open, but does not block the release: >> # Remove potential attack-vector in pitch black mitigation (thanks to >> nextgens!) >> - randomize pitch black defense times: >> https://github.com/freenet/fred/pull/747 And these are *reviewed* and ready for release. Thank you! >> # Fix peer scaling (fast nodes needed more than their capacity from slow >> nodes) >> - fix peer scaling for very fast peers: >> - https://github.com/freenet/fred/pull/749 >> # More robust friend-to-friend workflow: >> - New peer via freenet uri: https://github.com/freenet/fred/pull/753 >> - try replacing spaces by newlines in noderefs when parsing fails: >> https://github.com/freenet/fred/pull/752 >> >> # Config-Optimizations: >> - Increase default max threads to 1000: >> https://github.com/freenet/fred/pull/757 >> - increase default datastore size to 100GiB: >> https://github.com/freenet/fred/pull/756 >> >> >> # Add warning about voice-recognition being used for surveillance >> - add voice recognition warning: https://github.com/freenet/fred/pull/750 >> >> # add support-code to make it easier for someone to take up the task to >> fix the ogg vorbis filter >> - add output of filtered file to the OggFilterTest: >> https://github.com/freenet/fred/pull/748 >> >> # Polish: >> - note effectively published field: https://github.com/freenet/fred/pull/754 Thank you very much for your reviews! Best wishes, Arne -- Unpolitisch sein heißt politisch sein, ohne es zu merken. draketo.de signature.asc Description: PGP signature
Re: Pull-requests in need of reviews
Hi, Happy new year! I took a look at the easy ones first! I'll review the others later tonight. These emails summaries are a good idea to push work forward and point people to places where help is needed. Keep them up! :) Best regards, On 2022-01-11 22:53, Dr. Arne Babenhauserheide wrote: > Hi, > > > I created several small and self-contained pull-requests that need > review. Please take a look so we can move forward with the next release! > > # Java 16 and 17 compat: > - add required module opens for Java 17 to wrapper.conf: > https://github.com/freenet/fred/pull/755 > > # Remove potential attack-vector in pitch black mitigation (thanks to > nextgens!) > - randomize pitch black defense times: > https://github.com/freenet/fred/pull/747 > > # More robust friend-to-friend workflow: > - New peer via freenet uri: https://github.com/freenet/fred/pull/753 > - try replacing spaces by newlines in noderefs when parsing fails: > https://github.com/freenet/fred/pull/752 > > # Config-Optimizations: > - Increase default max threads to 1000: > https://github.com/freenet/fred/pull/757 > - increase default datastore size to 100GiB: > https://github.com/freenet/fred/pull/756 > > # Fix peer scaling (fast nodes needed more than their capacity from slow > nodes) > - fix peer scaling for very fast peers: > - https://github.com/freenet/fred/pull/749 > > # Add warning about voice-recognition being used for surveillance > - add voice recognition warning: https://github.com/freenet/fred/pull/750 > > # add support-code to make it easier for someone to take up the task to > fix the ogg vorbis filter > - add output of filtered file to the OggFilterTest: > https://github.com/freenet/fred/pull/748 > > # Polish: > - note effectively published field: https://github.com/freenet/fred/pull/754 > > > There are also related changes in java_installer and > wininstaller_innosetup. Please take a look at the commits! > > - https://github.com/freenet/java_installer/commits/next > - https://github.com/freenet/wininstaller-innosetup/commits/master > > > Best wishes, > Arne
Pull-requests in need of reviews
Hi, I created several small and self-contained pull-requests that need review. Please take a look so we can move forward with the next release! # Java 16 and 17 compat: - add required module opens for Java 17 to wrapper.conf: https://github.com/freenet/fred/pull/755 # Remove potential attack-vector in pitch black mitigation (thanks to nextgens!) - randomize pitch black defense times: https://github.com/freenet/fred/pull/747 # More robust friend-to-friend workflow: - New peer via freenet uri: https://github.com/freenet/fred/pull/753 - try replacing spaces by newlines in noderefs when parsing fails: https://github.com/freenet/fred/pull/752 # Config-Optimizations: - Increase default max threads to 1000: https://github.com/freenet/fred/pull/757 - increase default datastore size to 100GiB: https://github.com/freenet/fred/pull/756 # Fix peer scaling (fast nodes needed more than their capacity from slow nodes) - fix peer scaling for very fast peers: - https://github.com/freenet/fred/pull/749 # Add warning about voice-recognition being used for surveillance - add voice recognition warning: https://github.com/freenet/fred/pull/750 # add support-code to make it easier for someone to take up the task to fix the ogg vorbis filter - add output of filtered file to the OggFilterTest: https://github.com/freenet/fred/pull/748 # Polish: - note effectively published field: https://github.com/freenet/fred/pull/754 There are also related changes in java_installer and wininstaller_innosetup. Please take a look at the commits! - https://github.com/freenet/java_installer/commits/next - https://github.com/freenet/wininstaller-innosetup/commits/master Best wishes, Arne -- Unpolitisch sein heißt politisch sein, ohne es zu merken. draketo.de signature.asc Description: PGP signature
