I agree that does look for all the world like a missing negation in the opennet
case. Nice find! What looks like the previous implementation of that decision
which that commit replaces (in detectPrimaryIPAddress) appears to have no such
distinction, but looks questionable itself as well due to the duplicate
“dontDetect = true”s.
- Steve
Typed on a mobile keyboard
On Wed, Dec 12, 2018 at 12:12 PM, Martin Byrenheid
wrote:
> Hi,
>
> while reading the code on automatic IP detection, I noticed that the
> dontDetect-Method in the Node-class returns false if our Darknet IP is
> not a real internet address or if our Opennet IP IS a real Internet
> address. Shouldn't the detection actually be triggered if our Opennet IP
> is not a real internet address?
>
> I looked up the message for the commit when the dontDetect-Method was
> introduced[0] but did not find an explanation.
>
> Best regards,
> Martin
>
> [0]
> https://github.com/freenet/fred/commit/470552475ee10c8dd1482a916c6409b3feba39c5
>
> --
> Martin Byrenheid
> Scientific Assistant
>
> Technische Universität Dresden
> Faculty of Computer Science
> Institute of System Architecture
> Chair of Privacy and Data Security
> 01062 Dresden
>
> Tel.: +49 351 463 38235
> GPG : F144 FBCD F0C2 257A 87ED
> CFDE 24EB E684 D0BE E785
