Re: [freenet-dev] [freenet-cvs] r19693 - trunk/freenet/src/freenet/support/io

[Florent Daignière]

* Matthew Toseland <[EMAIL PROTECTED]> [2008-05-03 19:43:37]:

> On Saturday 03 May 2008 12:45, [EMAIL PROTECTED] wrote:
> > Author: nextgens
> > Date: 2008-05-03 11:45:09 + (Sat, 03 May 2008)
> > New Revision: 19693
> > 
> > Modified:
> >
> trunk/freenet/src/freenet/support/io/PaddedEphemerallyEncryptedBucket.java
> > Log:
> > Some paranoia (flush() before close() just in case a BufferedOutputStream 
> > is 
> catching exceptions)
> 
> Shouldn't you catch and log the exception from flush()?

I don't think so... If it throws it's fine by me


signature.asc
Description: Digital signature
___
Devl mailing list
Devl@freenetproject.org
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

Re: [freenet-dev] [freenet-cvs] r19693 - trunk/freenet/src/freenet/support/io

[Matthew Toseland]

On Saturday 03 May 2008 12:45, [EMAIL PROTECTED] wrote:
> Author: nextgens
> Date: 2008-05-03 11:45:09 + (Sat, 03 May 2008)
> New Revision: 19693
> 
> Modified:
>
trunk/freenet/src/freenet/support/io/PaddedEphemerallyEncryptedBucket.java
> Log:
> Some paranoia (flush() before close() just in case a BufferedOutputStream is 
catching exceptions)

Shouldn't you catch and log the exception from flush()?
> 
> Modified: 
trunk/freenet/src/freenet/support/io/PaddedEphemerallyEncryptedBucket.java
> ===
> --- 
trunk/freenet/src/freenet/support/io/PaddedEphemerallyEncryptedBucket.java  
2008-05-03 11:25:50 UTC (rev 19692)
> +++ 
trunk/freenet/src/freenet/support/io/PaddedEphemerallyEncryptedBucket.java  
2008-05-03 11:45:09 UTC (rev 19693)
> @@ -194,6 +194,7 @@
>   }
>   } finally {
>   closed = true;
> + out.flush();
>   out.close();
>   }
>   }
> 
> ___
> cvs mailing list
> [EMAIL PROTECTED]
> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/cvs
> 
> 


pgpk6iCoKxShS.pgp
Description: PGP signature
___
Devl mailing list
Devl@freenetproject.org
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl