Re: Remaining reviews needed to release Freenet 1495
Agreed! A decade ago when IPv6 stacks were liable to be buggy, it was understandable, but by now enabling it by default seems more than reasonable. On Tue, Dec 6, 2022 at 9:42 AM, s7r wrote: > Dr. Arne Babenhauserheide wrote: >> Hi, >> >> >> We’re getting ever closer to release. I merged the already reviewed >> pull-requests, but some important PRs remain so we can release. Please >> help getting these reviewed! >> > > Thanks for the work! > > I would like to propose we change something that has been bothering me > for years, and I have extensively tested it under Debian, FreeBSD and > Windows during the last 4 Freenet releases and it does not cause any > problems at all if we change it the way I suggest. > > In the default wrapper.conf file we ship with Freenet, there is this > over a decade config line: > > # Needed for some linux distros? Shouldn't prevent using IPv6, just make > it prefer IPv4? > wrapper.java.additional.3=-Djava.net.preferIPv4Stack=true > > The thing is, it actually really prevents you from using IPv6! At least > on Debian, Windows and FreeBSD (I am confident on every OS this is the > case, because it's a Java thing more than an OS thing). > > With these lines in wrapper.conf we have the following problems: > > - node does not bind to IPv6 interfaces, only bind to IPv4 available > addresses for both opennet and darknet; > > - It also does not connect to any IPv6 peers. If you remove it, even if > node bind to and node opennet bind to is set to the `default` 0.0.0.0, > it properly binds to *all* interfaces (IPv6 and IPv4). > > - it doesn't open the localhost FProxy except on 127.0.0.1, regardless > the freenet.ini setting is to also bind to 0:0:0:0:0:0:0:1 -- with that > line removed, FProxy successfully finds to 127.0.0.1 and [::1]. > > *So there are no additional settings to do to make sure all goes well > except as remove these two lines from wrapper.conf.* > > We should remove it entirely or comment it out, and also make sure it > overwrites the `wrapper.conf` on disk for users that already have > freenet installed and are upgrading automatically. > > This will add better IPv6 support, more reachable nodes in the Freenet > network (IPv6 and NAT is much rarely used together) and it makes sense > to do it finally, after 25 years since the IPv6 RFC :) > > I'll do a PR to update the seednodes for better bootstrap support to new > connecting users, hopefully the windows installer will take them on in > time. Monitoring service is running here: > > https://freenet.dotbit.zone/
Re: Remaining reviews needed to release Freenet 1495
Dr. Arne Babenhauserheide wrote: Hi, We’re getting ever closer to release. I merged the already reviewed pull-requests, but some important PRs remain so we can release. Please help getting these reviewed! Thanks for the work! I would like to propose we change something that has been bothering me for years, and I have extensively tested it under Debian, FreeBSD and Windows during the last 4 Freenet releases and it does not cause any problems at all if we change it the way I suggest. In the default wrapper.conf file we ship with Freenet, there is this over a decade config line: # Needed for some linux distros? Shouldn't prevent using IPv6, just make it prefer IPv4? wrapper.java.additional.3=-Djava.net.preferIPv4Stack=true The thing is, it actually really prevents you from using IPv6! At least on Debian, Windows and FreeBSD (I am confident on every OS this is the case, because it's a Java thing more than an OS thing). With these lines in wrapper.conf we have the following problems: - node does not bind to IPv6 interfaces, only bind to IPv4 available addresses for both opennet and darknet; - It also does not connect to any IPv6 peers. If you remove it, even if node bind to and node opennet bind to is set to the `default` 0.0.0.0, it properly binds to *all* interfaces (IPv6 and IPv4). - it doesn't open the localhost FProxy except on 127.0.0.1, regardless the freenet.ini setting is to also bind to 0:0:0:0:0:0:0:1 -- with that line removed, FProxy successfully finds to 127.0.0.1 and [::1]. *So there are no additional settings to do to make sure all goes well except as remove these two lines from wrapper.conf.* We should remove it entirely or comment it out, and also make sure it overwrites the `wrapper.conf` on disk for users that already have freenet installed and are upgrading automatically. This will add better IPv6 support, more reachable nodes in the Freenet network (IPv6 and NAT is much rarely used together) and it makes sense to do it finally, after 25 years since the IPv6 RFC :) I'll do a PR to update the seednodes for better bootstrap support to new connecting users, hopefully the windows installer will take them on in time. Monitoring service is running here: https://freenet.dotbit.zone/ OpenPGP_signature Description: OpenPGP digital signature
Remaining reviews needed to release Freenet 1495
Hi, We’re getting ever closer to release. I merged the already reviewed pull-requests, but some important PRs remain so we can release. Please help getting these reviewed! Small or simple reviews: - only include the inline m3u player if the page contains media-tags https://github.com/freenet/fred/pull/802 - bookmarks: add infocalypse and pyFreenet sharesite https://github.com/freenet/fred/pull/801 - add sky-dark-static theme by CometZ@6DtYG~ https://github.com/freenet/fred/pull/796 - m3u-player: skip tracks that fail. https://github.com/freenet/fred/pull/795 - Client getter honor max size argument https://github.com/freenet/fred/pull/794 More complex review: - Redesign firsttime wizard (updating the PR from redwerk) https://github.com/freenet/fred/pull/790 (this needs review of the changes I added to ship the needed dependencies) Once the pull-requests above are reviewed, we can finally release 1495 with pretty cool improvements: - new firsttime wizard (single-step joining with clearer defaults) - Add web+freenet and ext+freenet as supported schemas to support extensions. Thanks to TheSeeker - healing size increased (better lifetime for popular files) - CSS: enable sticky — thanks to Spider Admin - CSS: enable transition and word-wrap — thanks to naejadu, thanks to vwoodzell for the review! - Eleriseth pending keys merged (performance) - re-organize default bookmarks: first section has "starting points", thanks to vwoodzell for the review! - new theme: sky-dark-static - m3u-player: only inline the m3u player if the page contains media tags - m3u-player: skip broken files - Client getter honor max size argument - finally merged the HashingAPI by unixninja92, a GSoC project that had gotten lost in the pull requests. This provides an easy and well-tested way to create and verify different types of Hashes from byte arrays, including Sha256 and TigerTree. https://github.com/freenet/fred/pull/258 - upgrade unit tests to junit4, thanks to vwoodzell! - old announcement fixes by toad finally merged The following PR does not block the release, because it needs conceptual review to ensure that we won’t get problems when deploying in a large network, and that we don’t make it easier to observe behavior. The existing logic seems to be problematic, but it does not break down completely, and this is a pretty sensitive area: - Trivuele batch 2: RequestStarter simplification and fixes https://github.com/freenet/fred/pull/777 (it would be good to have more comments in this which explain the logic. There is somewhat detailed documentation in the commit message: https://github.com/freenet/fred/pull/777/commits/984ad3f81a4374a8fe2d55cdec21ba92ab990082 ) Finally, this is one of the two remaining release blockers: - Create initial Github CI flow https://github.com/freenet/fred/pull/775 (this needs review to ensure that it cannot spill deployment or account information) And if you want to help DC* finish the Debian package (to get to the point where people can just apt install freenet), please have a look at - Debian Package Continuation https://github.com/freenet/fred/pull/774 Best wishes, Arne We need people to check the pull-requests. I’m not merging anything into fred (=autoupdate) not seen by at least 2 people (author + reviewer) to ensure that if I merged something without review this would raise red flags and get many people to check that. That protects Freenet against being corrupted by putting pressure on me (or any other release-manager). So if you can make some time, please have a look at one of the pull requests that is not yet marked as readyToBeMerged: https://github.com/freenet/fred/pulls Thank you for your interest in Freenet! Best wishes, Arne -- What is Freenet? Freenet is a peer-to-peer platform for censorship-resistant and privacy-respecting publishing and communication. I worry about my child and the Internet all the time, even though she's too young to have logged on yet. Here's what I worry about. I worry that 10 or 15 years from now, she will come to me and say 'Daddy, where were you when they took freedom of the press away from the Internet? --Mike Godwin, Electronic Frontier Foundation That Freenet can keep moving forward and help people worldwide to exercise their basic rights and freedoms is the work of amazing volunteers, both contributors and people running Freenet nodes. See https://freenetproject.org signature.asc Description: PGP signature
