Re: [xwiki-devs] [Proposal] Get rid of Activity Stream and the Watchlist

2019-02-05 Thread Guillaume Delhumeau
Le mar. 5 févr. 2019 à 11:33, Vincent Massol  a écrit :

> Hi Guillaume,
>
> > On 4 Feb 2019, at 12:50, Guillaume Delhumeau <
> guillaume.delhum...@xwiki.com> wrote:
> >
> > Dear developers,
> >
> > Now that we consider notifications as an achieved replacement for both
> > Activity Stream and the Watchlist, I propose to stop maintaining them and
> > to move them into the "attic" section.
>
> +1
>
> > You need to know that we had a dependency on the Activity Stream API, as
> > the only implementation of the Event Stream, on which the Notifications
> are
> > based. So to get rid of this dependency (the code is not using our
> > component system and is not well tested), I have written a new
> > implementation of the Event Stream that I have called "Event Stream
> Store".
> > It's fully backward compatible with the old implementation, since it is
> > using the same Database schema. In practice, I re-used some pieces of
> > Activity Stream that I have modified to fit into components. For more
> > information, see: https://jira.xwiki.org/browse/XWIKI-16052
> >
> > So my proposal is this one:
> > - use the new store in 11.1
>
> Already in action! +1
>
> > - stop bundle Watchlist and AS in 11.1
>
> +1
>
> > - move Watchlist and AS into "attic" in 11.2
>
> IMO this could be done in 11.1 too since if we stop bundling Watchlist/AS
> then we don’t need to keep the modules in platform.
>

I wanted to release a new "official" version of AS before moving it to
attic, because I made a few changes on it (like moving some components that
had nothing to do in AS).


>
> Thanks
> -Vincent
>
> >
> > Thanks you,
> >
> > --
> > Guillaume Delhumeau (guillaume.delhum...@xwiki.com)
> > Research & Development Engineer at XWiki SAS
> > Committer on the XWiki.org project
>
>

-- 
Guillaume Delhumeau (guillaume.delhum...@xwiki.com)
Research & Development Engineer at XWiki SAS
Committer on the XWiki.org project


Re: [xwiki-devs] [Proposal] Get rid of Activity Stream and the Watchlist

2019-02-05 Thread Vincent Massol
Hi Guillaume,

> On 4 Feb 2019, at 12:50, Guillaume Delhumeau  
> wrote:
> 
> Dear developers,
> 
> Now that we consider notifications as an achieved replacement for both
> Activity Stream and the Watchlist, I propose to stop maintaining them and
> to move them into the "attic" section.

+1

> You need to know that we had a dependency on the Activity Stream API, as
> the only implementation of the Event Stream, on which the Notifications are
> based. So to get rid of this dependency (the code is not using our
> component system and is not well tested), I have written a new
> implementation of the Event Stream that I have called "Event Stream Store".
> It's fully backward compatible with the old implementation, since it is
> using the same Database schema. In practice, I re-used some pieces of
> Activity Stream that I have modified to fit into components. For more
> information, see: https://jira.xwiki.org/browse/XWIKI-16052
> 
> So my proposal is this one:
> - use the new store in 11.1

Already in action! +1

> - stop bundle Watchlist and AS in 11.1

+1

> - move Watchlist and AS into "attic" in 11.2

IMO this could be done in 11.1 too since if we stop bundling Watchlist/AS then 
we don’t need to keep the modules in platform.

Thanks
-Vincent

> 
> Thanks you,
> 
> -- 
> Guillaume Delhumeau (guillaume.delhum...@xwiki.com)
> Research & Development Engineer at XWiki SAS
> Committer on the XWiki.org project