[Issue 19280] Remove unnecessary error checks in core.time.currSystemTick and currTime

2018-10-13 Thread d-bugmail--- via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=19280

--- Comment #3 from github-bugzi...@puremagic.com ---
Commits pushed to master at https://github.com/dlang/druntime

https://github.com/dlang/druntime/commit/8759cb6a19e692b7599a7da80fab2654af568558
Fix Issue 19280 - Remove unnecessary error checks in core.time, Part 2

clock_gettime called with a valid clock_id and a valid timespec address
is in principle allowed to fail if the number of seconds doesn't fit in
time_t. If time_t is long or ulong we don't need to check for this
since the current time won't overflow before 292 billion years A.D.

This PR also extends PR #2315's improments currSystemTick to also apply
to currTime.

https://github.com/dlang/druntime/commit/651931122f8c72945f43118bfb03f08a8982437f
Merge pull request #2317 from n8sh/issue-19280-pt2

Fix Issue 19280 - Remove unnecessary error checks in core.time, Part 2
merged-on-behalf-of: Jonathan M Davis 

--


[Issue 19292] Mixin expressions should take an argument list the same as pragma(msg) does

2018-10-13 Thread d-bugmail--- via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=19292

--- Comment #8 from github-bugzi...@puremagic.com ---
Commit pushed to master at https://github.com/dlang/dlang.org

https://github.com/dlang/dlang.org/commit/2b1e8ce197ad2f0adb7454b270a811ea41f0942b
Merge pull request #2485 from WalterBright/mixin-args

fix Issue 19292 - Mixin expressions should take an argument list

--


[Issue 13825] relativePath not handling "." and ".." correctly

2018-10-13 Thread d-bugmail--- via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=13825

dechcaudron+dlang.issue.track...@protonmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||dechcaudron+dlang.issue.tra
   ||ck...@protonmail.com

--- Comment #2 from dechcaudron+dlang.issue.track...@protonmail.com ---
Hi Thibaut,

I'm taking this one. The same behavior is exhibited on the range returned by
"asRelativePath". At a first glance, the proposed fix will indeed be to indeed
call "buildNormalizedPath" on each of the arguments, but I need to look into
memory allocation considerations.

Regarding your last comment:
> but there is still an issue if the first path starts with "../"

Even though the docs do not explicitly mention so, I believe the first argument
is expected to be an absolute path (otherwise, you would be changing an
out-of-context relative path into another relative path, which looks like a bad
idea to me). Perhaps it would be a good idea to add a contract on both
parameters (but that is a breaking change that I assume would require a
deprecation period, let's see what the maintainers say). Thus, a first argument
that starts with ".." would fall out of this category.

Regards,
Dechcaudron

--


[Issue 13763] std.string.representation of immutables

2018-10-13 Thread d-bugmail--- via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=13763

dechcaudron+dlang.issue.track...@protonmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||dechcaudron+dlang.issue.tra
   ||ck...@protonmail.com
 Resolution|--- |FIXED

--- Comment #1 from dechcaudron+dlang.issue.track...@protonmail.com ---
As in DMD v2.082.1, this compiles and executes as expected. Example code:

void main() {
import std.string: representation;
import std.stdio;

enum Enum : char { A = 'a', B='b', C='c'}

const Enum[] a1 = [Enum.A, Enum.B];
writeln(a1.representation); // [97, 98]

immutable Enum[] a2 = [Enum.A, Enum.C];
writeln(a2.representation); // [97, 99]
}

I am unsure as to whether this was "accidentally" fixed as part of the regular
evolution of Phobos or was reported in a duplicate issue in fixed as a response
to such. Either way, that's one issue less.

--


[Issue 19292] Mixin expressions should take an argument list the same as pragma(msg) does

2018-10-13 Thread d-bugmail--- via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=19292

--- Comment #7 from github-bugzi...@puremagic.com ---
Commits pushed to master at https://github.com/dlang/dmd

https://github.com/dlang/dmd/commit/51b5d2197721d8d5c3f8057da4c28ffa861bcab6
fix Issue 19292 part 3 - Mixin Declarations

https://github.com/dlang/dmd/commit/4ecb04ba590f543927365d53d2e1d274b9333e4d
Merge pull request #8813 from WalterBright/fix19292-3

fix Issue 19292 part 3 - Mixin Declarations

--