[Issue 13632] Second argument for std.string.strip

2018-01-31 Thread d-bugmail--- via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=13632

--- Comment #3 from github-bugzi...@puremagic.com ---
Commits pushed to master at https://github.com/dlang/phobos

https://github.com/dlang/phobos/commit/2346990c091e68d0b07ed2fbd41dd865a3251713
Fix issue 13632: Enhancement to std.string.strip

Added second argument similar to Python `str.strip`

Second argument accepts a string of characters to strip and
strips only those characters.

Examples:

"xyzhello".stripLeft("xyz") == "hello"
"helloxy ".stripRight("xy ") == "hello"
"xhellox".strip("x") == "hello"

Signed-off-by: Aravinda VK 

https://github.com/dlang/phobos/commit/8d93656917bb0f301ed07fe9de773f7484987361
Merge pull request #6023 from aravindavk/string_strip_enhancement

Fix issue 13632: Enhancement to std.string.strip
merged-on-behalf-of: unknown

--


[Issue 13632] Second argument for std.string.strip

2018-01-31 Thread d-bugmail--- via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=13632

github-bugzi...@puremagic.com changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--


[Issue 13632] Second argument for std.string.strip

2018-01-10 Thread d-bugmail--- via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=13632

--- Comment #2 from Aravinda  ---
(In reply to Seb from comment #1)
> @Aravinda VK: thanks a lot for taking this. Please don't forget to add a
> link to your PR here. Otherwise people in the future will have a hard time
> finding or even being aware of it:
> 
> https://github.com/dlang/phobos/pull/6023

Noted. This is my first patch/bug in D lang community. I will make sure to add
PR link in future. Thanks.

--


[Issue 13632] Second argument for std.string.strip

2018-01-10 Thread d-bugmail--- via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=13632

Seb  changed:

   What|Removed |Added

   Keywords||pull
 CC||greensunn...@gmail.com

--- Comment #1 from Seb  ---
@Aravinda VK: thanks a lot for taking this. Please don't forget to add a link
to your PR here. Otherwise people in the future will have a hard time finding
or even being aware of it:

https://github.com/dlang/phobos/pull/6023

--


[Issue 13632] Second argument for std.string.strip

2018-01-10 Thread d-bugmail--- via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=13632

Aravinda  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||hallimanearav...@gmail.com
   Assignee|nob...@puremagic.com|hallimanearav...@gmail.com

--