[Issue 14877] std.net.curl needs PATCH http method

2015-08-06 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=14877

Martin Nowak  changed:

   What|Removed |Added

 CC||c...@dawg.eu

--- Comment #1 from Martin Nowak  ---
Would be as simple as adding an enum member to
http://dlang.org/phobos/std_net_curl.html#.HTTP.Method and setting the
customrequest option.

http://stackoverflow.com/questions/14451401/how-do-i-make-a-patch-request-in-php-using-curl

Mind to put up a PR?

--


[Issue 14877] std.net.curl needs PATCH http method

2015-08-07 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=14877

--- Comment #2 from Andrea Fontana  ---
I'm not sure that's enough. If you search for "method.put" inside source, you
see there's a lot of conditions. I think patch is similar to put, but I'm not
sure which check are needed to make it work fine.

--


[Issue 14877] std.net.curl needs PATCH http method

2015-08-07 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=14877

Martin Nowak  changed:

   What|Removed |Added

   Keywords||pull

--- Comment #3 from Martin Nowak  ---
Sorry for the horrible API btw.
https://github.com/D-Programming-Language/phobos/pull/3533

--


[Issue 14877] std.net.curl needs PATCH http method

2015-08-23 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=14877

--- Comment #4 from github-bugzi...@puremagic.com ---
Commits pushed to master at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/ceb29a91c0c4afd3b502ab3c0e163b1fd27b4d39
fix Issue 14877 - std.net.curl needs PATCH http method

- use infilesize for anything but post requests
  though apparently curl can use both for non-POST
  methods

https://github.com/D-Programming-Language/phobos/commit/6273768859c8c8964adf98f2dd40f0baf6c783b6
Merge pull request #3533 from MartinNowak/fix14877

fix Issue 14877 - std.net.curl needs PATCH http method

--


[Issue 14877] std.net.curl needs PATCH http method

2015-09-09 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=14877

badlink  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||andrea.9...@gmail.com
 Resolution|FIXED   |---

--- Comment #5 from badlink  ---
The current version in phobos of std.net.curl.patch does not upload any data in
the http request.

Small testcase: http://pastebin.com/UujEqh4K
Expected: the data field in the response should not be empty

-

Workaround: change the switch case in std.net.curl.HTTP.perform:

[...]
case Method.patch:
p.curl.set(CurlOption.customrequest, "PATCH");
p.curl.set(CurlOption.upload, 1L); // add this line
opt = CurlOption.customrequest;
break;
[...]

Note: probably this workaround does not leave a clean state.

--


[Issue 14877] std.net.curl needs PATCH http method

2015-10-04 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=14877

--- Comment #6 from github-bugzi...@puremagic.com ---
Commits pushed to stable at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/ceb29a91c0c4afd3b502ab3c0e163b1fd27b4d39
fix Issue 14877 - std.net.curl needs PATCH http method

https://github.com/D-Programming-Language/phobos/commit/6273768859c8c8964adf98f2dd40f0baf6c783b6
Merge pull request #3533 from MartinNowak/fix14877

--


[Issue 14877] std.net.curl needs PATCH http method

2015-10-04 Thread via Digitalmars-d-bugs
https://issues.dlang.org/show_bug.cgi?id=14877

github-bugzi...@puremagic.com changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--