[Issue 16208] moduleinfo importedModules contains needless duplicates

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=16208

Steven Schveighoffer  changed:

   What|Removed |Added

   See Also||https://issues.dlang.org/sh
   ||ow_bug.cgi?id=20177

--

[Issue 16208] moduleinfo importedModules contains needless duplicates

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=16208

--- Comment #6 from Steven Schveighoffer  ---
Excellent! Thank you Rainer. It's possible we can clean the cycle detection
code a bit now that we don't have this problem (I believe I am using a hash at
runtime to deduplicate).

--

[Issue 16208] moduleinfo importedModules contains needless duplicates

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=16208

Rainer Schuetze  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||r.sagita...@gmx.de
 Resolution|--- |DUPLICATE

--- Comment #5 from Rainer Schuetze  ---
Stumbled over it recently, too: https://issues.dlang.org/show_bug.cgi?id=20037
and fixed it: https://github.com/dlang/dmd/pull/10154

*** This issue has been marked as a duplicate of issue 20037 ***

--

[Issue 16208] moduleinfo importedModules contains needless duplicates

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=16208

--- Comment #4 from Steven Schveighoffer  ---
For archive purposes, on my system, that program prints:

In module testcycle we import:
In module core.bitop we import:
core.cpuid
core.cpuid
In module core.cpuid we import:
In module core.exception we import:
In module core.runtime we import:
In module core.thread we import:
core.time
In module core.time we import:
In module core.internal.spinlock we import:
core.thread
In module gc.config we import:
In module gc.gcinterface we import:
In module gc.proxy we import:
gc.impl.conservative.gc
core.internal.spinlock
In module gc.impl.conservative.gc we import:
core.bitop
core.thread
core.time
core.internal.spinlock
core.internal.spinlock
In module rt.critical_ we import:
In module rt.deh_win64_posix we import:
In module rt.dmain2 we import:
In module rt.lifetime we import:
rt.tlsgc
core.bitop
In module rt.minfo we import:
core.bitop
core.bitop
core.bitop
In module rt.monitor_ we import:
In module rt.sections_osx_x86_64 we import:
rt.minfo
In module rt.tlsgc we import:
rt.lifetime

--

[Issue 16208] moduleinfo importedModules contains needless duplicates

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=16208

--- Comment #3 from Steven Schveighoffer  ---
Hm... any program has this problem.

Example:

import std.stdio;

void main()
{
foreach(mi; ModuleInfo)
{
writeln("In module ", mi.name, " we import:");
foreach(imported; mi.importedModules)
writeln(imported.name);
}
}

--

[Issue 16208] moduleinfo importedModules contains needless duplicates

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=16208

Mike Franklin  changed:

   What|Removed |Added

 CC||slavo5...@yahoo.com

--- Comment #2 from Mike Franklin  ---
Can you create a test case that demonstrates this problem?

--

[Issue 16208] moduleinfo importedModules contains needless duplicates

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=16208

--- Comment #1 from github-bugzi...@puremagic.com ---
Commits pushed to master at https://github.com/dlang/dmd

https://github.com/dlang/dmd/commit/b60b669b4d92398f0fb770b895c2835a71c54e3f
[Refactorization] Issue 16208 - curly braces on newlines

https://github.com/dlang/dmd/commit/6d76646aaca6ccc8d633fea899a1e81b84e20533
Merge pull request #8311 from RazvanN7/Followup_16206

[Refactorization] Issue 16208 - curly braces on new lines

--

[Issue 16208] moduleinfo importedModules contains needless duplicates

[via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=16208

ZombineDev  changed:

   What|Removed |Added

 CC||petar.p.ki...@gmail.com

--

[Issue 16208] moduleinfo importedModules contains needless duplicates

[via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=16208

Ketmar Dark  changed:

   What|Removed |Added

 CC||ket...@ketmar.no-ip.org

--