[Issue 17764] [scope][DIP1000] Escape checker defeated by composition transformations
https://issues.dlang.org/show_bug.cgi?id=17764 Walter Bright changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |WORKSFORME --- Comment #8 from Walter Bright --- (In reply to ag0aep6g from comment #4) > global = c[0].str; /* This should be rejected. */ And it is now in master: Error: scope variable `c` assigned to non-scope `global` --
[Issue 17764] [scope][DIP1000] Escape checker defeated by composition transformations
https://issues.dlang.org/show_bug.cgi?id=17764 --- Comment #7 from Walter Bright --- Declaring c as: S c = S(); does cause it to be inferred to be `scope`, and the next line is then correctly diagnosed. So, the trouble is the scope inference should be looking at the elements of the static array, but is not. --
[Issue 17764] [scope][DIP1000] Escape checker defeated by composition transformations
https://issues.dlang.org/show_bug.cgi?id=17764 --- Comment #6 from Walter Bright --- The `c` should be inferred as `scope`. --
[Issue 17764] [scope][DIP1000] Escape checker defeated by composition transformations
https://issues.dlang.org/show_bug.cgi?id=17764 --- Comment #5 from Walter Bright --- A simpler version that should fail to compile: int** global; struct S { int** str; } void f() @safe { int* buf; S[1] c = S(); global = c[0].str; /* This should be rejected. */ } --
[Issue 17764] [scope][DIP1000] Escape checker defeated by composition transformations
https://issues.dlang.org/show_bug.cgi?id=17764 Walter Bright changed: What|Removed |Added See Also||https://issues.dlang.org/sh ||ow_bug.cgi?id=20505 --
[Issue 17764] [scope][DIP1000] Escape checker defeated by composition transformations
https://issues.dlang.org/show_bug.cgi?id=17764 ag0aep6g changed: What|Removed |Added Status|RESOLVED|REOPENED CC||ag0ae...@gmail.com Resolution|INVALID |--- --- Comment #4 from ag0aep6g --- (In reply to Walter Bright from comment #3) > All of them are instances of transitive scope, but scope is not transitive. > Not compiler bugs. Reopening. I don't know if this report shows a problem with `scope` in particular, but it does show holes in @safe. We can't have a global that points to stack memory in @safe code. If @safe works as designed here, you need to revisit the design, because it's insufficient. Here's a single example based on use0x5, modified to show more blatantly that safety is violated: int** global; immutable int imm; static this() { imm = 42; } void main() @safe { f(); /* `global` now points to the stack. Uh-oh. */ stomp(); /* `*global` now points to `imm`. */ **global = 13; /* Overwrites `imm`. */ assert(imm == 42); /* Fails. We've (accidentally) mutated an immutable int. */ } void f() @safe { int* buf; static struct Context0x0 { int** str; } Context0x0[1] c = Context0x0(); global = c[0].str; /* This should be rejected. */ } void stomp() @safe { immutable int*[4] x = } Some of the other variations also seem to boil down to this. Maybe all of them do. --
[Issue 17764] [scope][DIP1000] Escape checker defeated by composition transformations
https://issues.dlang.org/show_bug.cgi?id=17764 Walter Brightchanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #3 from Walter Bright --- The following remain: --- @safe: struct Context0x0 { char[] str; } struct Parent0x1 { Context0x0 c; } struct Parent0x2 { Context0x0[1] csa; } struct Parent0x3 { Context0x0[] csl; } struct Parent0x4 { Context0x0*cp; } struct Parent0x5 { Parent0x1 p1; } struct Parent0x6 { Parent0x5 p5; } struct Parent0x7 { Parent0x6 p6; } struct Parent0x8 { Parent0x2[1]* p2; } struct Parent0x9 { Parent0x8[1] p8; } struct Parent0xA { Parent0x9[1] p9; } struct Parent0xB { Parent0x4* p4; } struct Parent0xC { Parent0xB* pb; } struct Parent0xD { Parent0xC* pc; } char[] global; void use0x2(scope char[]* arr) { global = *arr; // NG - accepts invalid } void use0x9(scope ref Parent0x4 p) { global = p.cp.str; // NG - accepts invalid } void use0xB(scope ref Parent0xA p) { global = (*p.p9[0].p8[0].p2)[0].csa[0].str; // NG - accepts invalid } void use0xC(scope ref Parent0xD p) { global = p.pc.pb.p4.cp.str; // NG - accepts invalid } --- All of them are instances of transitive scope, but scope is not transitive. Not compiler bugs. --
[Issue 17764] [scope][DIP1000] Escape checker defeated by composition transformations
https://issues.dlang.org/show_bug.cgi?id=17764 Carsten Blüggelchanged: What|Removed |Added CC||chi...@posteo.net --
[Issue 17764] [scope][DIP1000] Escape checker defeated by composition transformations
https://issues.dlang.org/show_bug.cgi?id=17764 Walter Brightchanged: What|Removed |Added CC||bugzi...@digitalmars.com --- Comment #2 from Walter Bright --- Starting with this one: > void use0x2(scope char[]* arr) > { > global = *arr; // NG - accepts invalid > } `scope` is not transitive. It applies to the 'head' only. `*arr` is no longer the head, and `scope` doesn't apply to it. A casual look at the rest of the cases shows similar. If you would please filter out all the cases of more than one indirection, I can look at the rest. --
[Issue 17764] [scope][DIP1000] Escape checker defeated by composition transformations
https://issues.dlang.org/show_bug.cgi?id=17764 ZombineDevchanged: What|Removed |Added Keywords||accepts-invalid, ||rejects-valid, safe --- Comment #1 from ZombineDev --- Typo: the last lines were meant to be: $ dmd -dip1000 scope_bug2.d $ echo $? 0 $ dmd --version DMD64 D Compiler v2.076.0-b1-master-32bb4ed --