[Issue 18880] [REG2.079] Miscompilation of unittests when two are mixed-in on one line

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=18880

johanenge...@weka.io changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from johanenge...@weka.io ---
Yes, fixed by https://github.com/dlang/dmd/pull/8255 which adds a regression
test for this bug.

--

[Issue 18880] [REG2.079] Miscompilation of unittests when two are mixed-in on one line

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=18880

Walter Bright  changed:

   What|Removed |Added

 CC||bugzi...@digitalmars.com

--- Comment #4 from Walter Bright  ---
(In reply to johanengelen from comment #3)
> https://github.com/dlang/dmd/pull/8255

This was merged. Does it fix the issue?

--

[Issue 18880] [REG2.079] Miscompilation of unittests when two are mixed-in on one line

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=18880

--- Comment #3 from johanenge...@weka.io ---
https://github.com/dlang/dmd/pull/8255

--

[Issue 18880] [REG2.079] Miscompilation of unittests when two are mixed-in on one line

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=18880

--- Comment #2 from johanenge...@weka.io ---
Things are worse:

```
static foreach(s; ["666", "777"]) {
mixin(genTest(s));
}

int i;

string genTest(string a)
{
return "unittest { i += " ~ a ~ "; }";
}

void main()
{
assert(i == 0 + 666 + 666);
}
```

Thus: the exact source location is not necessarily unique and so an extra
uniqueness factor is needed to generate the unittest function names. (note:
must still be deterministic across separate compilations!)

--

[Issue 18880] [REG2.079] Miscompilation of unittests when two are mixed-in on one line

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=18880

--- Comment #1 from johanenge...@weka.io ---
Related issue discussing the mixin linecount problem:
https://issues.dlang.org/show_bug.cgi?id=2887

--

[Issue 18880] [REG2.079] Miscompilation of unittests when two are mixed-in on one line

[d-bugmail--- via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=18880

johanenge...@weka.io changed:

   What|Removed |Added

   Hardware|x86 |All
 OS|Mac OS X|All
   Severity|enhancement |regression

--