[Issue 5145] Regression(2.050, 1.065) override error with forward ref of superclass

[via Digitalmars-d-bugs]

https://issues.dlang.org/show_bug.cgi?id=5145

Andrei Alexandrescu  changed:

   What|Removed |Added

Version|D1 & D2 |D2

--

[Issue 5145] Regression(2.050, 1.065) override error with forward ref of superclass

[d-bugmail]

http://d.puremagic.com/issues/show_bug.cgi?id=5145


Walter Bright  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED


--- Comment #5 from Walter Bright  2010-12-05 
16:31:14 PST ---
http://www.dsource.org/projects/dmd/changeset/782

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
--- You are receiving this mail because: ---

[Issue 5145] Regression(2.050, 1.065) override error with forward ref of superclass

[d-bugmail]

http://d.puremagic.com/issues/show_bug.cgi?id=5145


Walter Bright  changed:

   What|Removed |Added

 CC||bugzi...@digitalmars.com


--- Comment #4 from Walter Bright  2010-12-05 
12:58:27 PST ---
(In reply to comment #2)
> This seems very similar to bug 5110, which is more general. Need to check if
> the patch for 5110 fixes this bug as well.

Nope, different problem.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
--- You are receiving this mail because: ---

[Issue 5145] Regression(2.050, 1.065) override error with forward ref of superclass

[d-bugmail]

http://d.puremagic.com/issues/show_bug.cgi?id=5145


Don  changed:

   What|Removed |Added

 CC||bary...@smp.if.uj.edu.pl


--- Comment #3 from Don  2010-11-22 07:01:01 PST ---
*** Issue 5253 has been marked as a duplicate of this issue. ***

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
--- You are receiving this mail because: ---

[Issue 5145] Regression(2.050, 1.065) override error with forward ref of superclass

[d-bugmail]

http://d.puremagic.com/issues/show_bug.cgi?id=5145



--- Comment #2 from Don  2010-11-01 01:51:34 PDT ---
This seems very similar to bug 5110, which is more general. Need to check if
the patch for 5110 fixes this bug as well.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
--- You are receiving this mail because: ---

[Issue 5145] Regression(2.050, 1.065) override error with forward ref of superclass

[d-bugmail]

http://d.puremagic.com/issues/show_bug.cgi?id=5145


Don  changed:

   What|Removed |Added

   Keywords||patch, rejects-valid
 CC||clugd...@yahoo.com.au
Version|D1  |D1 & D2
Summary|override error with forward |Regression(2.050, 1.065)
   |ref of superclass   |override error with forward
   ||ref of superclass
 OS/Version|Mac OS X|All


--- Comment #1 from Don  2010-11-01 01:01:43 PDT ---
Applies to both D1 and D2.

This was caused by svn683, which fixed bug 3602 "ICE(tocsym.c) compiling a
class, if its super class has preconditions"

And the problem is that it's using the scope from the parent function, which
isn't quite right: some of the attributes should be dropped. I don't know if
anything other than STCoverride can cause problems.


func.c, FuncDeclaration::mergeFrequire, line 1688.

FuncDeclaration *fdv = (FuncDeclaration *)foverrides.data[i];

/* The semantic pass on the contracts of the overridden functions must
 * be completed before code generation occurs (bug 3602).
 */
if (fdv->fdrequire && fdv->fdrequire->semanticRun != PASSsemantic3done)
{
assert(fdv->scope);
+StorageClass oldstc = fdv->scope->stc;
+fdv->scope->stc &= ~ STCoverride;
fdv->semantic3(fdv->scope);
+fdv->scope->stc = fdv->scope->stc;
}

sf = fdv->mergeFrequire(sf);
if (fdv->fdrequire)

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
--- You are receiving this mail because: ---