Re: reminder: review of maintainer-tools patches is mandatory
On Wed, 13 Jan 2021, Daniel Vetter wrote: > On Wed, Jan 13, 2021 at 3:21 PM Jani Nikula wrote: >> On Wed, 13 Jan 2021, Sumit Semwal wrote: >> > Hi Jani, >> > >> > Apologies on this - I understand the review part as well, you're right. >> > >> > Just to give you context: This patch was a quick response to Daniel's ask >> > to update the documentation over IRC. I didn't know the process for this, >> > and assuming gitlab, created a PR. By the time I could offer Daniel to send >> > a patch, he had merged the PR. >> > >> > Irrespective, I will take care going forward. Apologies again. >> >> Oh, okay, don't worry about it. Daniel merging the PR is certainly >> enough of an ack here. The problem is that in git logs you appeared to >> be the committer and Daniel's involvement was completely lost, and >> that's what I was going by. > > Yeah with proper MR flow we'd have marge set up (to do the MR merging > for us, it's a bot), which adds a Part-of: tag to each commit it > pushes through an MR, so you can go back to the MR link and see all > the discussion. There's an r-b: tag from me there. I think we should > either set that up or disable MR since it's confusing. I think as a project maintainer-tools is now so detached and independent from the kernel git flows that we can move to support merge requests here if you like. All in, or support both patches and merge requests? BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: reminder: review of maintainer-tools patches is mandatory
On Wed, Jan 13, 2021 at 3:21 PM Jani Nikula wrote: > On Wed, 13 Jan 2021, Sumit Semwal wrote: > > Hi Jani, > > > > Apologies on this - I understand the review part as well, you're right. > > > > Just to give you context: This patch was a quick response to Daniel's ask > > to update the documentation over IRC. I didn't know the process for this, > > and assuming gitlab, created a PR. By the time I could offer Daniel to send > > a patch, he had merged the PR. > > > > Irrespective, I will take care going forward. Apologies again. > > Oh, okay, don't worry about it. Daniel merging the PR is certainly > enough of an ack here. The problem is that in git logs you appeared to > be the committer and Daniel's involvement was completely lost, and > that's what I was going by. Yeah with proper MR flow we'd have marge set up (to do the MR merging for us, it's a bot), which adds a Part-of: tag to each commit it pushes through an MR, so you can go back to the MR link and see all the discussion. There's an r-b: tag from me there. I think we should either set that up or disable MR since it's confusing. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: reminder: review of maintainer-tools patches is mandatory
On Wed, 13 Jan 2021, Sumit Semwal wrote: > Hi Jani, > > Apologies on this - I understand the review part as well, you're right. > > Just to give you context: This patch was a quick response to Daniel's ask > to update the documentation over IRC. I didn't know the process for this, > and assuming gitlab, created a PR. By the time I could offer Daniel to send > a patch, he had merged the PR. > > Irrespective, I will take care going forward. Apologies again. Oh, okay, don't worry about it. Daniel merging the PR is certainly enough of an ack here. The problem is that in git logs you appeared to be the committer and Daniel's involvement was completely lost, and that's what I was going by. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
reminder: review of maintainer-tools patches is mandatory
Hi Sumit, I just noticed commit 3ed2489ca753 ("Update repositories.rst
for current drm-misc maintainers") in the maintainer-tools repository.
The change appears to have been pushed without first sending the patch
to the dim-tools mailing list, and apparently without review.
Regardless of how trivial or minor the change appears to be, review is
mandatory. For that to happen, posting to the mailing list is mandatory.
Please see CONTRIBUTING.rst in the repository.
---
As to the change, the review, given the chance, would have been that the
change is not enough. We still seem to have Sean's email in the dim
script.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
___
dim-tools mailing list
dim-tools@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dim-tools
