Re: [Intel-gfx] [PULL] drm-intel-next
On Tue, Mar 07, 2023 at 05:00:01PM -0500, Rodrigo Vivi wrote: > Hi Dave and Daniel, > > Here goes our first pull request towards 6.3. You know, I meant 6.4. :) Thank you Joonas for noticing that. > > drm-intel-next-2023-03-07: > > Cross-subsystem Changes: > - MEI patches to fix suspend/resume issues with the i915's PXP. (Alexander) > > Driver Changes: > - Registers helpers and clean-ups. (Lucas) > - PXP fixes and clean-ups. (Alan, Alexander) > - CDCLK related fixes and w/a (Chaitanya, Stanislav) > - Move display code to use RMW whenever possible (Andrzej) > - PSR fixes (Jouni, Ville) > - Implement async_flip mode per plane tracking (Andrzej) > - Remove pre-production Workarounds (Matt) > - HDMI related fixes (Ankit) > - LVDS cleanup (Ville) > - Watermark fixes and cleanups (Ville, Jani, Stanilav) > - DMC code related fixes, cleanups and improvements (Jani) > - Implement fb_dirty for PSR,FBC,DRRS fixes (Jouni) > - Initial DSB improvements targeting LUTs loading (Ville) > - HWMON related fixes (Ashutosh) > - PCI ID updates (Jonathan, Matt Roper) > - Fix leak in scatterlist (Matt Atwood) > - Fix eDP+DSI dual panel systems (Ville) > - Cast iomem to avoid sparese warnings (Jani) > - Set default backlight controller index (Jani) > - More MTL enabling (RK) > - Conversion of display dev_priv towards i915 (Nirmoy) > - Improvements in log/debug messages (Ville) > - Increase slice_height for DP VDSC (Suraj) > - VBT ports improvements (Ville) > - Fix platforms without Display (Imre) > - Other generic display code clean-ups (Ville, Jani, Rodrigo) > - Add RPL-U sub platform (Chaitanya) > - Add inverted backlight quirk for HP 14-r206nv (Mavroudis) > - Transcoder timing improvements (Ville) > - Track audio state per-transcoder (Ville) > - Error/underrun interrupt fixes (Ville) > - Update combo PHY init sequence (Matt Roper) > - Get HDR DPCD refresh timeout (Ville) > - Vblank improvements (Ville) > - DSS fixes and cleanups (Jani) > - PM code cleanup (Jani) > - Split display parts related to RPS (Jani) > > Thanks, > Rodrigo. > > The following changes since commit d3eb347da1148fdb1c2462ae83090a4553d3f46f: > > drm/i915/mtl: Apply Wa_14013475917 for all MTL steppings (2023-01-26 > 13:54:05 +0200) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-next-2023-03-07 > > for you to fetch changes up to 4b736ed40583631e0cf32c55dbc1e5ec0434a74b: > > drm/i915: Get rid of the gm45 HPD live state nonsense (2023-03-07 19:09:20 > +0200) > > > Cross-subsystem Changes: > - MEI patches to fix suspend/resume issues with the i915's PXP. (Alexander) > > Driver Changes: > - Registers helpers and clean-ups. (Lucas) > - PXP fixes and clean-ups. (Alan, Alexander) > - CDCLK related fixes and w/a (Chaitanya, Stanislav) > - Move display code to use RMW whenever possible (Andrzej) > - PSR fixes (Jouni, Ville) > - Implement async_flip mode per plane tracking (Andrzej) > - Remove pre-production Workarounds (Matt) > - HDMI related fixes (Ankit) > - LVDS cleanup (Ville) > - Watermark fixes and cleanups (Ville, Jani, Stanilav) > - DMC code related fixes, cleanups and improvements (Jani) > - Implement fb_dirty for PSR,FBC,DRRS fixes (Jouni) > - Initial DSB improvements targeting LUTs loading (Ville) > - HWMON related fixes (Ashutosh) > - PCI ID updates (Jonathan, Matt Roper) > - Fix leak in scatterlist (Matt Atwood) > - Fix eDP+DSI dual panel systems (Ville) > - Cast iomem to avoid sparese warnings (Jani) > - Set default backlight controller index (Jani) > - More MTL enabling (RK) > - Conversion of display dev_priv towards i915 (Nirmoy) > - Improvements in log/debug messages (Ville) > - Increase slice_height for DP VDSC (Suraj) > - VBT ports improvements (Ville) > - Fix platforms without Display (Imre) > - Other generic display code clean-ups (Ville, Jani, Rodrigo) > - Add RPL-U sub platform (Chaitanya) > - Add inverted backlight quirk for HP 14-r206nv (Mavroudis) > - Transcoder timing improvements (Ville) > - Track audio state per-transcoder (Ville) > - Error/underrun interrupt fixes (Ville) > - Update combo PHY init sequence (Matt Roper) > - Get HDR DPCD refresh timeout (Ville) > - Vblank improvements (Ville) > - DSS fixes and cleanups (Jani) > - PM code cleanup (Jani) > - Split display parts related to RPS (Jani) > > > Alan Previn (3): > drm/i915/pxp: Invalidate all PXP fw sessions during teardown > drm/i915/pxp: Trigger the global teardown for before suspending > drm/i915/pxp: Pxp hw init should be in resume_complete > > Alexander Usyskin (3): > mei: mei-me: resume device in prepare > drm/i915/pxp: add device link between i915 and mei_pxp > mei: clean pending read with vtag on bus > > Andrzej Hajda (14): > drm/i915/display/fdi: use intel_de_rmw if possible > drm/i915/display/vlv: fix pixel overlap
Re: [Intel-gfx] [PULL] drm-intel-next
On Tue, Nov 01, 2022 at 10:29:24PM +, Vivi, Rodrigo wrote: > On Sat, 2022-10-29 at 02:41 +0300, Ville Syrjälä wrote: > > On Fri, Oct 28, 2022 at 02:22:33PM -0400, Rodrigo Vivi wrote: > > > Hi Dave and Daniel, > > > > > > Here goes the first chunk of drm-intel-next targeting 6.2 > > > > > > The highlight goes to Ville with many display related clean-up > > > and improvement, some other MTL enabling work and many other > > > fixes and small clean-ups. > > > > > > drm-intel-next-2022-10-28: > > ... > > > - ELD precompute and readout (Ville) > > > > A slight clarification seems to be in order. The ELD > > precompute+readout is in fact not in yet. This was just a pile > > of cleanups and minor fixes. The real ELD stuff will come later, > > once we figure out how we actually want to do it. > > Sorry for the confusion. I have just used the subject of your series > as summary: > [Intel-gfx] [PATCH 00/22] drm/i915: ELD precompute and readout Only part of the series went in. > > Should I change that to ELD precompute and readout Just "audio cleanups" or something like that would be the approximate truth. -- Ville Syrjälä Intel
Re: [Intel-gfx] [PULL] drm-intel-next
On Sat, 2022-10-29 at 02:41 +0300, Ville Syrjälä wrote: > On Fri, Oct 28, 2022 at 02:22:33PM -0400, Rodrigo Vivi wrote: > > Hi Dave and Daniel, > > > > Here goes the first chunk of drm-intel-next targeting 6.2 > > > > The highlight goes to Ville with many display related clean-up > > and improvement, some other MTL enabling work and many other > > fixes and small clean-ups. > > > > drm-intel-next-2022-10-28: > ... > > - ELD precompute and readout (Ville) > > A slight clarification seems to be in order. The ELD > precompute+readout is in fact not in yet. This was just a pile > of cleanups and minor fixes. The real ELD stuff will come later, > once we figure out how we actually want to do it. Sorry for the confusion. I have just used the subject of your series as summary: [Intel-gfx] [PATCH 00/22] drm/i915: ELD precompute and readout Should I change that to ELD precompute and readout >
Re: [Intel-gfx] [PULL] drm-intel-next
On Fri, Oct 28, 2022 at 02:22:33PM -0400, Rodrigo Vivi wrote: > Hi Dave and Daniel, > > Here goes the first chunk of drm-intel-next targeting 6.2 > > The highlight goes to Ville with many display related clean-up > and improvement, some other MTL enabling work and many other > fixes and small clean-ups. > > drm-intel-next-2022-10-28: ... > - ELD precompute and readout (Ville) A slight clarification seems to be in order. The ELD precompute+readout is in fact not in yet. This was just a pile of cleanups and minor fixes. The real ELD stuff will come later, once we figure out how we actually want to do it. -- Ville Syrjälä Intel
Re: [Intel-gfx] [PULL] drm-intel-next-fixes
On Fri, Aug 05, 2022 at 05:25:43PM +0200, Mauro Carvalho Chehab wrote: > On Fri, 5 Aug 2022 10:39:44 -0400 > Rodrigo Vivi wrote: > > > On Fri, Aug 05, 2022 at 10:46:57AM +0200, Mauro Carvalho Chehab wrote: > > > Hi Rodrigo, > > > > > > On Thu, 4 Aug 2022 13:33:06 -0400 > > > Rodrigo Vivi wrote: > > > > > > > Hi Dave and Daniel, > > > > > > > > Here goes drm-intel-next-fixes-2022-08-04: > > > > > > > > - disable pci resize on 32-bit systems (Nirmoy) > > > > - don't leak the ccs state (Matt) > > > > - TLB invalidation fixes (Chris) > > > > > > > > Thanks, > > > > Rodrigo. > > > > > > > > The following changes since commit > > > > 2bc7ea71a73747a77e7f83bc085b0d2393235410: > > > > > > > > Merge tag 'topic/nouveau-misc-2022-07-27' of > > > > git://anongit.freedesktop.org/drm/drm into drm-next (2022-07-27 > > > > 11:34:07 +1000) > > > > > > > > are available in the Git repository at: > > > > > > > > git://anongit.freedesktop.org/drm/drm-intel > > > > tags/drm-intel-next-fixes-2022-08-04 > > > > > > > > for you to fetch changes up to e57b9369e0c6f60155027e120fafd4b57e385b71: > > > > > > > > drm/i915/gt: Batch TLB invalidations (2022-08-01 09:48:06 -0400) > > > > > > > > > > > > - disable pci resize on 32-bit systems (Nirmoy) > > > > - don't leak the ccs state (Matt) > > > > - TLB invalidation fixes (Chris) > > > > > > > > > > > > Chris Wilson (4): > > > > drm/i915/gt: Ignore TLB invalidations on idle engines > > > > drm/i915/gt: Invalidate TLB of the OA unit at TLB invalidations > > > > drm/i915/gt: Skip TLB invalidations once wedged > > > > > > > drm/i915/gt: Batch TLB invalidations > > > This patch actually adds a regression due to a silly mistake. > > > The fix is here: > > > > > > https://patchwork.freedesktop.org/patch/496249/?series=106805=4 > > > > > > > Thank you for the heads up. > > > > Since that patch is not merged yet, what are your recommendations here? > > Should I remove this from drm-intel-next-fixes now? > > Those patches are OK to merge: > >drm/i915/gt: Ignore TLB invalidations on idle engines >drm/i915/gt: Invalidate TLB of the OA unit at TLB invalidations >drm/i915/gt: Skip TLB invalidations once wedged > > And helps reduce performance regressions due to TLB cache invalidation. > So, I would keep them. > > With regards to the 4th patch, please don't merge: > > drm/i915/gt: Batch TLB invalidations > > or merge it together with: > > drm/i915: pass a pointer for tlb seqno at vma_invalidate_tlb() Since this one has not landed yet I won't rush it in. I'm removing the Batch TLB invalidations and sending a new pull request without that patch. Thank you for the info and great work there. > > > Which regression is worst? > > The regression caused by the batch patch is a lot worse, as it > effectively disables TLB cache invalidation. The fix was meant to > be merged at the patch, but somehow between several rebases and 3 > machines involved on tests, internal development and upstream, the > branch actually sent upstream was not the right one. It got only > noticed after reviewing a newer patch. Yeah, that sucks. > > > Also dim has trouble with fixes for fixes in the same round. > > Please ping me when you get that patch merged so I can pull that. > > OK. > > Regards, > Mauro
Re: [Intel-gfx] [PULL] drm-intel-next-fixes
On Fri, 5 Aug 2022 10:39:44 -0400 Rodrigo Vivi wrote: > On Fri, Aug 05, 2022 at 10:46:57AM +0200, Mauro Carvalho Chehab wrote: > > Hi Rodrigo, > > > > On Thu, 4 Aug 2022 13:33:06 -0400 > > Rodrigo Vivi wrote: > > > > > Hi Dave and Daniel, > > > > > > Here goes drm-intel-next-fixes-2022-08-04: > > > > > > - disable pci resize on 32-bit systems (Nirmoy) > > > - don't leak the ccs state (Matt) > > > - TLB invalidation fixes (Chris) > > > > > > Thanks, > > > Rodrigo. > > > > > > The following changes since commit > > > 2bc7ea71a73747a77e7f83bc085b0d2393235410: > > > > > > Merge tag 'topic/nouveau-misc-2022-07-27' of > > > git://anongit.freedesktop.org/drm/drm into drm-next (2022-07-27 11:34:07 > > > +1000) > > > > > > are available in the Git repository at: > > > > > > git://anongit.freedesktop.org/drm/drm-intel > > > tags/drm-intel-next-fixes-2022-08-04 > > > > > > for you to fetch changes up to e57b9369e0c6f60155027e120fafd4b57e385b71: > > > > > > drm/i915/gt: Batch TLB invalidations (2022-08-01 09:48:06 -0400) > > > > > > > > > - disable pci resize on 32-bit systems (Nirmoy) > > > - don't leak the ccs state (Matt) > > > - TLB invalidation fixes (Chris) > > > > > > > > > Chris Wilson (4): > > > drm/i915/gt: Ignore TLB invalidations on idle engines > > > drm/i915/gt: Invalidate TLB of the OA unit at TLB invalidations > > > drm/i915/gt: Skip TLB invalidations once wedged > > > > > drm/i915/gt: Batch TLB invalidations > > This patch actually adds a regression due to a silly mistake. > > The fix is here: > > > > https://patchwork.freedesktop.org/patch/496249/?series=106805=4 > > > > Thank you for the heads up. > > Since that patch is not merged yet, what are your recommendations here? > Should I remove this from drm-intel-next-fixes now? Those patches are OK to merge: drm/i915/gt: Ignore TLB invalidations on idle engines drm/i915/gt: Invalidate TLB of the OA unit at TLB invalidations drm/i915/gt: Skip TLB invalidations once wedged And helps reduce performance regressions due to TLB cache invalidation. So, I would keep them. With regards to the 4th patch, please don't merge: drm/i915/gt: Batch TLB invalidations or merge it together with: drm/i915: pass a pointer for tlb seqno at vma_invalidate_tlb() > Which regression is worst? The regression caused by the batch patch is a lot worse, as it effectively disables TLB cache invalidation. The fix was meant to be merged at the patch, but somehow between several rebases and 3 machines involved on tests, internal development and upstream, the branch actually sent upstream was not the right one. It got only noticed after reviewing a newer patch. Yeah, that sucks. > Also dim has trouble with fixes for fixes in the same round. > Please ping me when you get that patch merged so I can pull that. OK. Regards, Mauro
Re: [Intel-gfx] [PULL] drm-intel-next-fixes
On Fri, Aug 05, 2022 at 10:46:57AM +0200, Mauro Carvalho Chehab wrote: > Hi Rodrigo, > > On Thu, 4 Aug 2022 13:33:06 -0400 > Rodrigo Vivi wrote: > > > Hi Dave and Daniel, > > > > Here goes drm-intel-next-fixes-2022-08-04: > > > > - disable pci resize on 32-bit systems (Nirmoy) > > - don't leak the ccs state (Matt) > > - TLB invalidation fixes (Chris) > > > > Thanks, > > Rodrigo. > > > > The following changes since commit 2bc7ea71a73747a77e7f83bc085b0d2393235410: > > > > Merge tag 'topic/nouveau-misc-2022-07-27' of > > git://anongit.freedesktop.org/drm/drm into drm-next (2022-07-27 11:34:07 > > +1000) > > > > are available in the Git repository at: > > > > git://anongit.freedesktop.org/drm/drm-intel > > tags/drm-intel-next-fixes-2022-08-04 > > > > for you to fetch changes up to e57b9369e0c6f60155027e120fafd4b57e385b71: > > > > drm/i915/gt: Batch TLB invalidations (2022-08-01 09:48:06 -0400) > > > > > > - disable pci resize on 32-bit systems (Nirmoy) > > - don't leak the ccs state (Matt) > > - TLB invalidation fixes (Chris) > > > > > > Chris Wilson (4): > > drm/i915/gt: Ignore TLB invalidations on idle engines > > drm/i915/gt: Invalidate TLB of the OA unit at TLB invalidations > > drm/i915/gt: Skip TLB invalidations once wedged > > > drm/i915/gt: Batch TLB invalidations > This patch actually adds a regression due to a silly mistake. > The fix is here: > > https://patchwork.freedesktop.org/patch/496249/?series=106805=4 > Thank you for the heads up. Since that patch is not merged yet, what are your recommendations here? Should I remove this from drm-intel-next-fixes now? Which regression is worst? Also dim has trouble with fixes for fixes in the same round. Please ping me when you get that patch merged so I can pull that. Thanks, Rodrigo. > Regards, > Mauro
Re: [Intel-gfx] [PULL] drm-intel-next-fixes
Hi Rodrigo, On Thu, 4 Aug 2022 13:33:06 -0400 Rodrigo Vivi wrote: > Hi Dave and Daniel, > > Here goes drm-intel-next-fixes-2022-08-04: > > - disable pci resize on 32-bit systems (Nirmoy) > - don't leak the ccs state (Matt) > - TLB invalidation fixes (Chris) > > Thanks, > Rodrigo. > > The following changes since commit 2bc7ea71a73747a77e7f83bc085b0d2393235410: > > Merge tag 'topic/nouveau-misc-2022-07-27' of > git://anongit.freedesktop.org/drm/drm into drm-next (2022-07-27 11:34:07 > +1000) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-intel > tags/drm-intel-next-fixes-2022-08-04 > > for you to fetch changes up to e57b9369e0c6f60155027e120fafd4b57e385b71: > > drm/i915/gt: Batch TLB invalidations (2022-08-01 09:48:06 -0400) > > > - disable pci resize on 32-bit systems (Nirmoy) > - don't leak the ccs state (Matt) > - TLB invalidation fixes (Chris) > > > Chris Wilson (4): > drm/i915/gt: Ignore TLB invalidations on idle engines > drm/i915/gt: Invalidate TLB of the OA unit at TLB invalidations > drm/i915/gt: Skip TLB invalidations once wedged > drm/i915/gt: Batch TLB invalidations This patch actually adds a regression due to a silly mistake. The fix is here: https://patchwork.freedesktop.org/patch/496249/?series=106805=4 Regards, Mauro
Re: [Intel-gfx] [PULL] drm-intel-next-fixes
On Thu, Jul 01, 2021 at 11:57:53AM +0300, Jani Nikula wrote:
> On Wed, 30 Jun 2021, Rodrigo Vivi wrote:
> > On Wed, Jun 30, 2021 at 01:05:35PM +0300, Jani Nikula wrote:
> >> On Tue, 29 Jun 2021, Rodrigo Vivi wrote:
> >> > Hi Dave and Daniel,
> >> >
> >> > Here goes drm-intel-next-fixes-2021-06-29:
> >> >
> >> > The biggest fix is the restoration of mmap ioctl for gen12 integrated
> >> > parts
> >> > which lack was breaking ADL-P with media stack.
> >> > Besides that a small selftest fix and a theoretical overflow on
> >> > i915->pipe_to_crtc_mapping.
> >>
> >> My last fixes pull for v5.13 fell between the cracks [1]. There was one
> >> stable worthy fix, but since it was still in drm-intel-fixes when you
> >> ran dim cherry-pick-next-fixes, it was skipped for drm-intel-next-fixes.
> >>
> >> I've now dropped the commit and pushed v5.13 to drm-intel-fixes, as
> >> we're past that point. Subsequent dim cherry-pick-next-fixes should pick
> >> it up now.
> >
> > it didn't, probably because the Fixes hash not being part of the drm-next
> > yet?!
>
> Odd, should be.
indeed...
>
> > I can cherry-pick that directly. Please let me know the commit id.
>
> c88e2647c5bb ("drm/i915/display: Do not zero past infoframes.vsc")
pushed to drm-intel-next-queue... will wait for CI results and send another PR.
I hope there's still time, otherwise it can wait for the -fixes flow
>
> Thanks,
> Jani.
>
>
> >
> > Thanks,
> > Rodrigo.
> >
> >>
> >> Please do another next fixes pull request with that. (It's okay to pull
> >> this one already though, doesn't make a difference.)
> >>
> >>
> >> BR,
> >> Jani.
> >>
> >>
> >> [1] https://lore.kernel.org/r/87czsbu15r@intel.com
> >>
> >>
> >>
> >> >
> >> > Thanks,
> >> > Rodrigo.
> >> >
> >> > The following changes since commit
> >> > 1bd8a7dc28c1c410f1ceefae1f2a97c06d1a67c2:
> >> >
> >> > Merge tag 'exynos-drm-next-for-v5.14' of
> >> > git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos into
> >> > drm-next (2021-06-11 14:19:12 +1000)
> >> >
> >> > are available in the Git repository at:
> >> >
> >> > git://anongit.freedesktop.org/drm/drm-intel
> >> > tags/drm-intel-next-fixes-2021-06-29
> >> >
> >> > for you to fetch changes up to c90c4c6574f3feaf2203b5671db1907a1e15c653:
> >> >
> >> > drm/i915: Reinstate the mmap ioctl for some platforms (2021-06-28
> >> > 07:43:56 -0400)
> >> >
> >> >
> >> > The biggest fix is the restoration of mmap ioctl for gen12 integrated
> >> > parts
> >> > which lack was breaking ADL-P with media stack.
> >> > Besides that a small selftest fix and a theoretical overflow on
> >> > i915->pipe_to_crtc_mapping.
> >> >
> >> >
> >> > Chris Wilson (1):
> >> > drm/i915/selftests: Reorder tasklet_disable vs local_bh_disable
> >> >
> >> > Jani Nikula (1):
> >> > drm/i915/dsc: abstract helpers to get bigjoiner primary/secondary
> >> > crtc
> >> >
> >> > Thomas Hellström (1):
> >> > drm/i915: Reinstate the mmap ioctl for some platforms
> >> >
> >> > drivers/gpu/drm/i915/display/intel_display.c | 7 ++-
> >> > drivers/gpu/drm/i915/display/intel_display_types.h | 8
> >> > drivers/gpu/drm/i915/display/intel_vdsc.c | 40 +++-
> >> > drivers/gpu/drm/i915/display/intel_vdsc.h | 1 +
> >> > drivers/gpu/drm/i915/gem/i915_gem_mman.c | 7 +--
> >> > drivers/gpu/drm/i915/gt/selftest_execlists.c | 55
> >> > +-
> >> > 6 files changed, 76 insertions(+), 42 deletions(-)
> >>
> >> --
> >> Jani Nikula, Intel Open Source Graphics Center
>
> --
> Jani Nikula, Intel Open Source Graphics Center
> ___
> Intel-gfx mailing list
> intel-...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
___
dim-tools mailing list
dim-tools@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dim-tools
