Re: [PULL] drm-intel-fixes
Quoting Krzysztof Kozlowski (2024-08-08 21:44:39) > On 08/08/2024 20:35, Krzysztof Kozlowski wrote: > > On 08/08/2024 10:45, Tvrtko Ursulin wrote: > >> > >> Hi Dave, Sima, > >> > >> A small bunch of fixes for the weekly cycle: > > > > ... > > > >> > >> > >> Andi Shyti (2): > >> drm/i915/gem: Adjust vma offset for framebuffer mmap offset > >> drm/i915/gem: Fix Virtual Memory mapping boundaries calculation > >> > >> David Gow (2): > >> drm/i915: Allow evicting to use the requested placement > >> drm/i915: Attempt to get pages without eviction first > >> > >> Dnyaneshwar Bhadane (1): > >> drm/i915/display: correct dual pps handling for MTL_PCH+ > > > > Several commits have issues. Look: > > > > Signed-off-by: Joonas Lahtinen > > Link: https://patchwork.freedesktop.org/patch/msgid ... > > (cherry picked from commit 97b6784753da06d9d40232328efc5c5367e53417) > > Signed-off-by: Joonas Lahtinen > > > > > > 1. Duplicated committer SoB. > > You added SoB. No need to add two. It does not get stronger. You do not > > change the DCO rules by adding two SoBs. You cannot confirm something > > more or twice. Read DCO one more time... Hi Krzysztof, As a self-proclaimed quite active kernel developer (by a quick web search) you might have already ventured to look at the GIT history of the subsytem tree for the patch in question. If you did that, you might have implied that the second S-o-b is added by automation -- and it indeed is. While appreciating the report, maybe not so much the the condescending style of the communication. You now slightly come through as a troll hoping to be fed - I hope that is not the case. Seems like we've had such a double S-o-b regularly generated by DIM (Drm Inglorious Maintainer scripts) at least since 2016 as the first occurrance seems to have been in ccda3a728f70 . So rest of the ecosystem seems to deal with them just fine. Is the double S-o-b issue purely cosmetic for you? Not a lawyer but I don't think there is any legal problem in stating the same thing twice. [1] Or are you maybe running into some more concrete issues with upstream kernel process related scripts or other automation processing of the commit? Regards, Joonas [1] When it comes to the commit rights model in DRM subsystem, stripping the final S-o-b after the cherry-pick would make it less obvious who did the pick. If there are multiple S-o-bs and the cherry-picking person happened to be one of them, that information would be lost. Less predictable outcome for the patch form for no actual gain in my opinion. On the other hand, removing the S-o-b line from above the "(cherry-picked.." line would modify the cherry-picked commit description itself and I would assume everyone agrees that should not be done.
Re: [PULL] drm-intel-fixes
Hi Krzysztof, You might want to familiarise yourself with the drm tree development procedures before weighing in, and snarky comments like the final one are not appreciated on this list or in this community. The drm next trees are never rebased (only in super rare emergencies), we never rebase next onto fixes, This leads to a number of things that are different from other workflows. I agree the duplicate SoB isn't great, but it's also not harmful, The cherry-pick thing is normal operating procedure unfortunately, we get told if we leave it out it causes problems later, so we add it in, and it resolves itself in the future when the next trees end up in Linus' tree. Thanks, Dave. > > > > 1. Duplicated committer SoB. > > You added SoB. No need to add two. It does not get stronger. You do not > > change the DCO rules by adding two SoBs. You cannot confirm something > > more or twice. Read DCO one more time... > > > > 2. Useless cherry pick SHA. > > fatal: bad object 97b6784753da06d9d40232328efc5c5367e53417 > > (Tried with repo having several maintainer repos and the linux-next) > > > > Only you have 97b6784753da06d9d40232328efc5c5367e53417. Maybe few other > > people as well, but all other do not. This does not bring any useful > > information, rather obfuscates public git history. > > ... and in case you claim that 97b6784753da06d9d40232328efc5c5367e53417 > is in drm-next, then your workflow is broken because: > 1. You will duplicate the same commit. One in drm-fixes and second in > drm-next. Just use git features, like branches and merges... First you > apply on fixes, then you merge it to next, for example. Or any other > sane way. > > 2. If you rebase drm-next on top of drm-fixes in some time in the > future, then that cherry-pick SHA will not work and will be totally useless. > > so either you create duplicate commits (that's how Intel gets stats?) or > you introduce to git history totally bogus SHAs... > > Best regards, > Krzysztof >
Re: [PULL] drm-intel-fixes
On Tue, Jul 02, 2024 at 11:28:39AM +0300, Jani Nikula wrote: > > Hi Dave & Sima - > > One early fix this week. > > drm-intel-fixes-2024-07-02: > drm/i915 fixes for v6.10-rc7: > - Skip unnecessary MG programming, avoiding warnings (Imre) > > BR, > Jani. > > The following changes since commit 22a40d14b572deb80c0648557f4bd502d7e83826: > > Linux 6.10-rc6 (2024-06-30 14:40:44 -0700) > > are available in the Git repository at: > > https://gitlab.freedesktop.org/drm/i915/kernel.git > tags/drm-intel-fixes-2024-07-02 > > for you to fetch changes up to f72383371e8c5d1d108532d7e395ff2c277233e5: > > drm/i915/display: For MTL+ platforms skip mg dp programming (2024-07-01 > 10:36:12 +0300) Pulled, thanks. -Sima > > > drm/i915 fixes for v6.10-rc7: > - Skip unnecessary MG programming, avoiding warnings (Imre) > > > Imre Deak (1): > drm/i915/display: For MTL+ platforms skip mg dp programming > > drivers/gpu/drm/i915/display/intel_ddi.c | 3 +++ > 1 file changed, 3 insertions(+) > > -- > Jani Nikula, Intel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Re: [PULL] drm-intel-fixes
On Fri, Mar 29, 2024 at 06:23:54AM -0400, Musial, Ewelina wrote: > Hi Rodrigo, > > When I opened dashboard early morning all results were available, so I don't > think there was any issue during night. > It could be long reporting queue - reporting through AWS takes ages but this > is not an issue with reporting, this is how AWS works. I'm sorry for the noise. It was probably just a matter of time. Everything looking good there. Thanks, Rodrigo. > > Regards, > Ewelina > > -Original Message- > From: Intel-gfx On Behalf Of > Rodrigo Vivi > Sent: Friday, March 29, 2024 2:32 AM > To: Dave Airlie ; Daniel Vetter > Cc: Jani Nikula ; Joonas Lahtinen > ; Tvrtko Ursulin ; > Vivi, Rodrigo ; Thomas Zimmermann > ; Maarten Lankhorst ; > Maxime Ripard ; Thomas Hellström > ; Oded Gabbay ; De > Marchi, Lucas ; dri-de...@lists.freedesktop.org; > intel-...@lists.freedesktop.org; intel...@lists.freedesktop.org; > dim-tools@lists.freedesktop.org > Subject: [PULL] drm-intel-fixes > > Hi Dave and Sima, > > Here goes our first PR of this round. > > Our CI is not working as I would expect: > https://intel-gfx-ci.01.org/tree/drm-intel-fixes/index.html? > > Well, at least it caught some build failures on runds 832 and 833. > But after I fixed those, the 834 (with v6.9-rc1) and the 835 (with all these > patches here) didn't show up yet. So I have run manual validation on my > DG2+ADL here. > > Everything looking good here, and it is yet -rc1. I'm confident that we can > move ahead with those while we work to get CI back. > > Thanks, > Rodrigo > > drm-intel-fixes-2024-03-28: > > Core/GT Fixes: > - Fix for BUG_ON/BUILD_BUG_ON IN I915_memcpy.c (Joonas) > - Update a MTL workaround (Tejas) > - Fix locking inversion in hwmon's sysfs (Janusz) > - Remove a bogus error message around PXP (Jose) > - Fix UAF on VMA (Janusz) > - Reset queue_priority_hint on parking (Chris) > > Display Fixes: > - Remove duplicated audio enable/disable on SDVO and DP (Ville) > - Disable AuxCCS for Xe driver (Juha-Pekka) > - Revert init order of MIPI DSI (Ville) > - DRRS debugfs fix with an extra refactor patch (Bhanuprakash) > - VRR related fixes (Ville) > - Fix a JSL eDP corruption (Jonathon) > - Fix the cursor physical dma address (Ville) > - BIOS VBT related fix (Ville) > > Thanks, > Rodrigo. > > The following changes since commit 4cece764965020c22cff7665b18a012006359095: > > Linux 6.9-rc1 (2024-03-24 14:10:05 -0700) > > are available in the Git repository at: > > https://anongit.freedesktop.org/git/drm/drm-intel > tags/drm-intel-fixes-2024-03-28 > > for you to fetch changes up to 32e39bab59934bfd3f37097d4dd85ac5eb0fd549: > > drm/i915/bios: Tolerate devdata==NULL in > intel_bios_encoder_supports_dp_dual_mode() (2024-03-28 12:16:17 -0400) > > > Core/GT Fixes: > - Fix for BUG_ON/BUILD_BUG_ON IN I915_memcpy.c (Joonas) > - Update a MTL workaround (Tejas) > - Fix locking inversion in hwmon's sysfs (Janusz) > - Remove a bogus error message around PXP (Jose) > - Fix UAF on VMA (Janusz) > - Reset queue_priority_hint on parking (Chris) > > Display Fixes: > - Remove duplicated audio enable/disable on SDVO and DP (Ville) > - Disable AuxCCS for Xe driver (Juha-Pekka) > - Revert init order of MIPI DSI (Ville) > - DRRS debugfs fix with an extra refactor patch (Bhanuprakash) > - VRR related fixes (Ville) > - Fix a JSL eDP corruption (Jonathon) > - Fix the cursor physical dma address (Ville) > - BIOS VBT related fix (Ville) > > > Bhanuprakash Modem (2): > drm/i915/drrs: Refactor CPU transcoder DRRS check > drm/i915/display/debugfs: Fix duplicate checks in i915_drrs_status > > Chris Wilson (1): > drm/i915/gt: Reset queue_priority_hint on parking > > Janusz Krzysztofik (2): > drm/i915/hwmon: Fix locking inversion in sysfs getter > drm/i915/vma: Fix UAF on destroy against retire race > > Jonathon Hall (1): > drm/i915: Do not match JSL in ehl_combo_pll_div_frac_wa_needed() > > Joonas Lahtinen (1): > drm/i915: Add includes for BUG_ON/BUILD_BUG_ON in i915_memcpy.c > > José Roberto de Souza (1): > drm/i915: Do not print 'pxp init failed with 0' when it succeed > > Juha-Pekka Heikkila (1): > drm/i915/display: Disable AuxCCS framebuffers if built for Xe > > Tejas Upadhyay (1): > drm/i915/mtl: Update workaround 14018575942 > > Ville Syrjälä (6): > drm/i915: Stop doing double audio enable/disable on SDVO and g4x+ DP > drm/i915/dsi: Go back to the previous INIT_OTP/DISPLAY_ON order, mostly > drm/i915/vrr: Generate VRR "safe window" for DSB > drm/i915/dsb: Fix DSB vblank waits when using VRR > drm/i915: Pre-populate the cursor physical dma address > drm/i915/bios: Tolerate devdata==NULL in > intel_bios_encoder_supports_dp_dual_mode() > > drivers/gpu/drm/i915/display/g4x_dp.c | 2 - > d
RE: [PULL] drm-intel-fixes
Hi Rodrigo, When I opened dashboard early morning all results were available, so I don't think there was any issue during night. It could be long reporting queue - reporting through AWS takes ages but this is not an issue with reporting, this is how AWS works. Regards, Ewelina -Original Message- From: Intel-gfx On Behalf Of Rodrigo Vivi Sent: Friday, March 29, 2024 2:32 AM To: Dave Airlie ; Daniel Vetter Cc: Jani Nikula ; Joonas Lahtinen ; Tvrtko Ursulin ; Vivi, Rodrigo ; Thomas Zimmermann ; Maarten Lankhorst ; Maxime Ripard ; Thomas Hellström ; Oded Gabbay ; De Marchi, Lucas ; dri-de...@lists.freedesktop.org; intel-...@lists.freedesktop.org; intel...@lists.freedesktop.org; dim-tools@lists.freedesktop.org Subject: [PULL] drm-intel-fixes Hi Dave and Sima, Here goes our first PR of this round. Our CI is not working as I would expect: https://intel-gfx-ci.01.org/tree/drm-intel-fixes/index.html? Well, at least it caught some build failures on runds 832 and 833. But after I fixed those, the 834 (with v6.9-rc1) and the 835 (with all these patches here) didn't show up yet. So I have run manual validation on my DG2+ADL here. Everything looking good here, and it is yet -rc1. I'm confident that we can move ahead with those while we work to get CI back. Thanks, Rodrigo drm-intel-fixes-2024-03-28: Core/GT Fixes: - Fix for BUG_ON/BUILD_BUG_ON IN I915_memcpy.c (Joonas) - Update a MTL workaround (Tejas) - Fix locking inversion in hwmon's sysfs (Janusz) - Remove a bogus error message around PXP (Jose) - Fix UAF on VMA (Janusz) - Reset queue_priority_hint on parking (Chris) Display Fixes: - Remove duplicated audio enable/disable on SDVO and DP (Ville) - Disable AuxCCS for Xe driver (Juha-Pekka) - Revert init order of MIPI DSI (Ville) - DRRS debugfs fix with an extra refactor patch (Bhanuprakash) - VRR related fixes (Ville) - Fix a JSL eDP corruption (Jonathon) - Fix the cursor physical dma address (Ville) - BIOS VBT related fix (Ville) Thanks, Rodrigo. The following changes since commit 4cece764965020c22cff7665b18a012006359095: Linux 6.9-rc1 (2024-03-24 14:10:05 -0700) are available in the Git repository at: https://anongit.freedesktop.org/git/drm/drm-intel tags/drm-intel-fixes-2024-03-28 for you to fetch changes up to 32e39bab59934bfd3f37097d4dd85ac5eb0fd549: drm/i915/bios: Tolerate devdata==NULL in intel_bios_encoder_supports_dp_dual_mode() (2024-03-28 12:16:17 -0400) Core/GT Fixes: - Fix for BUG_ON/BUILD_BUG_ON IN I915_memcpy.c (Joonas) - Update a MTL workaround (Tejas) - Fix locking inversion in hwmon's sysfs (Janusz) - Remove a bogus error message around PXP (Jose) - Fix UAF on VMA (Janusz) - Reset queue_priority_hint on parking (Chris) Display Fixes: - Remove duplicated audio enable/disable on SDVO and DP (Ville) - Disable AuxCCS for Xe driver (Juha-Pekka) - Revert init order of MIPI DSI (Ville) - DRRS debugfs fix with an extra refactor patch (Bhanuprakash) - VRR related fixes (Ville) - Fix a JSL eDP corruption (Jonathon) - Fix the cursor physical dma address (Ville) - BIOS VBT related fix (Ville) Bhanuprakash Modem (2): drm/i915/drrs: Refactor CPU transcoder DRRS check drm/i915/display/debugfs: Fix duplicate checks in i915_drrs_status Chris Wilson (1): drm/i915/gt: Reset queue_priority_hint on parking Janusz Krzysztofik (2): drm/i915/hwmon: Fix locking inversion in sysfs getter drm/i915/vma: Fix UAF on destroy against retire race Jonathon Hall (1): drm/i915: Do not match JSL in ehl_combo_pll_div_frac_wa_needed() Joonas Lahtinen (1): drm/i915: Add includes for BUG_ON/BUILD_BUG_ON in i915_memcpy.c José Roberto de Souza (1): drm/i915: Do not print 'pxp init failed with 0' when it succeed Juha-Pekka Heikkila (1): drm/i915/display: Disable AuxCCS framebuffers if built for Xe Tejas Upadhyay (1): drm/i915/mtl: Update workaround 14018575942 Ville Syrjälä (6): drm/i915: Stop doing double audio enable/disable on SDVO and g4x+ DP drm/i915/dsi: Go back to the previous INIT_OTP/DISPLAY_ON order, mostly drm/i915/vrr: Generate VRR "safe window" for DSB drm/i915/dsb: Fix DSB vblank waits when using VRR drm/i915: Pre-populate the cursor physical dma address drm/i915/bios: Tolerate devdata==NULL in intel_bios_encoder_supports_dp_dual_mode() drivers/gpu/drm/i915/display/g4x_dp.c | 2 - drivers/gpu/drm/i915/display/icl_dsi.c | 3 +- drivers/gpu/drm/i915/display/intel_bios.c | 46 +--- drivers/gpu/drm/i915/display/intel_cursor.c| 4 +- drivers/gpu/drm/i915/display/intel_display_types.h | 1 + drivers/gpu/drm/i915/display/intel_dp.c| 12 +- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +- drivers/gpu/drm/i915/display/intel_drrs.c | 14 -- drivers/gpu/dr
Re: [PULL] drm-intel-fixes
On Thu, Nov 30, 2023 at 04:58:48PM +0200, Jani Nikula wrote:
>
> Hi Dave & Sima -
>
> i915 fixes for v6.7-rc4.
>
> drm-intel-fixes-2023-11-30:
> drm/i915 fixes for v6.7-rc4:
> - Mark internal GSC engine with reserved uabi class
> - Take VGA converters into account in eDP probe
> - Fix intel_pre_plane_updates() call to ensure workarounds get applied
>
> BR,
> Jani.
>
> The following changes since commit 2cc14f52aeb78ce3f29677c2de1f06c0e91471ab:
>
> Linux 6.7-rc3 (2023-11-26 19:59:33 -0800)
>
> are available in the Git repository at:
>
> git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2023-11-30
>
> for you to fetch changes up to d21a3962d3042e6f56ad324cf18bdd64a1e6ecfa:
>
> drm/i915: Call intel_pre_plane_updates() also for pipes getting enabled
> (2023-11-29 10:23:25 +0200)
>
>
> drm/i915 fixes for v6.7-rc4:
> - Mark internal GSC engine with reserved uabi class
> - Take VGA converters into account in eDP probe
> - Fix intel_pre_plane_updates() call to ensure workarounds get applied
>
>
> Tvrtko Ursulin (1):
> drm/i915/gsc: Mark internal GSC engine with reserved uabi class
>
> Ville Syrjälä (2):
> drm/i915: Also check for VGA converter in eDP probe
> drm/i915: Call intel_pre_plane_updates() also for pipes getting enabled
That last one might also require
commit bc53c4d56eb2 ("drm/i915: Check pipe active state in
{planes,vrr}_{enabling,disabling}()")
The vrr stuff in particular might go wonky otherwise.
>
> drivers/gpu/drm/i915/display/intel_display.c | 3 ++-
> drivers/gpu/drm/i915/display/intel_dp.c | 28 +++-
> drivers/gpu/drm/i915/gt/intel_engine_user.c | 39
>
> 3 files changed, 46 insertions(+), 24 deletions(-)
>
> --
> Jani Nikula, Intel
--
Ville Syrjälä
Intel
Re: [PULL] drm-intel-fixes
On Thu, 25 May 2023, Joonas Lahtinen wrote: > Hi Dave & Daniel, > > Here goes drm-intel-fixes for v4.6-rc4. You're seven years late for that one. ;D J. > > Again just one fix, for pipejoiner config pipe disabling. > > Regards, Joonas > > *** > > drm-intel-fixes-2023-05-25: > > PIPEDMC disabling fix for bigjoiner config > > The following changes since commit 44c026a73be8038f03dbdeef028b642880cf1511: > > Linux 6.4-rc3 (2023-05-21 14:05:48 -0700) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2023-05-25 > > for you to fetch changes up to 45dfbd992923f4df174db4e23b96fca7e30d73e2: > > drm/i915: Fix PIPEDMC disabling for a bigjoiner configuration (2023-05-22 > 17:10:11 +0300) > > > PIPEDMC disabling fix for bigjoiner config > > > Imre Deak (1): > drm/i915: Fix PIPEDMC disabling for a bigjoiner configuration > > drivers/gpu/drm/i915/display/intel_display.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center
Re: [PULL] drm-intel-fixes
On Thu, Apr 13, 2023 at 10:13:57AM +0300, Jani Nikula wrote: > > Hi Dave & Daniel - > > One DSI fix, stable material. > > drm-intel-fixes-2023-04-13: > drm/i915 fixes for v6.3-rc7: > - Fix dual link DSI for TGL+ > > BR, > Jani. > > The following changes since commit 09a9639e56c01c7a00d6c0ca63f4c7c41abe075d: > > Linux 6.3-rc6 (2023-04-09 11:15:57 -0700) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2023-04-13 Pulled, thanks > > for you to fetch changes up to 6b8446859c971a5783a2cdc90adf32e64de3bd23: > > drm/i915/dsi: fix DSS CTL register offsets for TGL+ (2023-04-11 11:41:57 > +0300) > > > drm/i915 fixes for v6.3-rc7: > - Fix dual link DSI for TGL+ > > > Jani Nikula (1): > drm/i915/dsi: fix DSS CTL register offsets for TGL+ > > drivers/gpu/drm/i915/display/icl_dsi.c | 20 > 1 file changed, 16 insertions(+), 4 deletions(-) > > -- > Jani Nikula, Intel Open Source Graphics Center -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Re: [PULL] drm-intel-fixes
On Wed, Apr 05, 2023 at 12:04:04PM +0300, Jani Nikula wrote: > > Hi Dave & Daniel - > > drm-intel-fixes-2023-04-05: > drm/i915 fixes for v6.3-rc6: > - Fix DP MST DSC M/N calculation to use compressed bpp > - Fix racy use-after-free in perf ioctl > - Fix context runtime accounting > - Fix handling of GT reset during HuC loading > - Fix use of unsigned vm_fault_t for error values > > BR, > Jani. > > The following changes since commit 7e364e56293bb98cae1b55fd835f5991c4e96e7d: > > Linux 6.3-rc5 (2023-04-02 14:29:29 -0700) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2023-04-05 > > for you to fetch changes up to dc3421560a67361442f33ec962fc6dd48895a0df: > > drm/i915: Fix context runtime accounting (2023-04-03 11:37:00 +0300) Pulled, thanks > > > drm/i915 fixes for v6.3-rc6: > - Fix DP MST DSC M/N calculation to use compressed bpp > - Fix racy use-after-free in perf ioctl > - Fix context runtime accounting > - Fix handling of GT reset during HuC loading > - Fix use of unsigned vm_fault_t for error values > > > Daniele Ceraolo Spurio (1): > drm/i915/huc: Cancel HuC delayed load timer on reset. > > Matthew Auld (1): > drm/i915/ttm: fix sparse warning > > Min Li (1): > drm/i915: fix race condition UAF in i915_perf_add_config_ioctl > > Stanislav Lisovskiy (1): > drm/i915: Use compressed bpp when calculating m/n value for DP MST DSC > > Tvrtko Ursulin (1): > drm/i915: Fix context runtime accounting > > drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +- > drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 5 +++-- > drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 12 ++-- > drivers/gpu/drm/i915/gt/uc/intel_huc.c | 7 +++ > drivers/gpu/drm/i915/gt/uc/intel_huc.h | 7 +-- > drivers/gpu/drm/i915/i915_perf.c | 6 +++--- > 6 files changed, 25 insertions(+), 14 deletions(-) > > -- > Jani Nikula, Intel Open Source Graphics Center -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Re: [PULL] drm-intel-fixes
On Thu, Mar 30, 2023 at 02:30:29PM +0300, Jani Nikula wrote: > > Hi Dave & Daniel - > > drm-intel-fixes-2023-03-30: > drm/i915 fixes for v6.3-rc5: > - Fix PMU support by reusing functions with sysfs > - Fix a number of issues related to color, PSR and arm/noarm > - Fix state check related to ICL PHY ownership check in TC-cold state > - Flush lmem contents after construction > - Fix hibernate oops related to DPT BO > - Fix perf stream error path wakeref balance > > BR, > Jani. > > The following changes since commit 197b6b60ae7bc51dd0814953c562833143b292aa: > > Linux 6.3-rc4 (2023-03-26 14:40:20 -0700) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2023-03-30 Pulled, thanks. > > for you to fetch changes up to 5c95b2d5d44fa250ce8aeee27bdb39b381d03857: > > drm/i915/perf: Drop wakeref on GuC RC error (2023-03-27 13:22:24 +0300) > > > drm/i915 fixes for v6.3-rc5: > - Fix PMU support by reusing functions with sysfs > - Fix a number of issues related to color, PSR and arm/noarm > - Fix state check related to ICL PHY ownership check in TC-cold state > - Flush lmem contents after construction > - Fix hibernate oops related to DPT BO > - Fix perf stream error path wakeref balance > > > Ashutosh Dixit (1): > drm/i915/pmu: Use functions common with sysfs to read actual freq > > Chris Wilson (2): > drm/i915/gem: Flush lmem contents after construction > drm/i915/perf: Drop wakeref on GuC RC error > > Imre Deak (1): > drm/i915/tc: Fix the ICL PHY ownership check in TC-cold state > > Ville Syrjälä (6): > drm/i915: Split icl_color_commit_noarm() from skl_color_commit_noarm() > drm/i915: Move CSC load back into .color_commit_arm() when PSR is > enabled on skl/glk > drm/i915: Add a .color_post_update() hook > drm/i915: Workaround ICL CSC_MODE sticky arming > drm/i915: Disable DC states for all commits > drm/i915/dpt: Treat the DPT BO as a framebuffer > > drivers/gpu/drm/i915/display/intel_color.c | 101 > ++- > drivers/gpu/drm/i915/display/intel_color.h | 1 + > drivers/gpu/drm/i915/display/intel_display.c | 31 ++- > drivers/gpu/drm/i915/display/intel_dpt.c | 2 + > drivers/gpu/drm/i915/display/intel_tc.c | 4 +- > drivers/gpu/drm/i915/gem/i915_gem_lmem.c | 3 +- > drivers/gpu/drm/i915/gem/i915_gem_object.h | 2 +- > drivers/gpu/drm/i915/gem/i915_gem_object_types.h | 3 + > drivers/gpu/drm/i915/gt/intel_rps.c | 38 + > drivers/gpu/drm/i915/gt/intel_rps.h | 4 +- > drivers/gpu/drm/i915/i915_perf.c | 14 ++-- > drivers/gpu/drm/i915/i915_perf_types.h | 6 ++ > drivers/gpu/drm/i915/i915_pmu.c | 10 +-- > 13 files changed, 177 insertions(+), 42 deletions(-) > > -- > Jani Nikula, Intel Open Source Graphics Center -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Re: [PULL] drm-intel-fixes
On Thu, Mar 23, 2023 at 12:46:27PM +0200, Jani Nikula wrote: > > Hi Dave & Daniel - > > Otherwise a fairly regular fixes pull, except for two things: > > First, I have not gotten CI results on this. I don't know what gives. > > Second, I missed adding the hwmon revert to the tag. I accidentally > picked up the commit for the previous pull, and it shouldn't have been > there. > > > BR, > Jani. > > > > drm-intel-fixes-2023-03-23: > drm/i915 fixes for v6.3-rc4: > - Fix an MTL workaround > - Fix fbdev obj locking before vma pin > - Fix state inheritance tracking in initial commit > - Fix missing GuC error capture codes > - Fix missing debug object activation > - Fix uc init late order relative to probe error injection > - Fix perf limit reasons formatting > - Fix vblank timestamp update on seamless M/N changes > > BR, > Jani. > > The following changes since commit e8d018dd0257f744ca50a729e3d042cf2ec9da65: > > Linux 6.3-rc3 (2023-03-19 13:27:55 -0700) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2023-03-23 Pulled, thanks. -Daniel > > for you to fetch changes up to 22aa20e4c5dcbe6fdc480eb4fb27039b1f43217f: > > Revert "drm/i915/hwmon: Enable PL1 power limit" (2023-03-20 12:31:01 +0200) > > > drm/i915 fixes for v6.3-rc4: > - Fix an MTL workaround > - Fix fbdev obj locking before vma pin > - Fix state inheritance tracking in initial commit > - Fix missing GuC error capture codes > - Fix missing debug object activation > - Fix uc init late order relative to probe error injection > - Fix perf limit reasons formatting > - Fix vblank timestamp update on seamless M/N changes > > > Andrzej Hajda (1): > drm/i915/gt: perform uc late init after probe error injection > > Ashutosh Dixit (1): > Revert "drm/i915/hwmon: Enable PL1 power limit" > > Badal Nilawar (1): > drm/i915/mtl: Disable MC6 for MTL A step > > John Harrison (1): > drm/i915/guc: Fix missing ecodes > > Nirmoy Das (1): > drm/i915/active: Fix missing debug object activation > > Radhakrishna Sripada (1): > drm/i915/mtl: Fix Wa_16015201720 implementation > > Tejas Upadhyay (1): > drm/i915/fbdev: lock the fbdev obj before vma pin > > Ville Syrjälä (2): > drm/i915: Preserve crtc_state->inherited during state clearing > drm/i915: Update vblank timestamping stuff on seamless M/N change > > Vinay Belgaumkar (1): > drm/i915: Fix format for perf_limit_reasons > > drivers/gpu/drm/i915/display/intel_crtc.c | 8 > drivers/gpu/drm/i915/display/intel_display.c | 1 + > drivers/gpu/drm/i915/display/intel_dmc.c | 26 - > drivers/gpu/drm/i915/display/intel_fbdev.c | 24 +-- > drivers/gpu/drm/i915/gt/intel_gt.c | 4 ++-- > drivers/gpu/drm/i915/gt/intel_gt_pm.c | 27 > -- > drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 2 +- > drivers/gpu/drm/i915/gt/intel_rc6.c| 8 > drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c | 22 + > drivers/gpu/drm/i915/gt/uc/intel_guc_rc.c | 13 + > drivers/gpu/drm/i915/i915_active.c | 3 +-- > drivers/gpu/drm/i915/i915_hwmon.c | 5 - > drivers/gpu/drm/i915/i915_reg.h| 17 +--- > 13 files changed, 88 insertions(+), 72 deletions(-) > > -- > Jani Nikula, Intel Open Source Graphics Center -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Re: [PULL] drm-intel-fixes
On Thu, Jan 05, 2023 at 03:02:20PM -0500, Rodrigo Vivi wrote: > Hi Dave and Daniel, > > Only GVT related fixes for this round. > > I have another fix queued for i915_vma_unbind_async from Nirmoy that will > target stable 5.18, but I figured it out late so I didn't run CI on that yet. > So I'm holding this for now. Maybe and extra PR tomorrow or it will > wait for the next week. > > Here goes drm-intel-fixes-2023-01-05: > > Only gvt-fixes: > - debugfs fixes (Zhenyu) > - fix up for vgpu status (Zhi) > - double free fix in split_2MB_gtt_entry (Zheng) > > Thanks, > Rodrigo. > > The following changes since commit 88603b6dc419445847923fcb7fe5080067a30f98: > > Linux 6.2-rc2 (2023-01-01 13:53:16 -0800) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2023-01-05 Pulled, thanks a lot. -Daniel > > for you to fetch changes up to 87809d3196c2a7a015ab80ca1cb8c19b659bc5f6: > > Merge tag 'gvt-fixes-2023-01-05' of https://github.com/intel/gvt-linux into > drm-intel-fixes (2023-01-05 08:03:38 -0500) > > > Only gvt-fixes: > - debugfs fixes (Zhenyu) > - fix up for vgpu status (Zhi) > - double free fix in split_2MB_gtt_entry (Zheng) > > > Dan Carpenter (1): > drm/i915: unpin on error in intel_vgpu_shadow_mm_pin() > > Rodrigo Vivi (1): > Merge tag 'gvt-fixes-2023-01-05' of https://github.com/intel/gvt-linux > into drm-intel-fixes > > Zheng Wang (1): > drm/i915/gvt: fix double free bug in split_2MB_gtt_entry > > Zhenyu Wang (2): > drm/i915/gvt: fix gvt debugfs destroy > drm/i915/gvt: fix vgpu debugfs clean in remove > > Zhi Wang (1): > drm/i915/gvt: use atomic operations to change the vGPU status > > drivers/gpu/drm/i915/gvt/debugfs.c | 36 > +++- > drivers/gpu/drm/i915/gvt/dmabuf.c| 3 ++- > drivers/gpu/drm/i915/gvt/gtt.c | 21 +++-- > drivers/gpu/drm/i915/gvt/gvt.h | 15 ++- > drivers/gpu/drm/i915/gvt/interrupt.c | 2 +- > drivers/gpu/drm/i915/gvt/kvmgt.c | 35 +-- > drivers/gpu/drm/i915/gvt/scheduler.c | 4 +++- > drivers/gpu/drm/i915/gvt/vgpu.c | 12 +--- > 8 files changed, 80 insertions(+), 48 deletions(-) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Re: [PULL] drm-intel-fixes
On Fri, Dec 30, 2022 at 04:59:38AM -0500, Rodrigo Vivi wrote:
> Hi Dave and Daniel,
>
> Here goes the initial fixes for 6.2.
>
> The most critical ones seems to be the evict fix from Matt and
> the MIPI DSI from Jani. Both targeting stable trees.
>
> I'm sorry for sending this on a Friday and not on a Thursday as
> usual. Where did this week go? Worst case this wait one week
> and I get it rebased and resent earlier next week.
>
> Where did 2022 go? Happy New Year!
Cheers to you too!
> Cheers,
> Rodrigo.
>
>
> drm-intel-fixes-2022-12-30:
> - fix TLB invalidation for DG2 and newer platforms. (Andrzej)
> - Remove __maybe_unused from mtl_info (Lucas)
> - improve the catch-all evict to handle lock contention (Matt Auld)
> - Fix two issues with over-size (GuC/HuC) firmware files (John)
> - Fix DSI resume issues on ICL+ (Jani)
>
> Thanks,
> Rodrigo.
>
> The following changes since commit 1b929c02afd37871d5afb9d498426f83432e71c2:
>
> Linux 6.2-rc1 (2022-12-25 13:41:39 -0800)
>
> are available in the Git repository at:
>
> git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2022-12-30
Pulled, I'll try to get it out for Linus to include it in -rc2 still.
> for you to fetch changes up to 6217e9f05a74df48c77ee68993d587cdfdb1feb7:
>
> drm/i915/dsi: fix MIPI_BKLT_EN_1 native GPIO index (2022-12-30 04:28:46
> -0500)
>
>
> - fix TLB invalidation for DG2 and newer platforms. (Andrzej)
> - Remove __maybe_unused from mtl_info (Lucas)
> - improve the catch-all evict to handle lock contention (Matt Auld)
Just a quick comment, this one has
Fixes: 7e00897be8bf ("drm/i915: Add object locking to i915_gem_evict_for_node
and i915_gem_evict_something, v2.")
but I don't think that's entirely accurate. I might mix up some details
(and today is not the day to dig these out) and it's been two years
already when I discussed this Maarten, but this issue is older. It got
introduced with the conversion to per-object locking, and then somewhat
artfully papered over with the async object pinning infrastructure (which
had the design issue of being flat out in violation of upstream locking
hierarchy).
In practice it makes no difference, because there's no way you can
backport any of this to a point before the locking rework from Maarten (or
alternatively, revert until the glorious struct_mutex days). A bit more
review on a core locking change like this would have been good though imo.
Cheers, Daniel
> - Fix two issues with over-size (GuC/HuC) firmware files (John)
> - Fix DSI resume issues on ICL+ (Jani)
>
>
> Andrzej Hajda (1):
> drm/i915: fix TLB invalidation for Gen12.50 video and compute engines
>
> Jani Nikula (2):
> drm/i915/dsi: add support for ICL+ native MIPI GPIO sequence
> drm/i915/dsi: fix MIPI_BKLT_EN_1 native GPIO index
>
> John Harrison (1):
> drm/i915/uc: Fix two issues with over-size firmware files
>
> Lucas De Marchi (1):
> drm/i915: Remove __maybe_unused from mtl_info
>
> Matthew Auld (1):
> drm/i915: improve the catch-all evict to handle lock contention
>
> drivers/gpu/drm/i915/display/intel_dsi_vbt.c| 94
> -
> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 59 +---
> drivers/gpu/drm/i915/gem/i915_gem_mman.c| 2 +-
> drivers/gpu/drm/i915/gt/intel_gt.c | 8 ++-
> drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c| 42 +++
> drivers/gpu/drm/i915/i915_gem_evict.c | 37 +++---
> drivers/gpu/drm/i915/i915_gem_evict.h | 4 +-
> drivers/gpu/drm/i915/i915_irq.c | 3 +
> drivers/gpu/drm/i915/i915_pci.c | 1 -
> drivers/gpu/drm/i915/i915_reg.h | 1 +
> drivers/gpu/drm/i915/i915_vma.c | 2 +-
> drivers/gpu/drm/i915/selftests/i915_gem_evict.c | 4 +-
> 12 files changed, 212 insertions(+), 45 deletions(-)
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Re: [PULL] drm-intel-fixes
On Sun, 2022-09-11 at 19:22 +0200, Jason A. Donenfeld wrote:
> Hi Rodrigo,
>
> On Thu, Sep 08, 2022 at 09:59:54AM -0400, Rodrigo Vivi wrote:
> > Hi Dave and Daniel,
> >
> > A few fixes, but most targeting stable.
> >
> > [...]
> >
> > Ville Syrjälä (2):
> > drm/i915: Implement WaEdpLinkRateDataReload
>
> Don't you need to revert d5929835080a60f9119d024fa42f315913942f76 in
> order for "drm/i915: Implement WaEdpLinkRateDataReload" to actually
> be
> useful/interesting? Otherwise, what's the point?
Unfortunately there was no clear indication on the revert patch for
the tool to pick, and I hadn't followed that front myself closely.
Should
483e3d87a37e ("Revert "drm/i915/display: Re-add check for low voltage
sku for max dp source rate"")
have a Fixes tag?
Or should dim consider all reverts as Fixes?
Anyway, I will cherry pick this to our fixes branch for propagation
this week.
Thanks for the heads up,
Rodrigo.
>
> Regards,
> Jason
Re: [PULL] drm-intel-fixes
On Thu, Sep 30, 2021 at 11:50:20AM +0300, Jani Nikula wrote: > > Hi Dave & Daniel - > > drm-intel-fixes-2021-09-30: > drm/i915 fixes for v5.15-rc4: > - Fix GVT scheduler ww lock usage > - Fix pdfdocs documentation build > - Fix request early tracepoints > - Fix an invalid warning from rps worker > > BR, > Jani. > > The following changes since commit 5816b3e6577eaa676ceb00a848f0fd65fe2adc29: > > Linux 5.15-rc3 (2021-09-26 14:08:19 -0700) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2021-09-30 > > for you to fetch changes up to 4b8bcaf8a6d6ab5db51e30865def5cb694eb2966: > > drm/i915: Remove warning from the rps worker (2021-09-27 12:46:40 +0300) Merged into drm-fixes, apologies for being a bit late, I was held up in a drm-misc-fixes chaos. -Daniel > > > drm/i915 fixes for v5.15-rc4: > - Fix GVT scheduler ww lock usage > - Fix pdfdocs documentation build > - Fix request early tracepoints > - Fix an invalid warning from rps worker > > > Akira Yokosawa (1): > drm/i915/guc, docs: Fix pdfdocs build error by removing nested grid > > Jani Nikula (1): > Merge tag 'gvt-fixes-2021-09-18' of https://github.com/intel/gvt-linux > into drm-intel-fixes > > Matthew Auld (1): > drm/i915/request: fix early tracepoints > > Tejas Upadhyay (1): > drm/i915: Remove warning from the rps worker > > Zhi A Wang (1): > drm/i915/gvt: fix the usage of ww lock in gvt scheduler. > > drivers/gpu/drm/i915/gt/intel_rps.c | 2 -- > drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h | 10 +- > drivers/gpu/drm/i915/gt/uc/abi/guc_communication_mmio_abi.h | 10 +- > drivers/gpu/drm/i915/gvt/scheduler.c| 4 ++-- > drivers/gpu/drm/i915/i915_request.c | 11 ++- > 5 files changed, 14 insertions(+), 23 deletions(-) > > -- > Jani Nikula, Intel Open Source Graphics Center -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Re: [PULL] drm-intel-fixes
On Thu, Apr 15, 2021 at 08:59:11AM -0400, Rodrigo Vivi wrote: > Hi Dave and Daniel, > > Here goes drm-intel-fixes-2021-04-15: > > Display panel & power related fixes: > > - Backlight fix (Lyude) > - Display watermark fix (Ville) > - VLV panel power fix (Hans) > > Thanks, > Rodrigo. > > The following changes since commit d434405aaab7d0ebc516b68a8fc4100922d7f5ef: > > Linux 5.12-rc7 (2021-04-11 15:16:13 -0700) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2021-04-15 > > for you to fetch changes up to aee6f25e9c911323aa89a200e1bb160c1613ed3d: > > drm/i915/display/vlv_dsi: Do not skip panel_pwr_cycle_delay when disabling > the panel (2021-04-12 08:00:33 -0400) Applied to drm-fixes, thanks for the pull. -Daniel > > > Display panel & power related fixes: > > - Backlight fix (Lyude) > - Display watermark fix (Ville) > - VLV panel power fix (Hans) > > > Hans de Goede (1): > drm/i915/display/vlv_dsi: Do not skip panel_pwr_cycle_delay when > disabling the panel > > Lyude Paul (1): > drm/i915/dpcd_bl: Don't try vesa interface unless specified by VBT > > Ville Syrjälä (1): > drm/i915: Don't zero out the Y plane's watermarks > > drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 1 - > drivers/gpu/drm/i915/display/vlv_dsi.c| 4 ++-- > drivers/gpu/drm/i915/intel_pm.c | 4 ++-- > 3 files changed, 4 insertions(+), 5 deletions(-) -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: [PULL] drm-intel-fixes
On Fri, Mar 12, 2021 at 11:36:51AM +1000, Dave Airlie wrote: > On Thu, 11 Mar 2021 at 21:28, Rodrigo Vivi wrote: > > > > Hi Dave and Daniel, > > > > Things are very quiet. Only 1 fix this round. > > Since I will be out next week, if this trend continues I will > > accumulate 2 weeks and send when in -rc4. > > > > Here goes drm-intel-fixes-2021-03-11: > > > > - Wedge the GPU if command parser setup fails (Tvrtko) > > > > Thanks, > > Rodrigo. > > > > The following changes since commit fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8: > > > > Linux 5.12-rc1 (2021-02-28 16:05:19 -0800) > > This was based on 5.12-rc1 against my request earlier in the week to > not do that. but since it was a single patch I just cherry-picked it > across. I'm really sorry about that! It is so unusual to have this low influx of patches at this round that I'm not used and end up forgetting to rebase. > > Can we make sure no fixes or next based on rc1 arrive please. Sure thing. > > Dave. ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: [PULL] drm-intel-fixes
On Thu, 11 Mar 2021 at 21:28, Rodrigo Vivi wrote: > > Hi Dave and Daniel, > > Things are very quiet. Only 1 fix this round. > Since I will be out next week, if this trend continues I will > accumulate 2 weeks and send when in -rc4. > > Here goes drm-intel-fixes-2021-03-11: > > - Wedge the GPU if command parser setup fails (Tvrtko) > > Thanks, > Rodrigo. > > The following changes since commit fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8: > > Linux 5.12-rc1 (2021-02-28 16:05:19 -0800) This was based on 5.12-rc1 against my request earlier in the week to not do that. but since it was a single patch I just cherry-picked it across. Can we make sure no fixes or next based on rc1 arrive please. Dave. ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: [PULL] drm-intel-fixes
On Thu, Jan 07, 2021 at 09:50:28AM +0200, Jani Nikula wrote: > > Hi Dave & Daniel - > > Pretty quiet still, but here's some cc: stable fixes. Pulled, thanks. -Daniel > > (Well, one doesn't have the explicit stable tag, but the Fixes tag > points at a commit in v3.9...) > > drm-intel-fixes-2021-01-07: > drm/i915 fixes for v5.11-rc3: > - Use per-connector PM QoS tracking for DP aux communication > - GuC firmware fix for older Cometlakes > - Clear the gpu reloc and shadow batches > > BR, > Jani. > > The following changes since commit e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62: > > Linux 5.11-rc2 (2021-01-03 15:55:30 -0800) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2021-01-07 > > for you to fetch changes up to 9397d66212cdf7a21c66523f1583e5d63a609e84: > > drm/i915/dp: Track pm_qos per connector (2021-01-05 10:25:03 +0200) > > > drm/i915 fixes for v5.11-rc3: > - Use per-connector PM QoS tracking for DP aux communication > - GuC firmware fix for older Cometlakes > - Clear the gpu reloc and shadow batches > > > Chris Wilson (2): > drm/i915/gt: Define guc firmware blob for older Cometlakes > drm/i915/dp: Track pm_qos per connector > > Matthew Auld (2): > drm/i915: clear the shadow batch > drm/i915: clear the gpu reloc batch > > drivers/gpu/drm/i915/display/intel_display_types.h | 3 +++ > drivers/gpu/drm/i915/display/intel_dp.c| 8 +-- > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 4 +++- > drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 + > drivers/gpu/drm/i915/i915_cmd_parser.c | 27 > -- > drivers/gpu/drm/i915/i915_drv.c| 5 > drivers/gpu/drm/i915/i915_drv.h| 3 --- > 7 files changed, 22 insertions(+), 29 deletions(-) > > -- > Jani Nikula, Intel Open Source Graphics Center -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: [PULL] drm-intel-fixes v2
On Wed, 2020-12-09 at 14:11 +0200, Ville Syrjälä wrote:
> On Thu, Dec 03, 2020 at 05:47:05AM -0800, Rodrigo Vivi wrote:
> > Hi Dave and Daniel,
> >
> > Please ignore the pull request I had sent yesterday and use only
> > this one.
> >
> > I had missed one patch: 14d1eaf08845 ("drm/i915/gt: Protect context
> > lifetime with RCU").
> >
> > Also, please notice that the commit 6db58901c2aa
> > ("drm/i915/display: return earlier from
> > +intel_modeset_init() without display") was not actually a crucial
> > fix, but it
> > +allowed a clean pick of the use-after-free one.
> >
> > Here goes drm-intel-fixes-2020-12-03:
> > Fixes for GPU hang, null dereference, suspend-resume, power
> > consumption, and use-after-free.
> >
> > - Program mocs:63 for cache eviction on gen9 (Chris)
> > - Protect context lifetime with RCU (Chris)
> > - Split the breadcrumb spinlock between global and contexts (Chris)
> > - Retain default context state across shrinking (Venkata)
> > - Limit frequency drop to RPe on parking (Chris)
> > - Return earlier from intel_modeset_init() without display (Jani)
> > - Defer initial modeset until after GGTT is initialized (Chris)
> >
> > Thanks,
> > Rodrigo.
> >
> > The following changes since commit
> > b65054597872ce3aefbc6a666385eabdf9e288da:
> >
> > Linux 5.10-rc6 (2020-11-29 15:50:50 -0800)
> >
> > are available in the Git repository at:
> >
> > git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-
> > 2020-12-03
> >
> > for you to fetch changes up to
> > ccc9e67ab26feda7e62749bb54c05d7abe07dca9:
> >
> > drm/i915/display: Defer initial modeset until after GGTT is
> > initialised (2020-12-02 17:05:58 -0800)
> >
> >
> > Fixes for GPU hang, null dereference, suspend-resume, power
> > consumption, and use-after-free.
> >
> > - Program mocs:63 for cache eviction on gen9 (Chris)
> > - Protect context lifetime with RCU (Chris)
> > - Split the breadcrumb spinlock between global and contexts (Chris)
> > - Retain default context state across shrinking (Venkata)
> > - Limit frequency drop to RPe on parking (Chris)
> > - Return earlier from intel_modeset_init() without display (Jani)
> > - Defer initial modeset until after GGTT is initialized (Chris)
> >
> >
> > Chris Wilson (5):
> > drm/i915/gt: Program mocs:63 for cache eviction on gen9
>
> That also needs
> commit 444fbf5d7058 ("drm/i915/gt: Declare gen9 has 64 mocs
> entries!")
> which seems to have not made it into this pull.
yeap, I'm sorry I have missed that one.
dim doesn't deal very well with fixes for fixes and I end up missing
that.
It is now on dif and will be part of this week's pull request.
Thanks for the heads up,
Rodrigo.
>
> > drm/i915/gt: Protect context lifetime with RCU
> > drm/i915/gt: Split the breadcrumb spinlock between global and
> > contexts
> > drm/i915/gt: Limit frequency drop to RPe on parking
> > drm/i915/display: Defer initial modeset until after GGTT is
> > initialised
> >
> > Jani Nikula (1):
> > drm/i915/display: return earlier from intel_modeset_init()
> > without display
> >
> > Venkata Ramana Nayana (1):
> > drm/i915/gt: Retain default context state across shrinking
> >
> > drivers/gpu/drm/i915/display/intel_display.c | 24 ++--
> > drivers/gpu/drm/i915/gt/intel_breadcrumbs.c | 168
> > ++
> > drivers/gpu/drm/i915/gt/intel_breadcrumbs_types.h | 6 +-
> > drivers/gpu/drm/i915/gt/intel_context.c | 15 +-
> > drivers/gpu/drm/i915/gt/intel_context_types.h | 23 ++-
> > drivers/gpu/drm/i915/gt/intel_mocs.c | 14 +-
> > drivers/gpu/drm/i915/gt/intel_rps.c | 4 +
> > drivers/gpu/drm/i915/gt/shmem_utils.c | 7 +-
> > drivers/gpu/drm/i915/i915_request.h | 6 +-
> > 9 files changed, 143 insertions(+), 124 deletions(-)
> > ___
> > dim-tools mailing list
> > dim-tools@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dim-tools
>
___
dim-tools mailing list
dim-tools@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: [PULL] drm-intel-fixes v2
On Thu, Dec 03, 2020 at 05:47:05AM -0800, Rodrigo Vivi wrote:
> Hi Dave and Daniel,
>
> Please ignore the pull request I had sent yesterday and use only this one.
>
> I had missed one patch: 14d1eaf08845 ("drm/i915/gt: Protect context lifetime
> with RCU").
>
> Also, please notice that the commit 6db58901c2aa ("drm/i915/display: return
> earlier from
> +intel_modeset_init() without display") was not actually a crucial fix, but it
> +allowed a clean pick of the use-after-free one.
>
> Here goes drm-intel-fixes-2020-12-03:
> Fixes for GPU hang, null dereference, suspend-resume, power consumption, and
> use-after-free.
>
> - Program mocs:63 for cache eviction on gen9 (Chris)
> - Protect context lifetime with RCU (Chris)
> - Split the breadcrumb spinlock between global and contexts (Chris)
> - Retain default context state across shrinking (Venkata)
> - Limit frequency drop to RPe on parking (Chris)
> - Return earlier from intel_modeset_init() without display (Jani)
> - Defer initial modeset until after GGTT is initialized (Chris)
>
> Thanks,
> Rodrigo.
>
> The following changes since commit b65054597872ce3aefbc6a666385eabdf9e288da:
>
> Linux 5.10-rc6 (2020-11-29 15:50:50 -0800)
>
> are available in the Git repository at:
>
> git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2020-12-03
>
> for you to fetch changes up to ccc9e67ab26feda7e62749bb54c05d7abe07dca9:
>
> drm/i915/display: Defer initial modeset until after GGTT is initialised
> (2020-12-02 17:05:58 -0800)
>
>
> Fixes for GPU hang, null dereference, suspend-resume, power consumption, and
> use-after-free.
>
> - Program mocs:63 for cache eviction on gen9 (Chris)
> - Protect context lifetime with RCU (Chris)
> - Split the breadcrumb spinlock between global and contexts (Chris)
> - Retain default context state across shrinking (Venkata)
> - Limit frequency drop to RPe on parking (Chris)
> - Return earlier from intel_modeset_init() without display (Jani)
> - Defer initial modeset until after GGTT is initialized (Chris)
>
>
> Chris Wilson (5):
> drm/i915/gt: Program mocs:63 for cache eviction on gen9
That also needs
commit 444fbf5d7058 ("drm/i915/gt: Declare gen9 has 64 mocs entries!")
which seems to have not made it into this pull.
> drm/i915/gt: Protect context lifetime with RCU
> drm/i915/gt: Split the breadcrumb spinlock between global and contexts
> drm/i915/gt: Limit frequency drop to RPe on parking
> drm/i915/display: Defer initial modeset until after GGTT is initialised
>
> Jani Nikula (1):
> drm/i915/display: return earlier from intel_modeset_init() without
> display
>
> Venkata Ramana Nayana (1):
> drm/i915/gt: Retain default context state across shrinking
>
> drivers/gpu/drm/i915/display/intel_display.c | 24 ++--
> drivers/gpu/drm/i915/gt/intel_breadcrumbs.c | 168
> ++
> drivers/gpu/drm/i915/gt/intel_breadcrumbs_types.h | 6 +-
> drivers/gpu/drm/i915/gt/intel_context.c | 15 +-
> drivers/gpu/drm/i915/gt/intel_context_types.h | 23 ++-
> drivers/gpu/drm/i915/gt/intel_mocs.c | 14 +-
> drivers/gpu/drm/i915/gt/intel_rps.c | 4 +
> drivers/gpu/drm/i915/gt/shmem_utils.c | 7 +-
> drivers/gpu/drm/i915/i915_request.h | 6 +-
> 9 files changed, 143 insertions(+), 124 deletions(-)
> ___
> dim-tools mailing list
> dim-tools@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dim-tools
--
Ville Syrjälä
Intel
___
dim-tools mailing list
dim-tools@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: [PULL] drm-intel-fixes
On Wed, Dec 02, 2020 at 04:36:24PM -0800, Rodrigo Vivi wrote:
> Hi Dave and Daniel,
>
> Fixes for GPU hang, null dereference, suspend-resume, power consumption, and
> use-after-free.
>
> The commit 6db58901c2aa ("drm/i915/display: return earlier from
> intel_modeset_init() without display") was not actually a crucial fix, but it
> allowed a clean pick of the use-after-free one.
>
> Here goes drm-intel-fixes-2020-12-02:
>
> Fixes for GPU hang, null dereference, suspend-resume, power consumption, and
> use-after-free.
>
> - Program mocs:63 for cache eviction on gen9 (Chris)
> - Split the breadcrumb spinlock between global and contexts (Chris)
Please ignore this for now. I was informed that I missed one patch
that helps this one here. So I'm going to push a new fixes branch now
and will prepare another pull request tomorrow.
> - Retain default context state across shrinking (Venkata)
> - Limit frequency drop to RPe on parking (Chris)
> - Return earlier from intel_modeset_init() without display (Jani)
> - Defer initial modeset until after GGTT is initialized (Chris).
>
> Thanks,
> Rodrigo.
>
> The following changes since commit b65054597872ce3aefbc6a666385eabdf9e288da:
>
> Linux 5.10-rc6 (2020-11-29 15:50:50 -0800)
>
> are available in the Git repository at:
>
> git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2020-12-02
>
> for you to fetch changes up to f2f2b21feadcb1eb08687a8b20dcf6442d22be18:
>
> drm/i915/display: Defer initial modeset until after GGTT is initialised
> (2020-12-01 08:36:37 -0800)
>
>
> Fixes for GPU hang, null dereference, suspend-resume, power consumption, and
> use-after-free.
>
> - Program mocs:63 for cache eviction on gen9 (Chris)
> - Split the breadcrumb spinlock between global and contexts (Chris)
> - Retain default context state across shrinking (Venkata)
> - Limit frequency drop to RPe on parking (Chris)
> - Return earlier from intel_modeset_init() without display (Jani)
> - Defer initial modeset until after GGTT is initialized (Chris).
>
>
> Chris Wilson (4):
> drm/i915/gt: Program mocs:63 for cache eviction on gen9
> drm/i915/gt: Split the breadcrumb spinlock between global and contexts
> drm/i915/gt: Limit frequency drop to RPe on parking
> drm/i915/display: Defer initial modeset until after GGTT is initialised
>
> Jani Nikula (1):
> drm/i915/display: return earlier from intel_modeset_init() without
> display
>
> Venkata Ramana Nayana (1):
> drm/i915/gt: Retain default context state across shrinking
>
> drivers/gpu/drm/i915/display/intel_display.c | 24 ++--
> drivers/gpu/drm/i915/gt/intel_breadcrumbs.c | 168
> ++
> drivers/gpu/drm/i915/gt/intel_breadcrumbs_types.h | 6 +-
> drivers/gpu/drm/i915/gt/intel_context.c | 3 +-
> drivers/gpu/drm/i915/gt/intel_context_types.h | 12 +-
> drivers/gpu/drm/i915/gt/intel_mocs.c | 14 +-
> drivers/gpu/drm/i915/gt/intel_rps.c | 4 +
> drivers/gpu/drm/i915/gt/shmem_utils.c | 7 +-
> drivers/gpu/drm/i915/i915_request.h | 6 +-
> 9 files changed, 124 insertions(+), 120 deletions(-)
___
dim-tools mailing list
dim-tools@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: [PULL] drm-intel-fixes
> On Nov 12, 2020, at 4:32 PM, Dave Airlie wrote: > > On Fri, 13 Nov 2020 at 09:08, Rodrigo Vivi wrote: >> >> Hi Dave and Daniel, >> >> This is the same set as last week + couple new fixes targeting stable. >> > > But I merged last weeks set and it's in rc3, maybe you can generate > the pull request relative to origin/master or drm/drm-fixes because > I'm not sure which bits to edit out here. oh, of course... bad rebase on my part. Sorry... Please ignore this one. I'm going to generate another one soon. > > Dave. > >> Thanks, >> Rodrigo. >> >> drm-intel-fixes-2020-11-12-1: >> - GVT fixes including vGPU suspend/resume fixes and workaround for APL guest >> GPU hang. >> - Fix set domain's cache coherency (Chris) >> - Fixes around breadcrumbs (Chris) >> - Fix encoder lookup during PSR atomic (Imre) >> - Hold onto an explicit ref to i915_vma_work.pinned (Chris) >> - Pull phys pread/pwrite implementations to the backend (Chris) >> - Correctly set SFC capability for video engines >> The following changes since commit 3cea11cd5e3b00d91caf0b4730194039b45c5891: >> >> Linux 5.10-rc2 (2020-11-01 14:43:51 -0800) >> >> are available in the Git repository at: >> >> git://anongit.freedesktop.org/drm/drm-intel >> tags/drm-intel-fixes-2020-11-12-1 >> >> for you to fetch changes up to a4264790f4c2f0062d27d8173344c914bc7884e0: >> >> drm/i915: Correctly set SFC capability for video engines (2020-11-12 >> 16:41:54 -0500) >> >> >> - GVT fixes including vGPU suspend/resume fixes and workaround for APL guest >> GPU hang. >> - Fix set domain's cache coherency (Chris) >> - Fixes around breadcrumbs (Chris) >> - Fix encoder lookup during PSR atomic (Imre) >> - Hold onto an explicit ref to i915_vma_work.pinned (Chris) >> - Pull phys pread/pwrite implementations to the backend (Chris) >> - Correctly set SFC capability for video engines >> >> >> Chris Wilson (6): >> drm/i915/gem: Flush coherency domains on first set-domain-ioctl >> drm/i915/gt: Use the local HWSP offset during submission >> drm/i915/gt: Expose more parameters for emitting writes into the ring >> drm/i915/gt: Flush xcs before tgl breadcrumbs >> drm/i915: Hold onto an explicit ref to i915_vma_work.pinned >> drm/i915/gem: Pull phys pread/pwrite implementations to the backend >> >> Colin Xu (4): >> drm/i915/gvt: Allow zero out HWSP addr on hws_pga_write >> drm/i915/gvt: Set SNOOP for PAT3 on BXT/APL to workaround GPU BB hang >> drm/i915/gvt: Only pin/unpin intel_context along with workload >> drm/i915/gvt: Fix mmio handler break on BXT/APL. >> >> Imre Deak (1): >> drm/i915: Fix encoder lookup during PSR atomic check >> >> Matthew Auld (1): >> drm/i915/gem: Allow backends to override pread implementation >> >> Venkata Sandeep Dhanalakota (1): >> drm/i915: Correctly set SFC capability for video engines >> >> drivers/gpu/drm/i915/display/intel_psr.c | 2 +- >> drivers/gpu/drm/i915/gem/i915_gem_domain.c | 28 ++-- >> drivers/gpu/drm/i915/gem/i915_gem_object_types.h | 2 + >> drivers/gpu/drm/i915/gem/i915_gem_phys.c | 55 >> >> drivers/gpu/drm/i915/gt/intel_engine.h | 55 >> +++- >> drivers/gpu/drm/i915/gt/intel_engine_cs.c| 3 +- >> drivers/gpu/drm/i915/gt/intel_lrc.c | 31 + >> drivers/gpu/drm/i915/gt/intel_timeline.c | 18 >> drivers/gpu/drm/i915/gt/intel_timeline_types.h | 2 + >> drivers/gpu/drm/i915/gvt/handlers.c | 47 ++-- >> drivers/gpu/drm/i915/gvt/scheduler.c | 15 --- >> drivers/gpu/drm/i915/i915_gem.c | 32 +++--- >> drivers/gpu/drm/i915/i915_vma.c | 6 ++- >> 13 files changed, 204 insertions(+), 92 deletions(-) ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: [PULL] drm-intel-fixes
On Fri, 13 Nov 2020 at 09:08, Rodrigo Vivi wrote: > > Hi Dave and Daniel, > > This is the same set as last week + couple new fixes targeting stable. > But I merged last weeks set and it's in rc3, maybe you can generate the pull request relative to origin/master or drm/drm-fixes because I'm not sure which bits to edit out here. Dave. > Thanks, > Rodrigo. > > drm-intel-fixes-2020-11-12-1: > - GVT fixes including vGPU suspend/resume fixes and workaround for APL guest > GPU hang. > - Fix set domain's cache coherency (Chris) > - Fixes around breadcrumbs (Chris) > - Fix encoder lookup during PSR atomic (Imre) > - Hold onto an explicit ref to i915_vma_work.pinned (Chris) > - Pull phys pread/pwrite implementations to the backend (Chris) > - Correctly set SFC capability for video engines > The following changes since commit 3cea11cd5e3b00d91caf0b4730194039b45c5891: > > Linux 5.10-rc2 (2020-11-01 14:43:51 -0800) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-intel > tags/drm-intel-fixes-2020-11-12-1 > > for you to fetch changes up to a4264790f4c2f0062d27d8173344c914bc7884e0: > > drm/i915: Correctly set SFC capability for video engines (2020-11-12 > 16:41:54 -0500) > > > - GVT fixes including vGPU suspend/resume fixes and workaround for APL guest > GPU hang. > - Fix set domain's cache coherency (Chris) > - Fixes around breadcrumbs (Chris) > - Fix encoder lookup during PSR atomic (Imre) > - Hold onto an explicit ref to i915_vma_work.pinned (Chris) > - Pull phys pread/pwrite implementations to the backend (Chris) > - Correctly set SFC capability for video engines > > > Chris Wilson (6): > drm/i915/gem: Flush coherency domains on first set-domain-ioctl > drm/i915/gt: Use the local HWSP offset during submission > drm/i915/gt: Expose more parameters for emitting writes into the ring > drm/i915/gt: Flush xcs before tgl breadcrumbs > drm/i915: Hold onto an explicit ref to i915_vma_work.pinned > drm/i915/gem: Pull phys pread/pwrite implementations to the backend > > Colin Xu (4): > drm/i915/gvt: Allow zero out HWSP addr on hws_pga_write > drm/i915/gvt: Set SNOOP for PAT3 on BXT/APL to workaround GPU BB hang > drm/i915/gvt: Only pin/unpin intel_context along with workload > drm/i915/gvt: Fix mmio handler break on BXT/APL. > > Imre Deak (1): > drm/i915: Fix encoder lookup during PSR atomic check > > Matthew Auld (1): > drm/i915/gem: Allow backends to override pread implementation > > Venkata Sandeep Dhanalakota (1): > drm/i915: Correctly set SFC capability for video engines > > drivers/gpu/drm/i915/display/intel_psr.c | 2 +- > drivers/gpu/drm/i915/gem/i915_gem_domain.c | 28 ++-- > drivers/gpu/drm/i915/gem/i915_gem_object_types.h | 2 + > drivers/gpu/drm/i915/gem/i915_gem_phys.c | 55 > > drivers/gpu/drm/i915/gt/intel_engine.h | 55 > +++- > drivers/gpu/drm/i915/gt/intel_engine_cs.c| 3 +- > drivers/gpu/drm/i915/gt/intel_lrc.c | 31 + > drivers/gpu/drm/i915/gt/intel_timeline.c | 18 > drivers/gpu/drm/i915/gt/intel_timeline_types.h | 2 + > drivers/gpu/drm/i915/gvt/handlers.c | 47 ++-- > drivers/gpu/drm/i915/gvt/scheduler.c | 15 --- > drivers/gpu/drm/i915/i915_gem.c | 32 +++--- > drivers/gpu/drm/i915/i915_vma.c | 6 ++- > 13 files changed, 204 insertions(+), 92 deletions(-) ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: [PULL] drm-intel-fixes
Quoting Joonas Lahtinen (2020-01-09 15:34:58) > Hi Dave & Daniel, > > Happy New Year, now back from the holiday break. > > A bunch of important fixes. Further fixes for the power/perf > regressions caused by the past security fixes. Then fix for > user reported GPU hang regression. Revert to avoid screen flicker > caused by HDA audio. Then missing two W/A and uninitialized uAPI > variable fix. Forgot to mention: Fix for GitLab issue #5: Avoid multiple WARN_ON on 2p2c display teardown Regards, Joonas ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: [PULL] drm-intel-fixes
Quoting Joonas Lahtinen (2019-12-19 12:46:35) > Hi Dave & Daniel, > > Another -rc, another CI fire due to regressions elsewhere. > > Our CI needed the following patches to get machines boot with -rc2: > > Revert "devtmpfs: use do_mount() instead of ksys_mount()" > (commit 5e787dbf659fe77d56215be74044f85e01b3920f) > > Revert "initrd: use do_mount() instead of ksys_mount()" > (commit d4440aac83d12f87df9bcc51e992b9c28c7f4fa5) > > Revert "init: use do_mount() instead of ksys_mount()" > (commit cccaa5e33525fc07f4a2ce0518e50b9ddf435e47) > > I have queued CI_DIF_433 with this PR contents + reverts to get any > CI results: > > https://intel-gfx-ci.01.org/tree/drm-intel-fixes/CI_DIF_433/git-log.txt > > Nothing appears in the UI for the failed-to-boot runs, so don't be > confused. CI_DIF_433 is equal to this PR + 3 reverts needed to mitigate > the -rc2 regressions. > > Due to the CI fires, it may take a while to get the full results. Due to > my holidays, I'll defer to Chris to let you know if the results are good > or not. There have been some GEM bugs tackled in drm-tip, so have to make > sure they are under control. Nothing unexpected turned up by CI, i.e. its as good as can be. -Chris ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: [PULL] drm-intel-fixes
On Thu, Oct 03, 2019 at 10:58:52AM -0700, Rodrigo Vivi wrote:
> Hi Dave and Daniel,
>
> I know you are on XDC and I was even considering not send any this week,
> but let me send this before I forget.
>
> There are the drm-intel-next-fixes pull requests that I had sent
> that are still needed and it would be good if you could pull those.
>
> Besides we have more 2 fixes here.
>
> If necessary and easier I can send all fixes together next week, including
> the ones missed on -rc1 and these ones here plus any upcoming.
>
> Just let me know how you prefer.
>
> Here goes drm-intel-fixes-2019-10-03:
>
> - Fix dsc dpp calculations
> - Fix g4x sprite scaling stride check with GTT remapping
Where is e838bfa8e170 ("Revert "drm/i915: Fix DP-MST crtc_mask"") ?
I can't see it in any fixes branch. That needs to get in ASAP.
>
> Thanks,
> Rodrigo.
>
> The following changes since commit 54ecb8f7028c5eb3d740bb82b0f1d90f2df63c5c:
>
> Linux 5.4-rc1 (2019-09-30 10:35:40 -0700)
>
> are available in the Git repository at:
>
> git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2019-10-03
>
> for you to fetch changes up to eb0192fed016db1c5a9701cd6ca47233ff4a43e5:
>
> drm/i915: Fix g4x sprite scaling stride check with GTT remapping
> (2019-10-02 22:20:33 -0700)
>
>
> - Fix dsc dpp calculations
> - Fix g4x sprite scaling stride check with GTT remapping
>
>
> Maarten Lankhorst (1):
> drm/i915/dp: Fix dsc bpp calculations, v5.
>
> Ville Syrjälä (1):
> drm/i915: Fix g4x sprite scaling stride check with GTT remapping
>
> drivers/gpu/drm/i915/display/intel_display.c | 12 +-
> drivers/gpu/drm/i915/display/intel_display.h | 2 +-
> drivers/gpu/drm/i915/display/intel_dp.c | 184
> ++-
> drivers/gpu/drm/i915/display/intel_dp.h | 6 +-
> drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +-
> drivers/gpu/drm/i915/display/intel_sprite.c | 5 +-
> 6 files changed, 110 insertions(+), 101 deletions(-)
> ___
> dim-tools mailing list
> dim-tools@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dim-tools
--
Ville Syrjälä
Intel
___
dim-tools mailing list
dim-tools@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: [PULL] drm-intel-fixes
On Thu, Aug 15, 2019 at 9:42 AM Jani Nikula wrote: > > > Hi Dave & Daniel - > > One use after free fix for GVT. > > It doesn't have a Link: tag because dim doesn't check that while > applying the pull, and, for some reason, it was also not checked when I > pushed out the branch. Possibly because it's in a merge? Anyway, I only > got the complaint when making the pull request, which is too late. Hm, sounds like the flag settings for the checker are wrong, for "foreign" trees dim doesn't insist on the Link: tag. So maybe need to flip that around to match what we do on the receiving end of a pull? -Daniel > > drm-intel-fixes-2019-08-15: > drm/i915 fixes for v5.4-rc5: > - GVT use-after-free fix > > BR, > Jani. > > The following changes since commit d45331b00ddb179e291766617259261c112db872: > > Linux 5.3-rc4 (2019-08-11 13:26:41 -0700) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2019-08-15 > > for you to fetch changes up to daa37200d48906d71c63ce178bf7d410b7e07082: > > Merge tag 'gvt-fixes-2019-08-13' of https://github.com/intel/gvt-linux into > drm-intel-fixes (2019-08-13 16:26:34 +0300) > > > drm/i915 fixes for v5.4-rc5: > - GVT use-after-free fix > > > Dan Carpenter (1): > drm/i915: Use after free in error path in intel_vgpu_create_workload() > > Jani Nikula (1): > Merge tag 'gvt-fixes-2019-08-13' of https://github.com/intel/gvt-linux > into drm-intel-fixes > > drivers/gpu/drm/i915/gvt/scheduler.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > -- > Jani Nikula, Intel Open Source Graphics Center -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: [PULL] drm-intel-fixes
Hi, > I apologize for not having fixes for a couple of weeks, and then showing > up late with a bunch of them. I saw Dave make the fixes pull to Linus > for -rc3 already, but I must humbly ask you to accommodate an extra > fixes pull. If there is an extra -rc3 fixes pull anyway it would be nice to also pick up the drm-misc-fixes patches to unbreak qemu stdvga fbcon. thanks, Gerd ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: [PULL] drm-intel-fixes
On Thu, Jun 13, 2019 at 12:32:39PM +0300, Jani Nikula wrote: > > Hi Dave, Daniel, on behalf of Joonas, > > drm-intel-fixes-2019-06-13: > drm/i915 fixes for v5.2-rc5: > - Fix DMC firmware input validation to avoid buffer overflow > - Fix perf register access whitelist for userspace > - Fix DSI panel on GPD MicroPC > - Fix per-pixel alpha with CCS > - Fix HDMI audio for SDVO Pulled, thanks. -Daniel > > BR, > Jani. > > The following changes since commit d1fdb6d8f6a4109a4263176c84b899076a5f8008: > > Linux 5.2-rc4 (2019-06-08 20:24:46 -0700) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2019-06-13 > > for you to fetch changes up to c5cc0bf870cfb80b27899e916b4397ce11c61d96: > > drm/i915/perf: fix whitelist on Gen10+ (2019-06-12 10:42:22 +0300) > > > drm/i915 fixes for v5.2-rc5: > - Fix DMC firmware input validation to avoid buffer overflow > - Fix perf register access whitelist for userspace > - Fix DSI panel on GPD MicroPC > - Fix per-pixel alpha with CCS > - Fix HDMI audio for SDVO > > > Hans de Goede (1): > drm/i915/dsi: Use a fuzzy check for burst mode clock check > > Lionel Landwerlin (1): > drm/i915/perf: fix whitelist on Gen10+ > > Lucas De Marchi (1): > drm/i915/dmc: protect against reading random memory > > Ville Syrjälä (2): > drm/i915: Fix per-pixel alpha with CCS > drm/i915/sdvo: Implement proper HDMI audio support for SDVO > > drivers/gpu/drm/i915/i915_perf.c | 1 + > drivers/gpu/drm/i915/i915_reg.h| 1 + > drivers/gpu/drm/i915/intel_csr.c | 18 +++ > drivers/gpu/drm/i915/intel_display.c | 14 +--- > drivers/gpu/drm/i915/intel_drv.h | 1 + > drivers/gpu/drm/i915/intel_dsi_vbt.c | 11 +++ > drivers/gpu/drm/i915/intel_sdvo.c | 58 > +++--- > drivers/gpu/drm/i915/intel_sdvo_regs.h | 3 ++ > 8 files changed, 91 insertions(+), 16 deletions(-) > > -- > Jani Nikula, Intel Open Source Graphics Center -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: [PULL] drm-intel-fixes
On Thu, 28 Mar 2019, Jani Nikula wrote: > Hi Dave and Daniel, a fairly normal fixes pull. > > drm-intel-fixes-2019-03-28: > drm/i915 fixes for v5.2-rc3: > - fix mmap range checks > - fix gvt ppgtt mm LRU list access races > - fix selftest error pointer check > - fix a macro definition (pre-emptive for potential further backports) > - fix one AML SKU ULX status Hum, the log dim opened in gitk failed to include some of the gvt changes listed in the changelog below. The gvt merge commit additionally lists: - Fix MI_FLUSH_DW cmd parser on index check (Zhenyu) - Fix Windows guest font render error (Colin) - Fix unexpected workload submission for inactive vGPU (Weinan) - Fix incorrect workload submission in error path (Zhenyu) - Fix warning for shadow ppgtt mm reclaim list walk with locking (Zhenyu) BR, Jani. > > BR, > Jani. > > The following changes since commit 000c4f90e3f0194eef218ff2c6a8fd8ca1de4313: > > drm/i915: Sanity check mmap length against object size (2019-03-18 13:59:42 > -0700) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2019-03-28 > > for you to fetch changes up to 26cdaac4793c49357d2c731f2190632cefb7efb1: > > drm/i915/icl: Fix VEBOX mismatch BUG_ON() (2019-03-28 15:36:40 +0200) > > > drm/i915 fixes for v5.2-rc3: > - fix mmap range checks > - fix gvt ppgtt mm LRU list access races > - fix selftest error pointer check > - fix a macro definition (pre-emptive for potential further backports) > - fix one AML SKU ULX status > > > Colin Xu (1): > drm/i915/gvt: Add in context mmio 0x20D8 to gen9 mmio list > > Dan Carpenter (1): > drm/i915/selftests: Fix an IS_ERR() vs NULL check > > José Roberto de Souza (1): > drm/i915/icl: Fix VEBOX mismatch BUG_ON() > > Manasi Navare (1): > drm/i915/icl: Fix the TRANS_DDI_FUNC_CTL2 bitfield macro > > Rodrigo Vivi (1): > Merge tag 'gvt-fixes-2019-03-21' of https://github.com/intel/gvt-linux > into drm-intel-fixes > > Ville Syrjälä (1): > drm/i915: Mark AML 0x87CA as ULX > > Weinan Li (1): > drm/i915/gvt: stop scheduling workload when vgpu is inactive > > Zhenyu Wang (4): > drm/i915/gvt: Fix MI_FLUSH_DW parsing with correct index check > drm/i915/gvt: Don't submit request for error workload dispatch > drm/i915/gvt: Only assign ppgtt root at dispatch time > drm/i915/gvt: Add mutual lock for ppgtt mm LRU list > > drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +- > drivers/gpu/drm/i915/gvt/gtt.c | 14 - > drivers/gpu/drm/i915/gvt/gtt.h | 1 + > drivers/gpu/drm/i915/gvt/mmio_context.c | 1 + > drivers/gpu/drm/i915/gvt/scheduler.c| 28 > ++--- > drivers/gpu/drm/i915/i915_drv.h | 3 ++- > drivers/gpu/drm/i915/i915_reg.h | 4 ++-- > drivers/gpu/drm/i915/selftests/i915_gem_evict.c | 2 +- > 8 files changed, 41 insertions(+), 14 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: [PULL] drm-intel-fixes
On Fri, Jan 11, 2019 at 11:18:22AM +0200, Jani Nikula wrote: > > Hi Dave & Daniel - > > drm-intel-fixes-2019-01-11: > i915 fixes for v5.0-rc2: > - Disable PSR for Apple panels > - Broxton ERR_PTR error state fix > - Kabylake VECS workaround fix > - Unwind failure on pinning the gen7 ppgtt > - GVT workload request allocation fix Applied, thanks. -Daniel > > BR, > Jani. > > The following changes since commit bfeffd155283772bbe78c6a05dec7c0128ee500c: > > Linux 5.0-rc1 (2019-01-06 17:08:20 -0800) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2019-01-11 > > for you to fetch changes up to f299e0bdbaeb60fd8829f42e53a7457cc5a6f4a2: > > drm: Fix documentation generation for DP_DPCD_QUIRK_NO_PSR (2019-01-10 > 15:12:48 +0200) > > > i915 fixes for v5.0-rc2: > - Disable PSR for Apple panels > - Broxton ERR_PTR error state fix > - Kabylake VECS workaround fix > - Unwind failure on pinning the gen7 ppgtt > - GVT workload request allocation fix > > > Chris Wilson (2): > drm/i915: Skip the ERR_PTR error state > drm/i915: Unwind failure on pinning the gen7 ppgtt > > Daniele Ceraolo Spurio (1): > drm/i915: init per-engine WAs for all engines > > Jani Nikula (1): > Merge tag 'gvt-fixes-2019-01-09' of https://github.com/intel/gvt-linux > into drm-intel-fixes > > José Roberto de Souza (2): > drm/i915: Disable PSR in Apple panels > drm: Fix documentation generation for DP_DPCD_QUIRK_NO_PSR > > Zhenyu Wang (1): > drm/i915/gvt: Fix workload request allocation before request add > > drivers/gpu/drm/drm_dp_helper.c | 2 ++ > drivers/gpu/drm/i915/gvt/scheduler.c | 64 > +++ > drivers/gpu/drm/i915/gvt/scheduler.h | 1 + > drivers/gpu/drm/i915/i915_debugfs.c | 12 +-- > drivers/gpu/drm/i915/i915_gem_gtt.c | 15 ++-- > drivers/gpu/drm/i915/i915_gpu_error.c | 23 - > drivers/gpu/drm/i915/i915_sysfs.c | 4 ++- > drivers/gpu/drm/i915/intel_lrc.c | 3 +- > drivers/gpu/drm/i915/intel_psr.c | 6 > include/drm/drm_dp_helper.h | 7 > 10 files changed, 98 insertions(+), 39 deletions(-) > > -- > Jani Nikula, Intel Open Source Graphics Center -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
