Re: [jQuery] Thickbox to be updated?
The position:fixed mod just made it so you could never see that the overlay actually ended at the fold on scrolling pages. If you resized the window larger, you could see the end of the overlay. I also had the same issue as Sam's example, where the overlay is matching the html height and not the viewport height. Also, it doesn't account for the body margins, which is why it's a little bit short of the end of the html. Here are the comments from my mod (which uses many other mods) to show what I did, or at least what I could remember: /* * Modified November/December, 2006 - agent2026 * Added fixed positioning to eliminate javasrcript scrolling of thickbox - Klaus Hartl * Changed Overlay width/height to 100% in thickbox.css to eliminate window resize issues * Removed all instances of TB_overlaySize() - no longer required * Effectively removed setting of #TB_HideSelect width/height * Added 'jamie hack' for circular browsing and click = next - Thanks Jamie. * Added blur (onFocus='this.blur()') to prev, next, close, and images * - adding blur inadvertantly 'fixed' vertical jump bug in FF 2.0, present after 'click = next' mod * Made 'A Smoother ThickBox (with less code)' refinements - Klaus Hartl */ Can't close the Thickbox in either example when I just checked it FF2 btw. Check out http://codylindley.com/thickboxforum/ if you haven't already. Adam Klaus Hartl wrote: > > Sam Collett schrieb: >> An example of why I can't really use Thickbox: >> http://www.texotela.co.uk/code/jquery/thickbox/ > > This should be fixed with my position:fixed mod...? > > http://www.stilbuero.de/2006/11/06/a-smoother-thickbox-with-less-code/ > > > -- Klaus > > > ___ > jQuery mailing list > discuss@jquery.com > http://jquery.com/discuss/ > > -- View this message in context: http://www.nabble.com/Thickbox-to-be-updated--tf2920866.html#a8255370 Sent from the JQuery mailing list archive at Nabble.com. ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] Thickbox to be updated?
Sam Collett schrieb: > An example of why I can't really use Thickbox: > http://www.texotela.co.uk/code/jquery/thickbox/ This should be fixed with my position:fixed mod...? http://www.stilbuero.de/2006/11/06/a-smoother-thickbox-with-less-code/ -- Klaus ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] Thickbox to be updated?
An example of why I can't really use Thickbox: http://www.texotela.co.uk/code/jquery/thickbox/ ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] Thickbox to be updated?
Hi Sam, As far as I could tell the overlay issue was there from from the beginning, and isn't related to a newer version of jQuery. You will also have issues here if you add any margin to the body of your page. I tried to sort this with my mod, but gave in and dumped my margins in the end. The transparency works in IE6 by the way, just not in the standalone. Adam Sam Collett wrote: > > Is this likely to be updated? The last version was for 1.0.2 of jQuery > and I have come across a few bugs with it. For instance, I tried it on > a page with little content and the overlay did not cover everything > (i.e. white background at the bottom). Also, if you shrink the browser > (tested on Firefox 2), click a thickbox link and resize, the overlay > doesn't cover everything. There is also no transparency in IE 6 > (although I am running it standalone) > > I browsed the SVN repository and do not see it there (I thought it > might have been as the demo is hosted on the jQuery site). > > There was a mod by agent2026 posted at the start of December, which > works fine for me (still has the transparency issue though). > > ___ > jQuery mailing list > discuss@jquery.com > http://jquery.com/discuss/ > > -- View this message in context: http://www.nabble.com/Thickbox-to-be-updated--tf2920866.html#a8175037 Sent from the JQuery mailing list archive at Nabble.com. ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
[jQuery] Thickbox to be updated?
Is this likely to be updated? The last version was for 1.0.2 of jQuery and I have come across a few bugs with it. For instance, I tried it on a page with little content and the overlay did not cover everything (i.e. white background at the bottom). Also, if you shrink the browser (tested on Firefox 2), click a thickbox link and resize, the overlay doesn't cover everything. There is also no transparency in IE 6 (although I am running it standalone) I browsed the SVN repository and do not see it there (I thought it might have been as the demo is hosted on the jQuery site). There was a mod by agent2026 posted at the start of December, which works fine for me (still has the transparency issue though). ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
