Re: [jQuery] New Plugin: jMP3
Very nice. Good looking as well. A comment. - I know that this is probably a user thing, but you need to implement the IE Flash fix on your examples. You might even consider merging it in with your codebase. !//-- andy matthews web developer certified advanced coldfusion programmer ICGLink, Inc. [EMAIL PROTECTED] 615.370.1530 x737 --//- -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Behalf Of Sean O Sent: Tuesday, October 10, 2006 9:18 AM To: discuss@jquery.com Subject: [jQuery] New Plugin: jMP3 Hi, I've created a new jQuery plugin, jMP3, to easily make MP3s playable directly on most any web site. Information, demos and code: http://www.sean-o.com/jquery/jmp3/ Let me know what you think. It's my first plugin, so be gentle! SEAN O -- View this message in context: http://www.nabble.com/New-Plugin%3A-jMP3-tf2416968.html#a6737375 Sent from the JQuery mailing list archive at Nabble.com. ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/ ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] New Plugin: jMP3
Hi Andy, Thanks for the compliments. The IE Flash Fix is a known issue -- the Eolas workaround I reference on the plugin page under Plugin Information. I've tried combinations of the suggestions on http://jquery.com/docs/Cookbook/, but nothing seems to work. There are a few .js files that claim to get around this, but I'd rather not have to include another script. ___ SEAN O Andy Matthews wrote: Very nice. Good looking as well. A comment. - I know that this is probably a user thing, but you need to implement the IE Flash fix on your examples. You might even consider merging it in with your codebase. !//-- andy matthews web developer certified advanced coldfusion programmer ICGLink, Inc. [EMAIL PROTECTED] 615.370.1530 x737 --//- -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Behalf Of Sean O Sent: Tuesday, October 10, 2006 9:18 AM To: discuss@jquery.com Subject: [jQuery] New Plugin: jMP3 Hi, I've created a new jQuery plugin, jMP3, to easily make MP3s playable directly on most any web site. Information, demos and code: http://www.sean-o.com/jquery/jmp3/ Let me know what you think. It's my first plugin, so be gentle! SEAN O -- View this message in context: http://www.nabble.com/New-Plugin%3A-jMP3-tf2416968.html#a6737375 Sent from the JQuery mailing list archive at Nabble.com. ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/ ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/ -- View this message in context: http://www.nabble.com/New-Plugin%3A-jMP3-tf2416968.html#a6739721 Sent from the JQuery mailing list archive at Nabble.com. ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] New Plugin: jMP3
Try replacing your eolas thing at the bottom of your loop with this:
If(jQuery.browser.msie){
$(this).html($(this).html());
}
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On
Behalf Of Sean O
Sent: Tuesday, October 10, 2006 11:09 AM
To: discuss@jquery.com
Subject: Re: [jQuery] New Plugin: jMP3
Hi Andy,
Thanks for the compliments.
The IE Flash Fix is a known issue -- the Eolas workaround I reference
on
the plugin page under Plugin Information. I've tried combinations of
the
suggestions on http://jquery.com/docs/Cookbook/, but nothing seems to
work.
There are a few .js files that claim to get around this, but I'd rather
not
have to include another script.
___
SEAN O
Andy Matthews wrote:
Very nice. Good looking as well. A comment.
- I know that this is probably a user thing, but you need to implement
the
IE Flash fix on your examples. You might even consider merging it in
with
your codebase.
!//--
andy matthews
web developer
certified advanced coldfusion programmer
ICGLink, Inc.
[EMAIL PROTECTED]
615.370.1530 x737
--//-
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
Behalf Of Sean O
Sent: Tuesday, October 10, 2006 9:18 AM
To: discuss@jquery.com
Subject: [jQuery] New Plugin: jMP3
Hi,
I've created a new jQuery plugin, jMP3, to easily make MP3s playable
directly on most any web site.
Information, demos and code:
http://www.sean-o.com/jquery/jmp3/
Let me know what you think. It's my first plugin, so be gentle!
SEAN O
--
View this message in context:
http://www.nabble.com/New-Plugin%3A-jMP3-tf2416968.html#a6737375
Sent from the JQuery mailing list archive at Nabble.com.
___
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/
___
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/
--
View this message in context:
http://www.nabble.com/New-Plugin%3A-jMP3-tf2416968.html#a6739721
Sent from the JQuery mailing list archive at Nabble.com.
___
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/
___
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/
Re: [jQuery] New Plugin: jMP3
Oh wait, no, that won't work. You'd need:
if(jQuery.browser.msie){
this.outerHTML = this.outerHTML;
}
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On
Behalf Of Kurt Mackey
Sent: Tuesday, October 10, 2006 11:16 AM
To: jQuery Discussion.
Subject: Re: [jQuery] New Plugin: jMP3
Try replacing your eolas thing at the bottom of your loop with this:
If(jQuery.browser.msie){
$(this).html($(this).html());
}
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On
Behalf Of Sean O
Sent: Tuesday, October 10, 2006 11:09 AM
To: discuss@jquery.com
Subject: Re: [jQuery] New Plugin: jMP3
Hi Andy,
Thanks for the compliments.
The IE Flash Fix is a known issue -- the Eolas workaround I reference
on
the plugin page under Plugin Information. I've tried combinations of
the
suggestions on http://jquery.com/docs/Cookbook/, but nothing seems to
work.
There are a few .js files that claim to get around this, but I'd rather
not
have to include another script.
___
SEAN O
Andy Matthews wrote:
Very nice. Good looking as well. A comment.
- I know that this is probably a user thing, but you need to implement
the
IE Flash fix on your examples. You might even consider merging it in
with
your codebase.
!//--
andy matthews
web developer
certified advanced coldfusion programmer
ICGLink, Inc.
[EMAIL PROTECTED]
615.370.1530 x737
--//-
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
Behalf Of Sean O
Sent: Tuesday, October 10, 2006 9:18 AM
To: discuss@jquery.com
Subject: [jQuery] New Plugin: jMP3
Hi,
I've created a new jQuery plugin, jMP3, to easily make MP3s playable
directly on most any web site.
Information, demos and code:
http://www.sean-o.com/jquery/jmp3/
Let me know what you think. It's my first plugin, so be gentle!
SEAN O
--
View this message in context:
http://www.nabble.com/New-Plugin%3A-jMP3-tf2416968.html#a6737375
Sent from the JQuery mailing list archive at Nabble.com.
___
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/
___
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/
--
View this message in context:
http://www.nabble.com/New-Plugin%3A-jMP3-tf2416968.html#a6739721
Sent from the JQuery mailing list archive at Nabble.com.
___
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/
___
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/
___
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/
Re: [jQuery] New Plugin: jMP3
On 10/10/06, Sean O [EMAIL PROTECTED] wrote: Hi, I've created a new jQuery plugin, jMP3, to easily make MP3s playable directly on most any web site. Information, demos and code: http://www.sean-o.com/jquery/jmp3/ Let me know what you think. It's my first plugin, so be gentle! SEAN O I would suggest that you use jQuery(...) instead of $(...) so as to prevent possible conflicts in the future. It is mentioned on the Plugins/Authoring (http://jquery.com/docs/Plugins/Authoring/) page (although it could be more prominant). ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] New Plugin: jMP3
Ok, rather than keep guessing, I actually tried things out until one
worked. Put this in place of your current eolas thing:
if(jQuery.browser.msie){
$(this).children('object').each(function(){
this.outerHTML = this.outerHTML;
});
}
Verified to work in IE6. :)
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On
Behalf Of Sean O
Sent: Tuesday, October 10, 2006 11:09 AM
To: discuss@jquery.com
Subject: Re: [jQuery] New Plugin: jMP3
Hi Andy,
Thanks for the compliments.
The IE Flash Fix is a known issue -- the Eolas workaround I reference
on
the plugin page under Plugin Information. I've tried combinations of
the
suggestions on http://jquery.com/docs/Cookbook/, but nothing seems to
work.
There are a few .js files that claim to get around this, but I'd rather
not
have to include another script.
___
SEAN O
Andy Matthews wrote:
Very nice. Good looking as well. A comment.
- I know that this is probably a user thing, but you need to implement
the
IE Flash fix on your examples. You might even consider merging it in
with
your codebase.
!//--
andy matthews
web developer
certified advanced coldfusion programmer
ICGLink, Inc.
[EMAIL PROTECTED]
615.370.1530 x737
--//-
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
Behalf Of Sean O
Sent: Tuesday, October 10, 2006 9:18 AM
To: discuss@jquery.com
Subject: [jQuery] New Plugin: jMP3
Hi,
I've created a new jQuery plugin, jMP3, to easily make MP3s playable
directly on most any web site.
Information, demos and code:
http://www.sean-o.com/jquery/jmp3/
Let me know what you think. It's my first plugin, so be gentle!
SEAN O
--
View this message in context:
http://www.nabble.com/New-Plugin%3A-jMP3-tf2416968.html#a6737375
Sent from the JQuery mailing list archive at Nabble.com.
___
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/
___
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/
--
View this message in context:
http://www.nabble.com/New-Plugin%3A-jMP3-tf2416968.html#a6739721
Sent from the JQuery mailing list archive at Nabble.com.
___
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/
___
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/
Re: [jQuery] New Plugin: jMP3
Kurt,
That worked a treat, thanks. .html() is what I had tried before.
I've updated the plugin to v0.2.1 (bugfix) based on yours Sam's
suggestions.
http://www.sean-o.com/jquery/jmp3/
___
SEAN O
Kurt Mackey wrote:
Oh wait, no, that won't work. You'd need:
if(jQuery.browser.msie){
this.outerHTML = this.outerHTML;
}
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On
Behalf Of Kurt Mackey
Sent: Tuesday, October 10, 2006 11:16 AM
To: jQuery Discussion.
Subject: Re: [jQuery] New Plugin: jMP3
Try replacing your eolas thing at the bottom of your loop with this:
If(jQuery.browser.msie){
$(this).html($(this).html());
}
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On
Behalf Of Sean O
Sent: Tuesday, October 10, 2006 11:09 AM
To: discuss@jquery.com
Subject: Re: [jQuery] New Plugin: jMP3
Hi Andy,
Thanks for the compliments.
The IE Flash Fix is a known issue -- the Eolas workaround I reference
on
the plugin page under Plugin Information. I've tried combinations of
the
suggestions on http://jquery.com/docs/Cookbook/, but nothing seems to
work.
There are a few .js files that claim to get around this, but I'd rather
not
have to include another script.
___
SEAN O
Andy Matthews wrote:
Very nice. Good looking as well. A comment.
- I know that this is probably a user thing, but you need to implement
the
IE Flash fix on your examples. You might even consider merging it in
with
your codebase.
!//--
andy matthews
web developer
certified advanced coldfusion programmer
ICGLink, Inc.
[EMAIL PROTECTED]
615.370.1530 x737
--//-
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
Behalf Of Sean O
Sent: Tuesday, October 10, 2006 9:18 AM
To: discuss@jquery.com
Subject: [jQuery] New Plugin: jMP3
Hi,
I've created a new jQuery plugin, jMP3, to easily make MP3s playable
directly on most any web site.
Information, demos and code:
http://www.sean-o.com/jquery/jmp3/
Let me know what you think. It's my first plugin, so be gentle!
SEAN O
--
View this message in context:
http://www.nabble.com/New-Plugin%3A-jMP3-tf2416968.html#a6737375
Sent from the JQuery mailing list archive at Nabble.com.
___
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/
___
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/
--
View this message in context:
http://www.nabble.com/New-Plugin%3A-jMP3-tf2416968.html#a6739721
Sent from the JQuery mailing list archive at Nabble.com.
___
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/
___
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/
___
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/
--
View this message in context:
http://www.nabble.com/New-Plugin%3A-jMP3-tf2416968.html#a6740701
Sent from the JQuery mailing list archive at Nabble.com.
___
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/
Re: [jQuery] New Plugin: jMP3
Hi Jörn, Jörn Zaefferer wrote: What I like about it: It works on Opera 8.54 9.02 and IE7RC1, too. Clean and structured code, good examples provided. There were some updates to the Plugins/Authoring guide which you may want to include. Thanks for the browser tests. I'm sure Safari will crap out. (will test tonight at home) What I don't like: You extracted the playerpath, but not the name of the player object itself: Would be nice to have that extracted into the playerpath. The code to create the object element is quite clumsy. For performance reasons, you should use an array with join(). For code readability, something else is necessary, but I haven't a good solution for this at hand. It is not unobtrusive: I don't get anything useful without JS, though no JS is necessary for the flash object. It's true that the object code is quite clumsy, but this should be handled by a plugin or template on the server-side. This point makes your plugin pretty useless on sites, that don't strictly require JS. In that case, your plugin is nice, because you don't have to implement the plugin for every server-side scripting language available... Whew! Good thing I said 'be gentle!' LOL Just kidding. I appreciate the time taken to look over my work. This is my first attempt at a plugin. I'm primarily a server-side guy. I only did it out of my sheer excitement for jQuery, and the desire to give a little back. I think I saw an array join-vs.-concatenate JS performance article before... I'll probably do that first. I've removed the unobtrusive feature line... Unobtrusive != Doesn't Work haha. I'm not sure I get what you're saying about the object element/code... I just did a quickie concatenation, which I knew was not optimal. I'll read up more on that for my next plugin ;) Thanks, SEAN O -- View this message in context: http://www.nabble.com/New-Plugin%3A-jMP3-tf2416968.html#a6742878 Sent from the JQuery mailing list archive at Nabble.com. ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] New Plugin: jMP3
Can I see the FLA file?-- YehudaOn 10/10/06, Sean O [EMAIL PROTECTED] wrote: Hi,I've created a new jQuery plugin, jMP3, to easily make MP3s playabledirectly on most any web site.Information, demos and code:http://www.sean-o.com/jquery/jmp3/ Let me know what you think.It's my first plugin, so be gentle!SEAN O--View this message in context: http://www.nabble.com/New-Plugin%3A-jMP3-tf2416968.html#a6737375 Sent from the JQuery mailing list archive at Nabble.com.___jQuery mailing listdiscuss@jquery.com http://jquery.com/discuss/-- Yehuda KatzWeb Developer | Wycats Designs(ph)718.877.1325 ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
Re: [jQuery] New Plugin: jMP3
Yehuda, I believe the FLA source file is available in the player download: http://jeroenwijering.com/upload/flash_single_mp3_player.zip The author also has a player for multiple files/playlists: http://jeroenwijering.com/?item=Flash_MP3_Player Looks like he includes the source for this as well. ___ SEAN O wycats wrote: Can I see the FLA file? -- Yehuda -- View this message in context: http://www.nabble.com/New-Plugin%3A-jMP3-tf2416968.html#a6743801 Sent from the JQuery mailing list archive at Nabble.com. ___ jQuery mailing list discuss@jquery.com http://jquery.com/discuss/
