RE: Patches for Adding/Removing Hosts between Component Restarts

2007-08-18 Thread Jerome Louvel

Hi all,

I've just applied Alex's patch to SVN trunk and 1.0 branch.

I've also entered the suggested RFE:
http://restlet.tigris.org/issues/show_bug.cgi?id=349

Best regards,
Jerome  

> -Message d'origine-
> De : Rob Heittman [mailto:[EMAIL PROTECTED] 
> Envoyé : vendredi 17 août 2007 03:11
> À : discuss@restlet.tigris.org
> Objet : RE: Patches for Adding/Removing Hosts between 
> Component Restarts
> 
> This is a requirement of our application as well.  Thanks for 
> the patches ... this will hold us short term.
> 
> -Original Message-
> From: "Alex Milowski" <[EMAIL PROTECTED]>
> To: discuss@restlet.tigris.org
> Sent: 8/16/07 6:25 PM
> Subject: Patches for Adding/Removing Hosts between Component Restarts
> 
> I've been experimenting with adding and removing host on a 
> running server and
> have run into some problems.  I've attached two patches that 
> gets you part of
> the way.  With these patches, you can now add or remove VirtualHost
> instances from the Component and then just call stop() and start() to
> restart the
> component.
> 
> Taking a look at the code, this is much heavier than it 
> should be because at
> the heart of this is a Router instance.  If you could just "reload"
> the ServerRouter
> instance in the ComponentHelper class, you wouldn't actually 
> have stop the
> server.  Unfortunately, that field is private and not available via
> public methods
> on the Component class.
> 
> I suggest this is filed as an enhancement to provide a way to "reload"
> the virtual
> hosts from the host list.  It should be very easy to implement but
> probably requires
> a special method on Component.
> 
> --Alex Milowski


RE: Patches for Adding/Removing Hosts between Component Restarts

2007-08-16 Thread Rob Heittman
This is a requirement of our application as well.  Thanks for the patches ... 
this will hold us short term.

-Original Message-
From: "Alex Milowski" <[EMAIL PROTECTED]>
To: discuss@restlet.tigris.org
Sent: 8/16/07 6:25 PM
Subject: Patches for Adding/Removing Hosts between Component Restarts

I've been experimenting with adding and removing host on a running server and
have run into some problems.  I've attached two patches that gets you part of
the way.  With these patches, you can now add or remove VirtualHost
instances from the Component and then just call stop() and start() to
restart the
component.

Taking a look at the code, this is much heavier than it should be because at
the heart of this is a Router instance.  If you could just "reload"
the ServerRouter
instance in the ComponentHelper class, you wouldn't actually have stop the
server.  Unfortunately, that field is private and not available via
public methods
on the Component class.

I suggest this is filed as an enhancement to provide a way to "reload"
the virtual
hosts from the host list.  It should be very easy to implement but
probably requires
a special method on Component.

--Alex Milowski