RE: Re: Re: Tomcat appears to swallow Allow: header
Hi Rob,
That is really weird, I've checked the again code in branch 1.1 and in trunk :
both are identical. The changes were only made in the
ServletCall#sendResponse() method.
I would suggest to double check that your 1.1 build does contain the fix or to
trace it down manually. Let me know!
Best regards,
Jerome Louvel
--
Restlet ~ Founder and Lead developer ~ http://www.restlet.org
Noelios Technologies ~ Co-founder ~ http://www.noelios.com
-Message d'origine-
De : Rob Heittman [mailto:rob.heitt...@solertium.com]
Envoye : lundi 19 janvier 2009 01:46
A : discuss@restlet.tigris.org
Objet : Re: Re: Re: Tomcat appears to swallow Allow: header
Hi, Jerome!
Turns out that, while 1.2 snapshot *does* fix the issue in GWT and
Tomcat 5, 1.1 snapshot *does not* fix it. I'm at a bit of a loss as
to how to troubleshoot beyond that. Where was the change mainly
applied?
- R
On Wed, Jan 14, 2009 at 7:51 AM, Jerome Louvel
wrote:
> Awesome!! The fix has been apply to the 1.1 branch in SVN. Thanks Rob for
> testing this.
>
> Thierry has fixed the redirect issue. FYI, there is a browsable directory
> with all the releases available. Useful if you need a
> snapshot of 1.1 branch :-)
> http://www.restlet.org/downloads/archives
>
> Best regards,
> Jerome Louvel
> --
> Restlet ~ Founder and Lead developer ~ http://www.restlet.org
> Noelios Technologies ~ Co-founder ~ http://www.noelios.com
>
>
> -Message d'origine-
> De : Rob Heittman [mailto:rob.heitt...@solertium.com]
> Envoye : mercredi 14 janvier 2009 02:41
> A : discuss@restlet.tigris.org
> Objet : Re: Re: Re: Tomcat appears to swallow Allow: header
>
> Much weeping and gnashing of teeth later ... I took out the entity
> hacks from GoGoEgo, ran on Restlet 1.1, observed the Tomcat problems
> under GWT hosted mode, ported to Restlet 1.2 snapshot, took out the
> entity hacks, and am not seeing the adverse behavior. Barring a more
> scientific analysis ... I think this fix really solves the problem!
> Sweet!
>
> Unrelated - did you know that when you download snapshot ("development
> version - unstable") from www.restlet.org/downloads you get redirected
> to the 1.1 snapshot? This is a bit confusing :-) I had to guess the
> URL for the 1.2 snapshot.
>
> On Tue, Jan 13, 2009 at 5:31 PM, Jerome Louvel
> wrote:
>> The latest snapshot (Restlet 1.2) already contains the fix:
>> http://www.restlet.org/documentation/snapshot/changes
>
> --
> http://restlet.tigris.org/ds/viewMessage.do?dsForumId=4447&dsMessageId=1023299
>
> --
> http://restlet.tigris.org/ds/viewMessage.do?dsForumId=4447&dsMessageId=1024085
>
--
http://restlet.tigris.org/ds/viewMessage.do?dsForumId=4447&dsMessageId=1033522
--
http://restlet.tigris.org/ds/viewMessage.do?dsForumId=4447&dsMessageId=1039028
Re: Re: Re: Tomcat appears to swallow Allow: header
Hi, Jerome!
Turns out that, while 1.2 snapshot *does* fix the issue in GWT and
Tomcat 5, 1.1 snapshot *does not* fix it. I'm at a bit of a loss as
to how to troubleshoot beyond that. Where was the change mainly
applied?
- R
On Wed, Jan 14, 2009 at 7:51 AM, Jerome Louvel
wrote:
> Awesome!! The fix has been apply to the 1.1 branch in SVN. Thanks Rob for
> testing this.
>
> Thierry has fixed the redirect issue. FYI, there is a browsable directory
> with all the releases available. Useful if you need a
> snapshot of 1.1 branch :-)
> http://www.restlet.org/downloads/archives
>
> Best regards,
> Jerome Louvel
> --
> Restlet ~ Founder and Lead developer ~ http://www.restlet.org
> Noelios Technologies ~ Co-founder ~ http://www.noelios.com
>
>
> -Message d'origine-
> De : Rob Heittman [mailto:rob.heitt...@solertium.com]
> Envoye : mercredi 14 janvier 2009 02:41
> A : discuss@restlet.tigris.org
> Objet : Re: Re: Re: Tomcat appears to swallow Allow: header
>
> Much weeping and gnashing of teeth later ... I took out the entity
> hacks from GoGoEgo, ran on Restlet 1.1, observed the Tomcat problems
> under GWT hosted mode, ported to Restlet 1.2 snapshot, took out the
> entity hacks, and am not seeing the adverse behavior. Barring a more
> scientific analysis ... I think this fix really solves the problem!
> Sweet!
>
> Unrelated - did you know that when you download snapshot ("development
> version - unstable") from www.restlet.org/downloads you get redirected
> to the 1.1 snapshot? This is a bit confusing :-) I had to guess the
> URL for the 1.2 snapshot.
>
> On Tue, Jan 13, 2009 at 5:31 PM, Jerome Louvel
> wrote:
>> The latest snapshot (Restlet 1.2) already contains the fix:
>> http://www.restlet.org/documentation/snapshot/changes
>
> --
> http://restlet.tigris.org/ds/viewMessage.do?dsForumId=4447&dsMessageId=1023299
>
> --
> http://restlet.tigris.org/ds/viewMessage.do?dsForumId=4447&dsMessageId=1024085
>
--
http://restlet.tigris.org/ds/viewMessage.do?dsForumId=4447&dsMessageId=1033522
Re: Re: Re: Tomcat appears to swallow Allow: header
Which I do! I will switch our GoGoEgo dependencies to use the 1.1 branch snapshot so we can drop the hacks. On Wed, Jan 14, 2009 at 7:51 AM, Jerome Louvel wrote: > Thierry has fixed the redirect issue. FYI, there is a browsable directory > with all the releases available. Useful if you need a > snapshot of 1.1 branch :-) > http://www.restlet.org/downloads/archives -- http://restlet.tigris.org/ds/viewMessage.do?dsForumId=4447&dsMessageId=1024091
RE: Re: Re: Tomcat appears to swallow Allow: header
Awesome!! The fix has been apply to the 1.1 branch in SVN. Thanks Rob for
testing this.
Thierry has fixed the redirect issue. FYI, there is a browsable directory with
all the releases available. Useful if you need a
snapshot of 1.1 branch :-)
http://www.restlet.org/downloads/archives
Best regards,
Jerome Louvel
--
Restlet ~ Founder and Lead developer ~ http://www.restlet.org
Noelios Technologies ~ Co-founder ~ http://www.noelios.com
-Message d'origine-
De : Rob Heittman [mailto:rob.heitt...@solertium.com]
Envoye : mercredi 14 janvier 2009 02:41
A : discuss@restlet.tigris.org
Objet : Re: Re: Re: Tomcat appears to swallow Allow: header
Much weeping and gnashing of teeth later ... I took out the entity
hacks from GoGoEgo, ran on Restlet 1.1, observed the Tomcat problems
under GWT hosted mode, ported to Restlet 1.2 snapshot, took out the
entity hacks, and am not seeing the adverse behavior. Barring a more
scientific analysis ... I think this fix really solves the problem!
Sweet!
Unrelated - did you know that when you download snapshot ("development
version - unstable") from www.restlet.org/downloads you get redirected
to the 1.1 snapshot? This is a bit confusing :-) I had to guess the
URL for the 1.2 snapshot.
On Tue, Jan 13, 2009 at 5:31 PM, Jerome Louvel
wrote:
> The latest snapshot (Restlet 1.2) already contains the fix:
> http://www.restlet.org/documentation/snapshot/changes
--
http://restlet.tigris.org/ds/viewMessage.do?dsForumId=4447&dsMessageId=1023299
--
http://restlet.tigris.org/ds/viewMessage.do?dsForumId=4447&dsMessageId=1024085
Re: Re: Re: Tomcat appears to swallow Allow: header
Much weeping and gnashing of teeth later ... I took out the entity
hacks from GoGoEgo, ran on Restlet 1.1, observed the Tomcat problems
under GWT hosted mode, ported to Restlet 1.2 snapshot, took out the
entity hacks, and am not seeing the adverse behavior. Barring a more
scientific analysis ... I think this fix really solves the problem!
Sweet!
Unrelated - did you know that when you download snapshot ("development
version - unstable") from www.restlet.org/downloads you get redirected
to the 1.1 snapshot? This is a bit confusing :-) I had to guess the
URL for the 1.2 snapshot.
On Tue, Jan 13, 2009 at 5:31 PM, Jerome Louvel
wrote:
> The latest snapshot (Restlet 1.2) already contains the fix:
> http://www.restlet.org/documentation/snapshot/changes
--
http://restlet.tigris.org/ds/viewMessage.do?dsForumId=4447&dsMessageId=1023299
RE: Re: Re: Tomcat appears to swallow Allow: header
Hi all, I haven't ported the fix to Restlet 1.1 yet. I would like to get more feed-back on SVN trunk first due to potential impact if this approach has flaws. The latest snapshot (Restlet 1.2) already contains the fix: http://www.restlet.org/documentation/snapshot/changes It can be downloaded from this page: http://www.restlet.org/downloads/ Best regards, Jerome Louvel -- Restlet ~ Founder and Lead developer ~ <http://www.restlet.org/> http://www.restlet.org Noelios Technologies ~ Co-founder ~ <http://www.noelios.com/> http://www.noelios.com _ De : Rob Heittman [mailto:rob.heitt...@solertium.com] Envoye : mardi 13 janvier 2009 23:17 A : discuss@restlet.tigris.org Objet : Re: Re: Re: Tomcat appears to swallow Allow: header Jerome committed a candidate fix to trunk today and mentioned it in the previously referenced thread. I can't test it until tomorrow, but if you can build trunk or use tomorrow's snapshot, you may be able to verify the fix before I can. -- http://restlet.tigris.org/ds/viewMessage.do?dsForumId=4447&dsMessageId=1022985
Re: Re: Re: Tomcat appears to swallow Allow: header
Jerome committed a candidate fix to trunk today and mentioned it in the previously referenced thread. I can't test it until tomorrow, but if you can build trunk or use tomorrow's snapshot, you may be able to verify the fix before I can. -- http://restlet.tigris.org/ds/viewMessage.do?dsForumId=4447&dsMessageId=1022966
RE: Re: Re: Tomcat appears to swallow Allow: header
Well, I compared HttpServerConverter#commit code in restlet 1.0.10 and restlet
1.1.1, and the 1.0.10 version did not check for content length or response code
before adding the headers. Surely this needs to be fixed in restlet 1.1.1.
HttpServerConverter#commit code in restlet 1.0.10 was as follows:
public void commit(HttpResponse response) {
try {
// Add the response headers
addResponseHeaders(response);
// Send the response to the client
response.getHttpCall().sendResponse(response);
} catch (Exception e) {
getLogger().log(Level.INFO, "Exception intercepted", e);
response.getHttpCall().setStatusCode(Status.SERVER_ERROR_INTERNAL.getCode());
response.getHttpCall().setReasonPhrase(
"An unexpected exception occured");
}
}
--
http://restlet.tigris.org/ds/viewMessage.do?dsForumId=4447&dsMessageId=1022684
