Re: Last chance to object to new features
On Tue, Nov 3, 2009 at 8:23 PM, Waldemar Kornewald wrote: > > On Tue, Nov 3, 2009 at 6:37 AM, Russell Keith-Magee > wrote: >> I've already integrated Jacob's comments into the code in my local >> checkout. Actually, Jacob's comments pointed out an interesting code >> cleanup: the File email backend is really just the Console email >> backend pointing at a file object instead of stdout. As a result, I've >> been able to delete a bunch of code by modifying the console backend >> to accept an arbitrary stream, and making the file backend a subclass >> of the console backend. >> >> I'll commit tonight (my time) once I have a chance to give the patch a >> final review. > > Thanks a lot, Russell! > > Andi, could you please add your App Engine email backend to our test project? I'd prefer to keep the App Engine email backends separate until we're able to bundle a complete package that provides App Engine support for Django. Two backends (a synchronous and an asynchronous one) are available on bitbucket: http://bitbucket.org/andialbrecht/appengine_emailbackends/ Andi > > Bye, > Waldemar Kornewald > > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Re: Last chance to object to new features
This just came up on IRC: in django.test.utils setup_test_environment() the lines 46/47 are mixed up. Here's a diff that fixes this issue: diff --git a/django/test/utils.py b/django/test/utils.py index a30bb7e..9d39eee 100644 --- a/django/test/utils.py +++ b/django/test/utils.py @@ -43,8 +43,8 @@ def setup_test_environment(): mail.original_SMTPConnection = mail.SMTPConnection mail.SMTPConnection = locmem.EmailBackend -settings.EMAIL_BACKEND = 'django.core.mail.backends.locmem' mail.original_email_backend = settings.EMAIL_BACKEND +settings.EMAIL_BACKEND = 'django.core.mail.backends.locmem' mail.outbox = [] Sorry for pasting it here, but it's really just one line :) Andi On Tue, Nov 3, 2009 at 6:27 AM, Andi Albrecht wrote: > On Mon, Nov 2, 2009 at 4:53 PM, Jacob Kaplan-Moss wrote: >> >> On Mon, Nov 2, 2009 at 10:02 AM, Russell Keith-Magee >> wrote: >>> A quick reminder - if you have any objections or feedback on #10109, >>> the M2M refactor [1], I intend to land this patch in approximately 48 >>> hours. >> >> I've left a few comments in that thread, but they don't need to be >> addressed pre-merge. Fire away! >> >>> Also, following some mailing list and IRC discussion [2], I'll be >>> trying to land #10355 at the same time. This is the addition of the >>> email backend API. >> >> I've left a few notes on the ticket. The only one that needs to be >> addressed pre-merge is a simple design decision, and the final call's >> yours. > > Russel, thanks for finishing the mail backend patch! Jacob's notes on > the ticket sound very reasonable to me - please let me know which of > them you'll address before merging. I'd be happy to provide a patch > for anything remaining. > > Andi > >> >> Thanks! >> >> Jacob >> >> >> >> > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Re: Last chance to object to new features
On Wed, Nov 4, 2009 at 6:23 PM, Andi Albrecht wrote: > > This just came up on IRC: in django.test.utils > setup_test_environment() the lines 46/47 are mixed up. > > Here's a diff that fixes this issue: > > diff --git a/django/test/utils.py b/django/test/utils.py > index a30bb7e..9d39eee 100644 > --- a/django/test/utils.py > +++ b/django/test/utils.py > @@ -43,8 +43,8 @@ def setup_test_environment(): > mail.original_SMTPConnection = mail.SMTPConnection > mail.SMTPConnection = locmem.EmailBackend > > - settings.EMAIL_BACKEND = 'django.core.mail.backends.locmem' > mail.original_email_backend = settings.EMAIL_BACKEND > + settings.EMAIL_BACKEND = 'django.core.mail.backends.locmem' > > mail.outbox = [] > > Sorry for pasting it here, but it's really just one line :) No problems. Fixed in r11718. Yours, Russ Magee %-) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
Should docs.djangoproject.com link to 1.1 frozen docs by default, not SVN dev docs?
Now that 1.2 features have started to merge (great work everyone involved with the Email backends and ManyToMany refactorings, they look fantastic) we're entering one of those relatively rare periods of instability in trunk. This is exactly the kind of time that we want most of our regular users to be sticking with the 1.1.1 release, while the super-engaged community members try out the new stuff as it's added. There's just one problem: http://docs.djangoproject.com/ defaults to displaying the development docs. In fact, there isn't even an option to see frozen docs for 1.1 (just an option to see them for 1.0). These are going to start being pretty confusing for 1.1.1 users, for example the e-mail docs now cover backends: http://docs.djangoproject.com/en/dev/topics/email/ We include "New in Django Development version" warnings, but it still feels a bit odd. In a post-1.0 world, I think it would make more sense for the documentation linked to directly from the docs.djangoproject.com homepage to cover the most recent official release, with a bit less emphasis on the development version's docs. Basically what the Python docs at http://docs.python.org/ do. I may have missed a previous conversation about this, if so please feel free to direct me to the old thread. Cheers, Simon --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~--~~~~--~~--~--~---
