Spaces between argument separator and argument in template filter generate error

2018-05-30 Thread oliver


In the template filter system now,

spaces between augment separator and augments generate error.
For example, the following template code generates the following error.

{{ value | filter: "arg"}}

TemplateSyntaxError at /
Could not parse the remainder: ': "arg"' from 'value | filter: "arg"'

https://code.djangoproject.com/ticket/29457


What do you think of this ticket?

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/41376429-949c-4202-9074-5dc0200fc8ef%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: #29433 New split template filter

2018-05-30 Thread Collin Anderson
There's been a few cases where I would have found a split filter to be
useful. I don't remember them off the top of my head.

I like that the behavior of it should be pretty well defined: just return
obj.split() if val is None else obj.split(val)

On Wed, May 30, 2018 at 6:32 AM, Carlton Gibson 
wrote:

> Hi Kamil,
>
> I'd think the preference here would be to NOT add new filters lightly —
> i.e. to close as wontfix — and recommend users create their own filters (or
> pull the logic into say a `get_context()` method) if they need this kind of
> thing.
>
> Slight aside: "Hi guys" may not fairly address everyone on the list. How
> about "Hi folks" or similar. 
>
> Kind Regards,
>
> Carlton
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To post to this group, send email to django-developers@googlegroups.com.
> Visit this group at https://groups.google.com/group/django-developers.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/django-developers/50bc0125-3ba2-4429-82e0-
> 4327d1490752%40googlegroups.com
> 
> .
>
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAFO84S7c8bXPYaOEUb0-H%3DMqd3iv9Kx4xrDW%3D0HDxhetwH7ZdA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: #29433 New split template filter

2018-05-30 Thread Carlton Gibson
Hi Kamil, 

I'd think the preference here would be to NOT add new filters lightly — 
i.e. to close as wontfix — and recommend users create their own filters (or 
pull the logic into say a `get_context()` method) if they need this kind of 
thing. 

Slight aside: "Hi guys" may not fairly address everyone on the list. How 
about "Hi folks" or similar. 

Kind Regards,

Carlton

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/50bc0125-3ba2-4429-82e0-4327d1490752%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Fellow Reports -- May 2018

2018-05-30 Thread Carlton Gibson
Hi all. 

Calendar Week 20 -- ending 18th May.


Reviewed Patches on:

https://code.djangoproject.com/ticket/29408 -- ordering by field from 
related model does not validate if field exists
https://code.djangoproject.com/ticket/28743 -- Clarify the term "deployment 
server" in the documentation
https://code.djangoproject.com/ticket/3461  -- DatabaseWrapper should pass 
through args and kwargs to underlying database adapter
https://code.djangoproject.com/ticket/20147 -- Provide an alternative to 
request.META for accessing HTTP headers
https://code.djangoproject.com/ticket/28462 -- ModelAdmin.list_editable 
memory intensive with large datasets
https://code.djangoproject.com/ticket/11964 -- Add the ability to use 
database-level CHECK CONSTRAINTS
https://code.djangoproject.com/ticket/29381 -- Move some parts of 
`django.contrib.auth.models` to `django.contrib.auth.base_user` for 
reusability
https://github.com/django/django/pull/9954  -- Update http.py
https://github.com/django/django/pull/9956  -- Add missing word to 
deprecation warning text


Triaged:

https://code.djangoproject.com/ticket/29411 -- Pickling of a form fails 
after a form was used in a template. (Duplicate)
https://code.djangoproject.com/ticket/29379 -- Add autocomplete attribute 
to contrib.auth fields. (Accepted)


Calendar Week 21 -- ending 25th May.

I was at DjangoCon Europe. (Good to see you there!) 

No activity. 


Kind Regards,

Carlton

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/62d9ecf5-834e-48a9-a36d-b23927ec2741%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Simplify middlewares (again) and get rid of process_view

2018-05-30 Thread Carl Meyer
On 5/16/18 10:49 AM, Florian Apolloner wrote:
> Hi Carl,
> 
> On Wednesday, May 16, 2018 at 5:58:02 AM UTC+2, Carl Meyer wrote:
> 
> I'm not sure this part is feasible. It's an intentional part of
> middleware design AFAIK (and useful) that middleware can modify
> request.path and have this modification respected in view resolution.
> 
> 
> my proposed urlresolver_factory takes the request as argument and should
> therefore allow for anything that the middleware would allow too -- are
> there any specific usecases you have in mind that would require a
> middleware?

Composing two different middleware that both alter request.path for
different purposes? This will require the site owner to manually compose
in their urlconf_factory.

I think your core proposal that the main middleware call layering should
run after view resolution instead of before it is probably a better
design for middleware in principle, but it needs work in a couple areas:

1. Motivating the change in a way that clarifies how it will benefit
typical Django users, sufficiently to justify the churn. What new
possibilities are unlocked by the change, and has there been demand for
those possibilities?
2. Fleshing out how a reasonable transition path for existing middleware
(including third-party middleware) would look.

It's too bad we didn't think about this possibility during the original
DEP5, to avoid multiple middleware changes within a few Django versions.

Carl

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/679c0352-d374-a979-90e3-732ea619ac63%40oddbird.net.
For more options, visit https://groups.google.com/d/optout.