Re: Spaces between argument separator and argument in template filter generate error

2018-05-31 Thread Collin Anderson
Maybe it would be worth having a more friendly error message?

On Thu, May 31, 2018 at 8:59 PM,  wrote:

> Thank you for your reply.
> I understand your opinion well
>
> 2018년 5월 31일 목요일 오전 11시 41분 22초 UTC+9, oli...@kidsnote.com 님의 말:
>>
>> In the template filter system now,
>>
>> spaces between augment separator and augments generate error.
>> For example, the following template code generates the following error.
>>
>> {{ value | filter: "arg"}}
>>
>> TemplateSyntaxError at /
>> Could not parse the remainder: ': "arg"' from 'value | filter: "arg"'
>>
>> https://code.djangoproject.com/ticket/29457
>>
>>
>> What do you think of this ticket?
>>
>> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To post to this group, send email to django-developers@googlegroups.com.
> Visit this group at https://groups.google.com/group/django-developers.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/django-developers/b133457b-e474-47b6-b37f-
> cdab3fa6ee2f%40googlegroups.com
> 
> .
>
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAFO84S4oFP_hxC6u84HagpXJy3ko7hvTkQjTO85CNfegFSX%3DUg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: Spaces between argument separator and argument in template filter generate error

2018-05-31 Thread oliver
Thank you for your reply.
I understand your opinion well

2018년 5월 31일 목요일 오전 11시 41분 22초 UTC+9, oli...@kidsnote.com 님의 말:
>
> In the template filter system now,
>
> spaces between augment separator and augments generate error.
> For example, the following template code generates the following error.
>
> {{ value | filter: "arg"}}
>
> TemplateSyntaxError at /
> Could not parse the remainder: ': "arg"' from 'value | filter: "arg"'
>
> https://code.djangoproject.com/ticket/29457
>
>
> What do you think of this ticket?
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/b133457b-e474-47b6-b37f-cdab3fa6ee2f%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Spaces between argument separator and argument in template filter generate error

2018-05-31 Thread James Bennett
On Thu, May 31, 2018 at 1:39 AM,  wrote:

> Are there any reasons that not allow spaces between separator and arg?
>

Every optional variant of template syntax is a potential source of bugs or
compatibility issues for the future. And a potential source of confusion
when someone is trying to learn by reading code -- why did one developer do
it *this* way, while another developer did it *that* way? And another
choice every dev team has to make when putting together their style guide,
and another option they have to set on their linters, to make sure they get
a consistent codebase.

For these reasons, the default position should be "don't add it unless
there's a very good reason to". If there is a good reason to add it, please
explain so we can understand why you're requesting it.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAL13Cg98d4UX2RcypOeiRnCU-TczNzqO90unjLgt4y8q8YugPg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: Spaces between argument separator and argument in template filter generate error

2018-05-31 Thread oliver
Are there any reasons that not allow spaces between separator and arg?

2018년 5월 31일 목요일 오전 11시 41분 22초 UTC+9, oli...@kidsnote.com 님의 말:
>
> In the template filter system now,
>
> spaces between augment separator and augments generate error.
> For example, the following template code generates the following error.
>
> {{ value | filter: "arg"}}
>
> TemplateSyntaxError at /
> Could not parse the remainder: ': "arg"' from 'value | filter: "arg"'
>
> https://code.djangoproject.com/ticket/29457
>
>
> What do you think of this ticket?
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/131b5095-c5b7-4492-92fa-e58912ac842a%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Spaces between argument separator and argument in template filter generate error

2018-05-31 Thread Adam Johnson
I think it's better to be conservative here and leave it as-is, the current
syntax has worked for years and this change doesn't really reduce the risk
of bugs.

On Thu, 31 May 2018 at 03:34,  wrote:

> In the template filter system now,
>
> spaces between augment separator and augments generate error.
> For example, the following template code generates the following error.
>
> {{ value | filter: "arg"}}
>
> TemplateSyntaxError at /
> Could not parse the remainder: ': "arg"' from 'value | filter: "arg"'
>
> https://code.djangoproject.com/ticket/29457
>
>
> What do you think of this ticket?
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To post to this group, send email to django-developers@googlegroups.com.
> Visit this group at https://groups.google.com/group/django-developers.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/41376429-949c-4202-9074-5dc0200fc8ef%40googlegroups.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>


-- 
Adam

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAMyDDM2GpwgemVHKkrr8yM%2B9%2B35Wk8N7P0_2oTekL_kSwaKkdQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.