Re: Fellow Reports - August 2020

[Mariusz Felisiak]

Week ending August 30, 2020.

Triaged:
https://code.djangoproject.com/ticket/31934 - Document that "SameSite" 
has defaults in some browsers. (accepted)
https://code.djangoproject.com/ticket/31928 - Coroutine passed to the 
first middleware's process_response() instead of HttpResponse. (accepted)
https://code.djangoproject.com/ticket/31932 - Unique checking in 
formsets should exclude forms marked for deletion. (accepted)
https://code.djangoproject.com/ticket/31935 - The add link on sidebar 
are slipped when use japanese or chinese language (duplicate)
https://code.djangoproject.com/ticket/19878 - Stop TemplateView 
automatically passing kwargs into the context (wontfix)
https://code.djangoproject.com/ticket/31936 - JSONField not filtering 
correct with __in lookup on key transforms. (accepted)
https://code.djangoproject.com/ticket/31939 - Allow to specify a custom 
--add-comments option to pass to xgettext in makemessages. (wontfix)
https://code.djangoproject.com/ticket/31940 - Order of WHERE clauses do 
not match the order of the arguments to .filter(). (wontfix)
https://code.djangoproject.com/ticket/31926 - Queryset crashes when 
recreated from a pickled query with FilteredRelation used in aggregation. 
(accepted)
https://code.djangoproject.com/ticket/31924 - Support --force-color for 
runserver. (invalid)
https://code.djangoproject.com/ticket/31917 - MySQL Operational Error: 
"Unknown column 'x' in 'having clause'" (invalid)
https://code.djangoproject.com/ticket/31942 - 
SafeExceptionReporterFilter does not recurse into dictionaries with 
non-string keys (accepted)
https://code.djangoproject.com/ticket/31945 - PermissionError due to 
unjustified attempt to access '/usr'. (duplicate)
https://code.djangoproject.com/ticket/31946 - Admin Sidebar django 3.1 
display errors (Panel is Overlapping) (duplicate)
https://code.djangoproject.com/ticket/31947 - 
QuerySet.update_or_create() should use get_or_create() internally (accepted)
https://code.djangoproject.com/ticket/31948 - Add support for tzinfo 
parameter to TruncDate() and TruncTime(). (accepted)
https://code.djangoproject.com/ticket/31945 - PermissionError due to 
unjustified attempt to access '/usr'. (accepted)
https://code.djangoproject.com/ticket/31951 - verbose_name_plural does 
not overwrite names on list (admin) (accepted)
https://code.djangoproject.com/ticket/31952 - Using 
EmptyFieldListFilter with reverse relationship crashes (created)
https://code.djangoproject.com/ticket/31953 - Model Inheritance and 
reverse relations (invalid)
https://code.djangoproject.com/ticket/31943 - Queryset with 
values()/values_list() crashes when recreated from a pickled query. 
(accepted)
https://code.djangoproject.com/ticket/31955 - Multiple email send 
issues (invalid)
https://code.djangoproject.com/ticket/31954 - MigrationOptimizer 
mangles operation order if app name contains uppercase letters. (accepted)
https://code.djangoproject.com/ticket/31956 - QuerySet.order_by() 
chained with values() crashes on JSONField with a custom decoder on 
PostgreSQL. (accepted)
https://code.djangoproject.com/ticket/31959 - EmailValidator must not 
accept hyphen as first character (wontfix)
https://code.djangoproject.com/ticket/31964 - NoReverseMatch at / 
Reverse for 'home-page' not found. 'home-page' is not a valid view function 
or pattern name. (invalid)
https://code.djangoproject.com/ticket/31963 - Nested OuterRef not 
woking to access grandparent's ID. (worksforme)

Reviewed/committed:
https://github.com/django/django/pull/13340 - Added assertions for the 
results of migrating an integer pk to AutoField.
https://github.com/django/django/pull/13325 - Fixed #31907 -- Fixed 
missing validate_key() calls in cache backends.
https://github.com/django/django/pull/1 - Refs #30897 -- Added test 
for WAL option to Queryset.explain() on PostgreSQL 13+.
https://github.com/django/django/pull/13339 - Fixed #24533 -- Dropped 
PostgreSQL sequence and Oracle identity when migrating away from AutoField.
https://github.com/django/django/pull/13334 - Fixed #31905 -- Made 
MiddlewareMixin call process_request()/process_response() with thread 
sensitive.
https://github.com/django/django/pull/13338 - Fixed #31918 -- Allowed 
QuerySet.in_bulk() to fetch on a single distinct field.
https://github.com/django/django/pull/13347 - Fixed #31942 -- Made 
settings cleansing work with dictionary settings with non-string keys.
https://github.com/django/django/pull/13349 - Fixed #31947 -- Made 
QuerySet.update_or_create() reuse get_or_create().
https://github.com/django/django/pull/13344 - Fixed #31928 -- Fixed 
detecting an async get_response in various middlewares.
https://github.com/django/django/pull/13354 - Fixed #31954 -- Fixed 
migration optimization for MTI model creation with parent model with mixed 
case app label.

Authored:
https://github.co

Re: Fellow Reports -- August 2020

[Carlton Gibson]

Hi all. 


Calendar Week 34 -- ending 23 August.


Triaged:

https://code.djangoproject.com/ticket/31920 -- ASGI/ASYNC SessionMiddleware 
- SynchronousOnlyOperation exception if request.user is not unwrapped in 
sync code (Accepted)
https://code.djangoproject.com/ticket/31915 -- Allow load template tag 
before extends tag (wontfix)
https://code.djangoproject.com/ticket/31900 -- Reloader using watchman 
initiates reloads despite no file changed (worksforme)
https://code.djangoproject.com/ticket/31911 -- Django-3.1: get_language() 
fails to return LANGUAGE_CODE during ./manage.py migrate (Invalid)
https://code.djangoproject.com/ticket/31912 -- pathlib PermissionError 
problem (Accepted)
https://code.djangoproject.com/ticket/31908 -- Add parallel testing support 
to Oracle backend (Accepted)
https://code.djangoproject.com/ticket/31907 -- Inconsistent key validation 
checks in cache backends. (Accepted)
https://code.djangoproject.com/ticket/31905 -- ASGI: Dead persistent 
postgres connections are not closed when the database is accessed in 
middleware (Accepted)
https://code.djangoproject.com/ticket/31906 -- Possible ModelChoiceIterator 
docs typo (Accepted)
https://code.djangoproject.com/ticket/31901 -- Content will out of screen 
when nav-sidebar is open (Accepted)
https://code.djangoproject.com/ticket/31894 -- JSONField filter() and 
JSONField exclude() are sometimes not inverses of each other (Accepted)
https://code.djangoproject.com/ticket/31884 -- nav-sidebar ui optimization 
(wontfix)
https://code.djangoproject.com/ticket/31885 -- Update SMTP Email Backend to 
use an SSLContext. (Accepted)
https://code.djangoproject.com/ticket/31898 -- New Form Widget similar to 
Admin Read-only display (wontfix)



Reviewed:

https://github.com/django/django/pull/13334 -- Fixed #31905 -- 
MiddlewareMixin use sync_to_async with thread_sensiti…
https://code.djangoproject.com/ticket/31877 -- 
TemplateView.get_context_data()'s kwargs returns SimpleLazyObjects 
that causes a crash when filtering.
https://github.com/django/django/pull/12387 -- Fixed #31216 -- Added 
support for colorama terminal colors on Windows.
https://github.com/django/django/pull/13317 -- Refs #9061, Refs #20347 -- 
Added absolute_max and can_delete_extra arguments to 
generic_inlineformset_factory().
https://github.com/django/django/pull/13316 -- Refs #17642 -- Doc'd min_num 
and validate_min arguments in modelformset_factory() docs.
https://github.com/django/django/pull/13305 -- Fixed #31885 -- Updated SMTP 
Email Backend to use an SSLContext.





Calendar Week 35 -- ending 30 August.


Mini-break ⛱


Triaged:

https://code.djangoproject.com/ticket/31958 -- Django ORM sync_to_async 
error FATAL: remaining connection slots are reserved for non-replication 
superuser connections (Invalid)
https://code.djangoproject.com/ticket/31949 -- Allow builtin view 
decorators to be applied directly to async views. (Accepted)



Reviewed:

https://github.com/django/django/pull/13352 -- Fixed #31945 -- Removed 
strict=True in Path.resolve() of CommonPasswordValidator.
https://github.com/django/django/pull/13344 -- Fixed #31928 -- Fixed 
MiddlewareMixin subclasses not presenting as async
https://github.com/django/django/pull/13334 -- Fixed #31905 -- 
MiddlewareMixin use sync_to_async with thread_sensiti…



Kind Regards,

Carlton





On Wednesday, 19 August 2020 at 12:37:20 UTC+2 Carlton Gibson wrote:

> Hi all. 
>
>
> Calendar Week 32 -- ending 09 August.
>
>
> Triaged:
>
> https://code.djangoproject.com/ticket/31864 -- Session data cannot be 
> decoded during the transition to Django 3.1. (Accepted)
> https://code.djangoproject.com/ticket/31862 -- Add ArrayField for all 
> supported databases - not only postgres (invalid)
> https://code.djangoproject.com/ticket/31858 -- space outside of 
> parameters are not allowed in path() routes (Accepted)
> https://code.djangoproject.com/ticket/31860 -- "__date" in F 
> expression not working, have to use Func() (Duplicate of #31639)
> https://code.djangoproject.com/ticket/31861 -- Model field for 
> enumeration types (Duplicate of #24342)
> https://code.djangoproject.com/ticket/19040 -- Allow declaring a model 
> Manager class inside the model class (wontfix)
> https://github.com/django/asgiref/issues/186 -- Migration from wsgi to 
> asgi questions #186 (invalid)
> https://code.djangoproject.com/ticket/31856 -- Add block to customize 
> nav_ sidebar style and script. (invalid)
> https://code.djangoproject.com/ticket/31855 -- Flag for Initial Database 
> Engine (wontfix)
> https://code.djangoproject.com/ticket/31854 -- Long model names are not 
> wrapped in the navigation sidebar. (Accepted)
> https://code.djangoproject.com/ticket/31853 -- In some languages, such as 
> Chinese, the Add button text of the navigation bar is wrapped (Accepted)
> https://code.djangoproject.com/ticket/31852 -- Support async generators 
> in StreamingHttpResponse (needsinfo)
> https://code.djangoproject.com/ticket/31845 -- CSRF check fails when 
>

Updates to PR are not reflected in Jenkins, checks failing

['Megan Huber' via Django developers (Contributions to Django itself)]

Hi All!

I have an open PR  and am 
having difficulty getting the Jenkins checks to pass. I have amended my 
original commit a few times but these changes are not reflected in Jenkins.

One test, test_middleware_headers, was failing with my original commit. I 
had forgotten to update this test to reflect the new default header I added 
to the security middleware. I added the new header to the list of expected 
headers in this test and amended my commit. 

The checks were run again with new builds but the changes I made to the 
commit were not reflected in Jenkins. The error message about this failing 
test did not change at all. In Jenkins it appears that this test is not 
altered as the expected output of the test has not been updated to reflect 
the changes I made to it. However, I can see that the changes to this test 
were added as a part of my commit in test_settings.py.

This test passes locally but does not pass on any configuration in Jenkins. 
How can I get my changes to this test to reflect correctly in Jenkins so 
that the checks will pass?

Thank you! 

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/81155ecd-4db5-43cc-bf69-4c1a570f9eb5n%40googlegroups.com.

Re: Updates to PR are not reflected in Jenkins, checks failing

[Tim Graham]

Hi, I'd try rebasing your branch against master to eliminate the merge 
conflict.

On Monday, August 31, 2020 at 4:37:15 PM UTC-4 ba...@google.com wrote:

> Hi All!
>
> I have an open PR  and am 
> having difficulty getting the Jenkins checks to pass. I have amended my 
> original commit a few times but these changes are not reflected in Jenkins.
>
> One test, test_middleware_headers, was failing with my original commit. I 
> had forgotten to update this test to reflect the new default header I added 
> to the security middleware. I added the new header to the list of expected 
> headers in this test and amended my commit. 
>
> The checks were run again with new builds but the changes I made to the 
> commit were not reflected in Jenkins. The error message about this failing 
> test did not change at all. In Jenkins it appears that this test is not 
> altered as the expected output of the test has not been updated to reflect 
> the changes I made to it. However, I can see that the changes to this test 
> were added as a part of my commit in test_settings.py.
>
> This test passes locally but does not pass on any configuration in 
> Jenkins. How can I get my changes to this test to reflect correctly in 
> Jenkins so that the checks will pass?
>
> Thank you! 
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/7b9cba21-7c65-4549-9d76-b69bf763ae93n%40googlegroups.com.