makemessages management command should not touch POT-Creation-Date

2021-08-30 Thread Daniyal Abbasi
Hi

I was recently working on some git hooks with the makemessages command and 
I noticed that the "POT-Creation-Date" was always updated even if no 
strings were added, removed or relocated.

I created a ticket (#33056 ) 
and was redirected to #6106  which 
is the original ticket which was closed over 11 years ago. However, I'd 
like to bring this into discussion and hoping to open this issue once 
again. 

If the po file exists, the makemessages command uses `msgmerge` in the 
`write_po_file` method to get the contents of the po file. (Refer this 
).
 
However, msgmerge is not ran in the update mode using the `--update` flag 

. 

I propose on added this flag and making other suitable modifications as 
this causes a lot of issues with source control and git hooks. I've created 
a sample PR  for the same.

Looking forward to hear what everyone thinks about this!

Thanks and regards,
Daniyal Abbasi

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/32440770-55aa-4feb-b164-6940ca07838fn%40googlegroups.com.


Re: Fellow Reports - August 2021

2021-08-30 Thread Mariusz Felisiak
Week ending August 29, 2021

*Triaged: *
   https://code.djangoproject.com/ticket/33042 - Form validator cannot pass 
ModelMultipleChoiceField by checkbox (invalid) 
   https://code.djangoproject.com/ticket/33045 - Out-of-the box support for 
React JS (wontfix) 
   https://code.djangoproject.com/ticket/33044 - pyproject.toml breaks pip 
install into user site directory with editable source (accepted) 
   https://code.djangoproject.com/ticket/33041 - call_command() returns 
different values for options than manage.py when nargs is specified 
(invalid) 
   https://code.djangoproject.com/ticket/33047 - CheckConstraint crashes 
with GIS lookup and PostGIS backend. (accepted) 
   https://code.djangoproject.com/ticket/33049 - TabularInline doesn't 
render properly MultiPolygonField in Django Admin (duplicate) 
   https://code.djangoproject.com/ticket/33052 - save() on object with pk 
with default and existing value results in error and not update. (wontfix) 
   https://code.djangoproject.com/ticket/33051 - Model names with special 
characters don't highlight in admin site (accepted) 
   https://code.djangoproject.com/ticket/33037 - TruncDay error when using 
offset timezones on MySQL (accepted) 
   https://code.djangoproject.com/ticket/33054 - Support post-commit hooks 
adding more post-commit hooks (accepted) 
   https://code.djangoproject.com/ticket/23610 - Removing a null constraint 
can lead to race conditions with migrations (wontfix) 
   https://code.djangoproject.com/ticket/33050 - QuerySet.count() on 
combined queries with select_related() crashes on MySQL. (accepted) 
   https://code.djangoproject.com/ticket/33055 - Django - Custom Join's 
F('') includes single quotes in column reference, causing Postgres to think 
it's string and not a column reference (invalid) 
   https://code.djangoproject.com/ticket/33057 - Foreign key constraint in 
m2m tables is not recreated when altering type of referenced primary key on 
Oracle. (accepted) 
   https://code.djangoproject.com/ticket/33059 - Form + Formset(s) Class 
Based View (duplicate) 
   https://code.djangoproject.com/ticket/33058 - Use DiscoverRunner's 
logger for logging when running checks (accepted) 
   https://code.djangoproject.com/ticket/33060 - Add a helper function to 
make and validate cache keys. (accepted) 
   https://code.djangoproject.com/ticket/33061 - ValueError not raised by 
some cache backends for incr() / decr() with negative delta when a key is 
missing (accepted) 
   https://code.djangoproject.com/ticket/33063 - Use string module instead 
of writing all of characters (wontfix) 
   https://code.djangoproject.com/ticket/33064 - Created Model is not 
showing in Django Atomic Trasaction Block (worksforme) 

*Reviewed/committed: *
   https://github.com/django/django/pull/14778 - Fixed #33030 -- Fixed 
broken links to GDAL docs. 
   https://github.com/django/django/pull/14790 - Refs #10929 -- Allowed 
NowUTC SQL customization for third-party backends. 
   https://github.com/django/django/pull/14759 - Fixed #32552 -- Added 
logger argument to DiscoverRunner. 
   https://github.com/django/django/pull/14587 - Refs #29898 -- Made 
ProjectState encapsulate alterations in relations registry. 
   https://github.com/django/django/pull/14739 - Refs #32919 -- Simplified 
Lexer.create_token() by reorganizing blocks. 
   https://github.com/django/django/pull/14799 - Fixed #33046 -- Added note 
about using length of cached result by QuerySet.count(). 
   https://github.com/django/django/pull/14517 - Refs #32338 -- Made 
RadioSelect/CheckboxSelectMultiple render in  tags. 
   https://github.com/django/django/pull/14803 - Fixed #33051 -- Fixed 
highlighting the current model in admin's sidebar with non-ASCII model 
names. 
   https://github.com/django/django/pull/14607 - Fixed #32900 -- Improved 
migrations questioner prompts. 

*Reviewed: *
   https://github.com/django/django/pull/14437 - Fixed #33012 -- Added 
Redis cache backend. 

*Authored: *
   https://github.com/django/django/pull/14797 - Refs #29898 -- Changed 
fields in ProjectState's relation registry to dict. 
   https://github.com/django/django/pull/14798 - Fixed #32504 -- Updated 
admin's jQuery to 3.6.0.

Best,
Mariusz

>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/cce5e644-1600-48ec-9f14-95a8f6facc8bn%40googlegroups.com.