Autocomplete fields and cleaned_data

[Melvyn Sopacua | 3YOURMIND]

I'm currently looking at a bug in our application, caused by
autocomplete_fields on a ModelAdmin. It seemingly removes the field from
self.cleaned_data, which means we can no longer validate it.

I can reproduce this by removing/adding the field from/to
autocomplete_fields and resubmitting the form after re-rendering. This is a
vanilla manytomany relation.

So now I wonder if this is an implementation bug in Django, with us
(something else I'm not considering) or documentation bug, as none of this
is mentioned in the documentation on either concepts.

I'm happy to file a bug report and classify it according to the above if it
is a bug. Otherwise, I'll dive down the rabbit hole.
-- 

*Backend Developer*

Mobile: +49 (0)160 179 6874
eMail: m...@3yourmind.com
Web: www.3yourmind.com


-- 


The information that has been provided should be regarded as confidential 
within the context of our non-disclosure agreement.

 

3YOURMIND GmbH


Bismarckstraße 10-12 | 10625 Berlin | Germany

 

VAT ID - USt-IdNr. gemäß 
§ 27 a Umsatzsteuergesetz: DE296555110

Company with its registered seat in 
- Sitz der Gesellschaft: Berlin



Register court - Registergericht: 
Amtsgericht Charlottenburg (Berlin)

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAF5kSxRx92R0S9kdtZrZANmhCjomsWy-zp85%3DO%2Bw_WicB259BA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: Bugfix on #29103 creates different bug

[Melvyn Sopacua | 3YOURMIND]

Well, the testcase is a bit hard. I can reproduce it by calling
`sqlmigrate` on any migration that adds a char or text field with a default
value. The migration it self will go through, but sqlmigrate will fail.

I'll look into testcasing that.

On Mon, Apr 15, 2019 at 3:25 PM Claude Paroz  wrote:

> Please create a new ticket (where you can reference the original one).
> If you can provide a failing test case, it would be great.
>
> Claude
>
> Le lundi 15 avril 2019 13:40:53 UTC+2, Melvyn Sopacua | 3YOURMIND a écrit :
>
>> Hi,
>>
>> I've added a comment on the commit:
>> https://github.com/django/django/commit/3c4ff2176323dd20507e35658599da220fbe1741
>>
>> Should I reopen the bug or create a new one? Also it would help to know
>> what the return type is supposed to be or what the intention of the code
>> is? Should the if clause be `not instance` and should we be decoding or is
>> the test correct and should we be encoding?
>> --
>>
>> *Backend Developer*
>>
>> Mobile: +49 (0)160 179 6874
>> eMail: m...@3yourmind.com
>> Web: www.3yourmind.com
>> <http://www.google.com/url?q=http%3A%2F%2Fwww.3yourmind.com%2F&sa=D&sntz=1&usg=AFQjCNEYZ3Wap-Pu0DCItfT3gk0WDuP3nw>
>>
>>
>>
>> P.S. Ready for the #ManufacturingRevolution? Watch our new videos here
>> <https://www.youtube.com/c/3YOURMIND_DE>.
>>
>>
>>
>> P.P.S. Follow the top industry trends
>> <https://www.3yourmind.com/newsletter-sign-up?utm_campaign=email%20footer&utm_source=email>
>> in our newsletter.
>>
>>
>>
>> Meet us at:
>>
>> Rapid+TCT <https://rapid3devent.com/> | 20 - 23 May  | Detroit, USA|
>> Booth 753
>>
>> 3D Print Lyon <https://www.3dprint-exhibition.com/> | 4 - 6 June | Lyon,
>> FR
>>
>> Rapid.Tech Fabcon 3.D <https://www.rapidtech-fabcon.de/>  | 25 - 27 June
>> | Erfurt, DE | Booth 2-415
>>
>>
>>
>> We're hiring self-driven, innovative, AM-focused people here.
>> <https://www.3yourmind.com/career?utm_campaign=Career%20Offers&utm_source=Email%20footer&utm_medium=Email%20footer>
>>
>>
>> 3YOURMIND GmbH
>>
>> Bismarckstraße 10-12 | 10625 Berlin | Germany
>>
>>
>>
>> VAT ID - USt-IdNr. gemäß § 27 a Umsatzsteuergesetz: DE296555110
>>
>> Company with its registered seat in - Sitz der Gesellschaft: Berlin
>>
>> Register court - Registergericht: Amtsgericht Charlottenburg (Berlin)
>>
>> Register number - Registernummer: HRB 160616
>>
>> Executive Manager - Geschäftsführer: Aleksander Ciszek & Stephan Kühr
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To post to this group, send email to django-developers@googlegroups.com.
> Visit this group at https://groups.google.com/group/django-developers.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/3324c145-6f7b-468f-b98a-df738f33a557%40googlegroups.com
> <https://groups.google.com/d/msgid/django-developers/3324c145-6f7b-468f-b98a-df738f33a557%40googlegroups.com?utm_medium=email&utm_source=footer>
> .
> For more options, visit https://groups.google.com/d/optout.
>


-- 

*Backend Developer*

Mobile: +49 (0)160 179 6874
eMail: m...@3yourmind.com
Web: www.3yourmind.com
<http://www.google.com/url?q=http%3A%2F%2Fwww.3yourmind.com%2F&sa=D&sntz=1&usg=AFQjCNEYZ3Wap-Pu0DCItfT3gk0WDuP3nw>

-- 


P.S. Ready for the #ManufacturingRevolution? Watch our new videos here 
<https://www.youtube.com/c/3YOURMIND_DE>.

 

P.P.S. Follow the top 
industry trends 
<https://www.3yourmind.com/newsletter-sign-up?utm_campaign=email%20footer&utm_source=email>
 
in our newsletter.

 

Meet us at:

Rapid+TCT <https://rapid3devent.com/> | 
20 - 23 May  | Detroit, USA| Booth 753

3D Print Lyon 
<https://www.3dprint-exhibition.com/> | 4 - 6 June | Lyon, FR

Rapid.Tech 
Fabcon 3.D <https://www.rapidtech-fabcon.de/>  | 25 - 27 June | Erfurt, DE 
| Booth 2-415

 

We're hiring self-driven, innovative, AM-focused people 
here. 
<https://www.3yourmind.com/career?utm_campaign=Career%20Offers&utm_source=Email%20footer&utm_medium=Email%20footer>





3YOURMIND GmbH

Bismarckstraße 10-12 | 10625 Berlin | Germany

 

VAT 
ID - USt-IdNr. gemäß § 27 a Umsatzsteuergesetz: DE296555110

Company with 
its registered seat in - Sitz der Gesellschaft: Berlin

Register cou

Bugfix on #29103 creates different bug

[Melvyn Sopacua | 3YOURMIND]

Hi,

I've added a comment on the commit:
https://github.com/django/django/commit/3c4ff2176323dd20507e35658599da220fbe1741

Should I reopen the bug or create a new one? Also it would help to know
what the return type is supposed to be or what the intention of the code
is? Should the if clause be `not instance` and should we be decoding or is
the test correct and should we be encoding?
-- 

*Backend Developer*

Mobile: +49 (0)160 179 6874
eMail: m...@3yourmind.com
Web: www.3yourmind.com


-- 


P.S. Ready for the #ManufacturingRevolution? Watch our new videos here 
.

 

P.P.S. Follow the top 
industry trends 

 
in our newsletter.

 

Meet us at:

Rapid+TCT  | 
20 - 23 May  | Detroit, USA| Booth 753

3D Print Lyon 
 | 4 - 6 June | Lyon, FR

Rapid.Tech 
Fabcon 3.D   | 25 - 27 June | Erfurt, DE 
| Booth 2-415

 

We're hiring self-driven, innovative, AM-focused people 
here. 






3YOURMIND GmbH

Bismarckstraße 10-12 | 10625 Berlin | Germany

 

VAT 
ID - USt-IdNr. gemäß § 27 a Umsatzsteuergesetz: DE296555110

Company with 
its registered seat in - Sitz der Gesellschaft: Berlin

Register court - 
Registergericht: Amtsgericht Charlottenburg (Berlin)

Register number - 
Registernummer: HRB 160616



Executive Manager - Geschäftsführer: 
Aleksander Ciszek & Stephan Kühr

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAF5kSxTuFg3fQn5SXq68aK_UGaYBXeKAuYNcn9So88ZJR7onTg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.