Re: #27485 new New feature Allow ALLOWED_HOSTS to accept an IP-range / wildcard

2016-11-17 Thread Thomas Turner
Thank you all. I will have a look to see if I can do it without patching.

Tom

On Thursday, November 17, 2016 at 12:42:56 AM UTC, Thomas Turner wrote:
>
> Hi
>
> The other day I raise a ticket to do with ALLOWED_HOSTS and it was 
> suggested that I post on this group before creating a patch
> The ticket is https://code.djangoproject.com/ticket/27485
>
> The problem
>
> Now that Django 1.10.3 forces ALLOWED_HOSTS on with debug I have a problem.
> The problem is that when I developing I use an ip-address range of 
> 192.168.1.*. 
> The Ip-address can change depending on the computer I use.
> so I required the ability to add wildcard partly in an hostname.
> ie 
> ALLOWED_HOSTS = ['192.168.1.*', '.mydomain.com']
> I have seen this solution that doesn't require Django to be changed 
> however I don't like it as I feel this could be a security issue
> ​
> http://stackoverflow.com/questions/37031749/django-allowed-hosts-ips-range
>
> I happy to do a patch for this. What do people think?
>
> Tom
>
>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/b5acf0e5-5114-4346-8cd3-75e3946c973d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


#27485 new New feature Allow ALLOWED_HOSTS to accept an IP-range / wildcard

2016-11-16 Thread Thomas Turner
Hi

The other day I raise a ticket to do with ALLOWED_HOSTS and it was 
suggested that I post on this group before creating a patch
The ticket is https://code.djangoproject.com/ticket/27485

The problem

Now that Django 1.10.3 forces ALLOWED_HOSTS on with debug I have a problem.
The problem is that when I developing I use an ip-address range of 
192.168.1.*. 
The Ip-address can change depending on the computer I use.
so I required the ability to add wildcard partly in an hostname.
ie 
ALLOWED_HOSTS = ['192.168.1.*', '.mydomain.com']
I have seen this solution that doesn't require Django to be changed however 
I don't like it as I feel this could be a security issue
​http://stackoverflow.com/questions/37031749/django-allowed-hosts-ips-range

I happy to do a patch for this. What do people think?

Tom



-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/7c03baf9-8d87-4716-be66-f6a642721a77%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.