Re: For discussion: JSON-aware views for error responses

2022-04-22 Thread vanadium23
I've done some work long ago. May be will help for someone.
https://github.com/django/django/pull/8947

On Friday, 22 April 2022 at 08:53:56 UTC+3 Tobias Bengfort wrote:

> +1 from me.
>
> On 14/04/2022 11.03, Ville Säävuori wrote:
> > And to be clear, I understand we already have middleware APIs and 
> > various settings to handle this but my point is that I think handling 
> > this in Django core (even as an optional setting or middleware) would be 
> > most useful and right way to do this for the community.
>
> Can you provide some examples? I support the general idea, but having 
> some concrete APIs to discuss might be helpful.
>
> thanks
> tobias
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/744c3b96-4c42-4eac-a451-5c6f6da446fdn%40googlegroups.com.


Re: On adding comments to database schema

2019-06-04 Thread vanadium23
I've made it as a separate django libm but only for PostgresSQL:
https://github.com/vanadium23/django-db-comments

среда, 5 июня 2019 г., 0:29:21 UTC+3 пользователь Mauricio Cordero написал:
>
> Hello all, just wondering if this feature was ever implemented. 
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/a8bf7145-d878-4ef0-b39c-3ea3ad7f62ac%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: On adding comments to database schema

2018-03-18 Thread vanadium23
Hi, community.

I've been stuck at realization, because Postgres and oracle have a syntax 
like comment on {table}.{column} for storing comments, so this needs to be 
done after table/column creation.

So there are two ways:
1. Add it to post migrate signal, as for content types. But I can implement 
it as a third-party lib
2. Add this SQL after database creation in schema.py
Which way is better?

воскресенье, 11 марта 2018 г., 11:34:46 UTC+3 пользователь vanadium23 
написал:
>
> That's good. I'll prepare the patch for review.
>
> суббота, 10 марта 2018 г., 10:27:30 UTC+3 пользователь Aymeric Augustin 
> написал:
>>
>> I think we could implement that feature.
>>
>> (Yes I changed my mind from six years ago when I wontfix'd the ticket.)
>>
>> -- 
>> Aymeric.
>>
>>
>>
>> On 8 Mar 2018, at 11:00, Jani Tiainen <red...@gmail.com> wrote:
>>
>> Oracle supports comments as well.
>>
>> 7.3.2018 2.52 ip. "vanadium23" <cherno...@gmail.com> kirjoitti:
>>
>>> Hello, fellows.
>>>
>>> There was once a proposal about ability to add comments to table/columns 
>>> in postgres: https://code.djangoproject.com/ticket/18468
>>> I re-read discussion in ticket, and it has ended with another proposal, 
>>> that now migrations is within Django, so we can add this feature.
>>>
>>> I want to make it as a third-party libs, but has come to thought that 
>>> need to extend SchemaEditor, but it's not good for maintainability.
>>> Also, not only postgres has this feature, but also MySQL.
>>>
>>> Motivation for this feature is that some sort of users can view code 
>>> comments without access to VCS of the project.
>>>
>>> -- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "Django developers (Contributions to Django itself)" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to django-develop...@googlegroups.com.
>>> To post to this group, send email to django-d...@googlegroups.com.
>>> Visit this group at https://groups.google.com/group/django-developers.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/django-developers/484264c0-b7d1-4264-b8b5-8857847f6b53%40googlegroups.com
>>>  
>>> <https://groups.google.com/d/msgid/django-developers/484264c0-b7d1-4264-b8b5-8857847f6b53%40googlegroups.com?utm_medium=email_source=footer>
>>> .
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Django developers (Contributions to Django itself)" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to django-develop...@googlegroups.com.
>> To post to this group, send email to django-d...@googlegroups.com.
>> Visit this group at https://groups.google.com/group/django-developers.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/django-developers/CAHn91oesnBvY-mWXoHWa3sf8Vri%2B1qwRHat1yF%2B8Sdm0pU-LhQ%40mail.gmail.com
>>  
>> <https://groups.google.com/d/msgid/django-developers/CAHn91oesnBvY-mWXoHWa3sf8Vri%2B1qwRHat1yF%2B8Sdm0pU-LhQ%40mail.gmail.com?utm_medium=email_source=footer>
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/9ff6c9f5-045e-4bc7-8331-060471b012e2%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: On adding comments to database schema

2018-03-11 Thread vanadium23
That's good. I'll prepare the patch for review.

суббота, 10 марта 2018 г., 10:27:30 UTC+3 пользователь Aymeric Augustin 
написал:
>
> I think we could implement that feature.
>
> (Yes I changed my mind from six years ago when I wontfix'd the ticket.)
>
> -- 
> Aymeric.
>
>
>
> On 8 Mar 2018, at 11:00, Jani Tiainen <red...@gmail.com > 
> wrote:
>
> Oracle supports comments as well.
>
> 7.3.2018 2.52 ip. "vanadium23" <cherno...@gmail.com > 
> kirjoitti:
>
>> Hello, fellows.
>>
>> There was once a proposal about ability to add comments to table/columns 
>> in postgres: https://code.djangoproject.com/ticket/18468
>> I re-read discussion in ticket, and it has ended with another proposal, 
>> that now migrations is within Django, so we can add this feature.
>>
>> I want to make it as a third-party libs, but has come to thought that 
>> need to extend SchemaEditor, but it's not good for maintainability.
>> Also, not only postgres has this feature, but also MySQL.
>>
>> Motivation for this feature is that some sort of users can view code 
>> comments without access to VCS of the project.
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Django developers (Contributions to Django itself)" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to django-develop...@googlegroups.com .
>> To post to this group, send email to django-d...@googlegroups.com 
>> .
>> Visit this group at https://groups.google.com/group/django-developers.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/django-developers/484264c0-b7d1-4264-b8b5-8857847f6b53%40googlegroups.com
>>  
>> <https://groups.google.com/d/msgid/django-developers/484264c0-b7d1-4264-b8b5-8857847f6b53%40googlegroups.com?utm_medium=email_source=footer>
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to django-develop...@googlegroups.com .
> To post to this group, send email to django-d...@googlegroups.com 
> .
> Visit this group at https://groups.google.com/group/django-developers.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/django-developers/CAHn91oesnBvY-mWXoHWa3sf8Vri%2B1qwRHat1yF%2B8Sdm0pU-LhQ%40mail.gmail.com
>  
> <https://groups.google.com/d/msgid/django-developers/CAHn91oesnBvY-mWXoHWa3sf8Vri%2B1qwRHat1yF%2B8Sdm0pU-LhQ%40mail.gmail.com?utm_medium=email_source=footer>
> .
> For more options, visit https://groups.google.com/d/optout.
>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/f37ea3f6-1f9c-4699-8feb-c85d024130e2%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


On adding comments to database schema

2018-03-07 Thread vanadium23
Hello, fellows.

There was once a proposal about ability to add comments to table/columns in 
postgres: https://code.djangoproject.com/ticket/18468
I re-read discussion in ticket, and it has ended with another proposal, 
that now migrations is within Django, so we can add this feature.

I want to make it as a third-party libs, but has come to thought that need 
to extend SchemaEditor, but it's not good for maintainability.
Also, not only postgres has this feature, but also MySQL.

Motivation for this feature is that some sort of users can view code 
comments without access to VCS of the project.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/484264c0-b7d1-4264-b8b5-8857847f6b53%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.