Re: Feedback on ticket #12399
On Wed, Jan 27, 2010 at 1:19 AM, Russell Keith-Magee wrote: > On Wed, Jan 27, 2010 at 12:30 AM, Giuseppe Ciotta wrote: >> http://code.djangoproject.com/ticket/12399 >> >> It's a nasty bug which leads to a 100% cache misses situation on >> memcached when using long keys timeouts. >> >> Do you think we can have this included in 1.2? Should i mark it with >> Version:1.2 or something? The patch itself is trivial. > > Marking the ticket as "Milestone 1.2" will put it on the list of bugs > that will be considered for 1.2. > > Looking at the patch, the one thing that is missing is tests. Without > tests, a patch won't get anywhere near trunk, no matter how trivial. The test is included in the latest patch and bug's marked for the 1.2 milestone. The patch may introduce a slightly backward-incompatible change for people using long timeouts as absolute timestamps, but in my opinion this is highly unlikely and the documentation never mentioned anything about it. -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
Re: Feedback on ticket #12399
The second patch [1] fixes the memcached backend. [1] http://code.djangoproject.com/attachment/ticket/12399/memcached-timeout-fixes.diff -- Gert Mobile: +32 498725202 Web: http://gert.selentic.net On Wed, Jan 27, 2010 at 08:28, Kristian Klette wrote: > > It's a nasty bug which leads to a 100% cache misses situation on > > memcached when using long keys timeouts. > > Wouldn't it be better to fix this in the memcache backend itself? It does > cause a backward compatibility problem for users that do takes this > memcached > behaviour into account in their code though. > > Either way, this memcached behaviour should be mentioned in the cache > documentation. > > - Kristian > > -- > You received this message because you are subscribed to the Google Groups > "Django developers" group. > To post to this group, send email to django-develop...@googlegroups.com. > To unsubscribe from this group, send email to > django-developers+unsubscr...@googlegroups.com > . > For more options, visit this group at > http://groups.google.com/group/django-developers?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
Re: Feedback on ticket #12399
> It's a nasty bug which leads to a 100% cache misses situation on > memcached when using long keys timeouts. Wouldn't it be better to fix this in the memcache backend itself? It does cause a backward compatibility problem for users that do takes this memcached behaviour into account in their code though. Either way, this memcached behaviour should be mentioned in the cache documentation. - Kristian -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
Re: Feedback on ticket #12399
On Wed, Jan 27, 2010 at 12:30 AM, Giuseppe Ciotta wrote: > http://code.djangoproject.com/ticket/12399 > > It's a nasty bug which leads to a 100% cache misses situation on > memcached when using long keys timeouts. > > Do you think we can have this included in 1.2? Should i mark it with > Version:1.2 or something? The patch itself is trivial. Marking the ticket as "Milestone 1.2" will put it on the list of bugs that will be considered for 1.2. Looking at the patch, the one thing that is missing is tests. Without tests, a patch won't get anywhere near trunk, no matter how trivial. Yours, Russ Magee %-) -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
Feedback on ticket #12399
http://code.djangoproject.com/ticket/12399 It's a nasty bug which leads to a 100% cache misses situation on memcached when using long keys timeouts. Do you think we can have this included in 1.2? Should i mark it with Version:1.2 or something? The patch itself is trivial. -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
