Re: Missing semi-colon

[Jonathan S]

Thanks, I made a patch and created a ticket.

http://code.djangoproject.com/ticket/15490


On 23 fév, 13:48, Russell Keith-Magee  wrote:
> On Wed, Feb 23, 2011 at 8:24 PM, Jonathan S  
> wrote:
> > Aparently, there are several semicolons missing at several places:
>
> > django/contrib/admin/templates/admin/edit_inline/tabular.html  lines
> > 90, 94 and 124
> > django/contrib/admin/templates/admin/edit_inline/stacked.html  lines
> > 45, 48 and 78
>
> > Of course, this really is a minor issue, but easy enough to fix.
>
> Thanks for the report -- the best (and preferred) way to report this
> is to open a ticket in Trac, ideally with a patch describing the
> change you think needs to be made.
>
> Yours,
> Russ Magee %-)
>
>
>
>
>
>
>
> > --
> > You received this message because you are subscribed to the Google Groups 
> > "Django developers" group.
> > To post to this group, send email to django-developers@googlegroups.com.
> > To unsubscribe from this group, send email to 
> > django-developers+unsubscr...@googlegroups.com.
> > For more options, visit this group 
> > athttp://groups.google.com/group/django-developers?hl=en.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: Missing semi-colon

[Russell Keith-Magee]

On Wed, Feb 23, 2011 at 8:24 PM, Jonathan S  wrote:
> Aparently, there are several semicolons missing at several places:
>
> django/contrib/admin/templates/admin/edit_inline/tabular.html  lines
> 90, 94 and 124
> django/contrib/admin/templates/admin/edit_inline/stacked.html  lines
> 45, 48 and 78
>
> Of course, this really is a minor issue, but easy enough to fix.

Thanks for the report -- the best (and preferred) way to report this
is to open a ticket in Trac, ideally with a patch describing the
change you think needs to be made.

Yours,
Russ Magee %-)
> --
> You received this message because you are subscribed to the Google Groups 
> "Django developers" group.
> To post to this group, send email to django-developers@googlegroups.com.
> To unsubscribe from this group, send email to 
> django-developers+unsubscr...@googlegroups.com.
> For more options, visit this group at 
> http://groups.google.com/group/django-developers?hl=en.
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: Missing semi-colon

[Jonathan S]

Aparently, there are several semicolons missing at several places:

django/contrib/admin/templates/admin/edit_inline/tabular.html  lines
90, 94 and 124
django/contrib/admin/templates/admin/edit_inline/stacked.html  lines
45, 48 and 78

Of course, this really is a minor issue, but easy enough to fix.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Missing semi-colon

[Jonathan S]

Hi Django admin developers,

Can you please insert a semi-colon in the following file, behind line
90?

django/contrib/admin/templates/admin/edit_inline/tabular.html


var updateSelectFilter = function() {
// If any SelectFilter widgets are a part of the new form,
// instantiate a new SelectFilter instance for it.
if (typeof SelectFilter != "undefined"){
$(".selectfilter").each(function(index, value){
  var namearr = value.name.split('-');
  SelectFilter.init(value.id,
namearr[namearr.length-1], false, "{% admin_media_prefix %}");
})
--> please insert semi-colon here.
$(".selectfilterstacked").each(function(index, value){
  var namearr = value.name.split('-');
  SelectFilter.init(value.id,
namearr[namearr.length-1], true, "{% admin_media_prefix %}");
})
}
}

Thanks a lot,
Jonathan

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.